Fixed rB8b806b8e64115d231841d9bf203b254263b33b96

In T69003#761596, @Ludvik Koutny (rawalanche) wrote:

Very disappointing implementation:

Committed rBacdb14d264c8b4eced645673f8ae8af1a96b1a90

Tested with clang's -Weverything, doesn't introduce new warnings.

@Ivo van der Lans (Ivo) it's a valid point, the counter to this would be that well designed tools would minimize confusion for the user.

We could have basic support for holes, eg: keep the mesh structure virtually the same as it is now, only adding flags to denote holes (add a flag for a complex polygon, and a flag for polygons after it to be used as holes).

It's a down-side, I'm not defending it - however you are re-raising a topic that was closed months ago.

Many applications that use left click select, select on click not press.

@Pablo Dobarro (pablodp606), this is probably the way to go irrespective of hole support.

From the looks of it Maya supports holes in faces and had a sculpt tool,
although I didn't use either - just noting that it seems at least one other application does this.

Thanks, committed rB2930fbd86c0a0e8e2e76c7652d4d799ddf9fc8ef

Talked on chat, I understand how it works now.

Yes, should be renamed in internal code too, the keymap needs updating.

Testing this and I don't follow the logic being used, it's using the initial offset to snap to an edge in a way that isn't easy to follow.

@TheRedWaxPolice (TheRedWaxPolice) this isn't really related to undo/redo, please keep replies here on topic.

Think this is more a design task, were we have to weight up the pros and cons.

Looked into it, while the height is used internally, the UI_block_bounds_set_popup call causes the height to be ignored.

Suggest to rename this "Edge Mid-point" since it's not obvious this is only for edges.

Maybe they have automated it or are manually copy-paste it.

Phabricator doesn't give us a way to access your email.

You were attributed in the commit message and the patch was linked.

Thanks, committed rB61ff578eab16ab627415e06c2a81b339d4be0f99

Minor corrections

• Correction to last commit (missed rename ADDON-BUG -> BUG_ADDON)

• Move websites and there URL's into a single list which can be dynamically extended.
• Use URL presets for splash screen and about menu.
• Add descriptions.