Page MenuHome

Campbell Barton (campbellbarton)
EngineeringAdministrator

Projects (29)

User Details

User Since
Jan 30 2005, 5:47 PM (903 w, 6 d)
Roles
Administrator

Recent Activity

Today

Campbell Barton (campbellbarton) committed rB93e4b15767cf: Cleanup: clang-tidy for GHOST X11/SDL/Wayland/NULL backends (authored by Campbell Barton (campbellbarton)).
Cleanup: clang-tidy for GHOST X11/SDL/Wayland/NULL backends
Sun, May 29, 5:36 AM

Yesterday

Campbell Barton (campbellbarton) committed rB16166f69be46: Fix pasting text from Blender in GHOST/Wayland (authored by Campbell Barton (campbellbarton)).
Fix pasting text from Blender in GHOST/Wayland
Sat, May 28, 8:08 AM
Campbell Barton (campbellbarton) updated the task description for T76428: GHOST/Wayland Support.
Sat, May 28, 7:59 AM · Platform: Linux, BF Blender
Campbell Barton (campbellbarton) committed rB5dfff02437c6: Fix switching between different grab types with GHOST/Wayland (authored by Campbell Barton (campbellbarton)).
Fix switching between different grab types with GHOST/Wayland
Sat, May 28, 7:58 AM
Campbell Barton (campbellbarton) created T98462: Save Screenshot (glReadPixels) fails under Wayland.
Sat, May 28, 7:18 AM · Platform: Linux
Campbell Barton (campbellbarton) updated the task description for T98461: Regression: Crash running screenshot from the command-line.
Sat, May 28, 6:11 AM · BF Blender, User Interface
Campbell Barton (campbellbarton) created T98461: Regression: Crash running screenshot from the command-line.
Sat, May 28, 6:10 AM · BF Blender, User Interface
Campbell Barton (campbellbarton) accepted D14587: Expose background job info to Python.
Sat, May 28, 5:43 AM · BF Blender

Fri, May 27

Campbell Barton (campbellbarton) changed the status of T98370: Regression: keymap 2.7x: Right click does not deselect the other nodes from Confirmed to Needs Information from User.
Fri, May 27, 2:38 PM · User Interface, BF Blender
Campbell Barton (campbellbarton) added a comment to T98370: Regression: keymap 2.7x: Right click does not deselect the other nodes.

@Serge Lyatin (SergeL) I can't redo the problem, can you check if this was fixed by rB790fe55c52057919b3f3f6e95f4e510719293eeb ?

Fri, May 27, 2:36 PM · User Interface, BF Blender
Campbell Barton (campbellbarton) committed rBda9e14b0b91c: Fix GHOST_kGrabHide in Wayland (authored by Campbell Barton (campbellbarton)).
Fix GHOST_kGrabHide in Wayland
Fri, May 27, 8:49 AM
Campbell Barton (campbellbarton) committed rB46456a59c44f: GHOST/Wayland: support mouse buttons 4-7 (authored by Campbell Barton (campbellbarton)).
GHOST/Wayland: support mouse buttons 4-7
Fri, May 27, 7:56 AM
Campbell Barton (campbellbarton) committed rB7aad4d459e08: Cleanup: unused argument warnings (authored by Campbell Barton (campbellbarton)).
Cleanup: unused argument warnings
Fri, May 27, 7:56 AM
Campbell Barton (campbellbarton) committed rB6d4f16a77616: Fix non-square cursor creation in GHOST/SDL (authored by Campbell Barton (campbellbarton)).
Fix non-square cursor creation in GHOST/SDL
Fri, May 27, 7:56 AM
Campbell Barton (campbellbarton) committed rB49032a8ca5c3: Fix error checking the search callback (authored by Campbell Barton (campbellbarton)).
Fix error checking the search callback
Fri, May 27, 6:29 AM
Campbell Barton (campbellbarton) requested changes to D6505: UI: Scrollbar Behavior Changes.

Looking into this patch, it's mostly fine but noticed two issues.

Fri, May 27, 4:29 AM · BF Blender (3.2), User Interface
Campbell Barton (campbellbarton) updated the title for P2979 D6505: tweak, fully hide scrollbars when region overlap is enabled from D6505: update to D6505: tweak, fully hide scrollbars when region overlap is enabled.
Fri, May 27, 3:31 AM
Campbell Barton (campbellbarton) created P2979 D6505: tweak, fully hide scrollbars when region overlap is enabled.
Fri, May 27, 3:28 AM
Campbell Barton (campbellbarton) accepted D11800: IME Cleanup: Removal of BLT_lang_is_ime_supported.
Fri, May 27, 2:21 AM

Thu, May 26

Pratik Borhade (PratikPB2123) awarded rB790fe55c5205: Fix Blender 2.7x keymap faulure to select & drag multiple nodes a Like token.
Thu, May 26, 8:24 PM
Campbell Barton (campbellbarton) added a comment to rBf68fb8106429: Fix T98145: IC keymap can't select & move multiple nodes.

@Campbell Barton (campbellbarton) hi, same issue applies to 27x keymap.
Can you commit the fix for it? or want me to open a report for that?

Thu, May 26, 1:43 PM
Campbell Barton (campbellbarton) committed rBd6badf6fde91: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Thu, May 26, 1:26 PM
Campbell Barton (campbellbarton) committed rB2a367689d415: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Thu, May 26, 1:26 PM
Campbell Barton (campbellbarton) committed rB38a2576acef0: Fix display error after sorting mesh elements (authored by Campbell Barton (campbellbarton)).
Fix display error after sorting mesh elements
Thu, May 26, 1:25 PM
Campbell Barton (campbellbarton) committed rB790fe55c5205: Fix Blender 2.7x keymap faulure to select & drag multiple nodes (authored by Campbell Barton (campbellbarton)).
Fix Blender 2.7x keymap faulure to select & drag multiple nodes
Thu, May 26, 1:25 PM
Campbell Barton (campbellbarton) closed D15021: Cleanup: UV: `struct PHandle` merged with alias `typedef void ParamHandle`.
Thu, May 26, 12:06 PM · BF Blender, Modeling, Restricted Project
Campbell Barton (campbellbarton) committed rBfdb1a7b5e154: Cleanup: `struct PHandle` merged with alias `typedef void ParamHandle` (authored by Chris Blackbourn (chrisbblend)).
Cleanup: `struct PHandle` merged with alias `typedef void ParamHandle`
Thu, May 26, 12:06 PM
Campbell Barton (campbellbarton) added a comment to D15028: Fix T98338: Rolling the viewport causes unpredictable behavior when orbiting using turntable method.

This is a difficult area, all of the solutions I tried here have pros/cons which could be considered bugs. From testing the patch I don't find either current or new behavior very intuitive, although the behavior in master is worse in the case of an exactly 90degree rotated horizon.

Thu, May 26, 9:47 AM
Campbell Barton (campbellbarton) added a comment to T98380: Keymap preferences - incomplete tool shelf tooltip with Spacebar action set to Search.

Activating the tool and the direct access aren't the same, we could show the operator key shortcut, but that's giving a hint for an alternate method of access, not a shortcut for the equivalent the action.

Thu, May 26, 8:10 AM · BF Blender
Campbell Barton (campbellbarton) committed rB374ce5dcb492: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Thu, May 26, 8:07 AM
Campbell Barton (campbellbarton) closed T94857: Regression: 'Gizmo Operator' from python templates is spining in accumulative way, when dragged. as Resolved by committing rB3131107ba3aa: Fix T94857: 'Gizmo Operator' from python templates spins when dragged.
Thu, May 26, 7:59 AM · User Interface, Python API, BF Blender
Campbell Barton (campbellbarton) committed rB3131107ba3aa: Fix T94857: 'Gizmo Operator' from python templates spins when dragged (authored by Campbell Barton (campbellbarton)).
Fix T94857: 'Gizmo Operator' from python templates spins when dragged
Thu, May 26, 7:59 AM
Campbell Barton (campbellbarton) closed T98380: Keymap preferences - incomplete tool shelf tooltip with Spacebar action set to Search as Archived.

In this case there is no shortcut for the toolbar, so no shortcut is shown in the tooltip.

Thu, May 26, 6:43 AM · BF Blender
Campbell Barton (campbellbarton) committed rBae5d3fa2d03f: UI: use visible regions when showing candidates for operators data-path (authored by Campbell Barton (campbellbarton)).
UI: use visible regions when showing candidates for operators data-path
Thu, May 26, 6:16 AM
Campbell Barton (campbellbarton) committed rB3f3d82cfe9ce: UI support for showing candidates for string properties (authored by Campbell Barton (campbellbarton)).
UI support for showing candidates for string properties
Thu, May 26, 4:17 AM
Campbell Barton (campbellbarton) closed D14986: UI support for showing candidates for string properties.
Thu, May 26, 4:17 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Remove unnecessary headers
Thu, May 26, 4:15 AM · User Interface
Campbell Barton (campbellbarton) committed rB11480763b62e: Cleanup: format (authored by Campbell Barton (campbellbarton)).
Cleanup: format
Thu, May 26, 4:14 AM
Campbell Barton (campbellbarton) updated the summary of D14986: UI support for showing candidates for string properties.
Thu, May 26, 3:52 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Update based on feedback (remove unnecessary struct & avoid const-cast from C++ by changing the function to accept const bContext).
Thu, May 26, 3:47 AM · User Interface

Wed, May 25

Campbell Barton (campbellbarton) accepted D14988: Tool Icons: Support curve and objects with modifiers + color space fix.

Accepting although requesting some minor changes.

Wed, May 25, 2:01 PM
Campbell Barton (campbellbarton) committed rBadaf92b4abe5: Cleanup: knife tool (authored by Campbell Barton (campbellbarton)).
Cleanup: knife tool
Wed, May 25, 9:50 AM
Campbell Barton (campbellbarton) committed rBc9a9763e36ab: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Wed, May 25, 9:21 AM
Campbell Barton (campbellbarton) committed rB80e007fe8c5b: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Wed, May 25, 9:21 AM
Campbell Barton (campbellbarton) closed T98349: Regression: Knife project - resulting selection is wrong as Resolved by committing rBaab947eb468c: Fix T98349: Knife project resulting selection is wrong.
Wed, May 25, 9:18 AM · Modeling, BF Blender
Campbell Barton (campbellbarton) committed rBaab947eb468c: Fix T98349: Knife project resulting selection is wrong (authored by Campbell Barton (campbellbarton)).
Fix T98349: Knife project resulting selection is wrong
Wed, May 25, 9:18 AM
Campbell Barton (campbellbarton) committed rB26c6ec559414: Cleanup: remove context argument from EDBM_mesh_knife (authored by Campbell Barton (campbellbarton)).
Cleanup: remove context argument from EDBM_mesh_knife
Wed, May 25, 9:18 AM
Campbell Barton (campbellbarton) claimed T98349: Regression: Knife project - resulting selection is wrong.
Wed, May 25, 7:27 AM · Modeling, BF Blender
Campbell Barton (campbellbarton) committed rB57b87feda152: PyDoc: suppress duplicate object description warning (authored by Campbell Barton (campbellbarton)).
PyDoc: suppress duplicate object description warning
Wed, May 25, 5:44 AM
Campbell Barton (campbellbarton) committed rBd46647040d91: PyDoc: fix generated output for gpu.shader (authored by Campbell Barton (campbellbarton)).
PyDoc: fix generated output for gpu.shader
Wed, May 25, 5:44 AM
Campbell Barton (campbellbarton) committed rBae73bd3d9ebc: Cleanup: use doxy sections for mathutils types (authored by Campbell Barton (campbellbarton)).
Cleanup: use doxy sections for mathutils types
Wed, May 25, 5:44 AM
Campbell Barton (campbellbarton) committed rBceff1c2f6545: Cleanup: spelling, unbalanced doxy sections (authored by Campbell Barton (campbellbarton)).
Cleanup: spelling, unbalanced doxy sections
Wed, May 25, 5:44 AM
Campbell Barton (campbellbarton) edited P2973 bpy.app.is_job_running(...) patch on D14587.
Wed, May 25, 1:36 AM

Tue, May 24

Campbell Barton (campbellbarton) edited P2973 bpy.app.is_job_running(...) patch on D14587.
Tue, May 24, 2:04 PM
Campbell Barton (campbellbarton) added a comment to D14587: Expose background job info to Python.

Including the function in bpy.app doesn't involve so much boiler plate code, although support for methods was needed.

Tue, May 24, 2:02 PM · BF Blender
Campbell Barton (campbellbarton) updated the language for P2973 bpy.app.is_job_running(...) patch on D14587 from autodetect to diff.
Tue, May 24, 1:59 PM
Campbell Barton (campbellbarton) created P2973 bpy.app.is_job_running(...) patch on D14587.
Tue, May 24, 1:59 PM
Campbell Barton (campbellbarton) added inline comments to D14587: Expose background job info to Python.
Tue, May 24, 1:25 PM · BF Blender
Campbell Barton (campbellbarton) added a comment to D14988: Tool Icons: Support curve and objects with modifiers + color space fix.

Generally this patch seems fine, I noticed the material color (which I assume is in linear space) is being mixed with the sRGB color without being converted to sRGB as well.

Tue, May 24, 10:25 AM
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Note the purpose of PROP_STRING_SEARCH_SUPPORTED.
Tue, May 24, 10:02 AM · User Interface
Campbell Barton (campbellbarton) changed the subtype of T94791: GizmoAPI: Lines appear between triangles using "DEPTH_3D" option. from "Report" to "Known Issue".

Yes, this used to work: http://members.iinet.net.au/~ideasman42/random/facemap_28.ogv

Tue, May 24, 9:58 AM · User Interface, Python API, BF Blender
Campbell Barton (campbellbarton) accepted D14979: Select Similar: hide 'compare' from UI when not used.
Tue, May 24, 9:51 AM · Modeling, Animation & Rigging, User Interface
Campbell Barton (campbellbarton) added a comment to D14947: Add support for `VA_NARGS_COUNT() == 0`.

This is verbose and difficult enough to predict how changes might impact different compilers, that I'd want to see the use case for it's inclusion.

Tue, May 24, 9:33 AM
Campbell Barton (campbellbarton) updated the summary of D14986: UI support for showing candidates for string properties.
Tue, May 24, 8:04 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Remove string length variables from Python
Tue, May 24, 8:00 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Remove string length from StringPropertySearchVisitParams (in most cases this had to be set by calling strlen, so there wasn't much advantage).
Tue, May 24, 7:59 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Remove unnecessary headers.
Tue, May 24, 7:51 AM · User Interface
Campbell Barton (campbellbarton) added inline comments to D14986: UI support for showing candidates for string properties.
Tue, May 24, 7:49 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Enable suggestion by default from the Python API
Tue, May 24, 7:47 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Add search options to sort, so the caller doesn't need to sort the results.
  • Also add SUGGESTION option, although this is currently ignored as it causes the sort callback to run on draw (to display red-alert highlight when the string isn't found).
Tue, May 24, 7:35 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Correct allocations & Python doc-string
Tue, May 24, 5:50 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Pass a parameters struct to the visit funciton, to make adding optional arguments more convenient.
  • Optional support showing an "info" field, disabled by default as in most string popups there isn't enough room to display these usefully. Enable with a G.debug_value of 102.
Tue, May 24, 5:28 AM · User Interface
Campbell Barton (campbellbarton) added a comment to D14986: UI support for showing candidates for string properties.

This is a great improvement over what we have. I wonder if we could go a step further and have the search allow users to pick either the Operator name (e.g., Make Local) or its Python name (bpy.ops.object.make_local).

Tue, May 24, 4:10 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Use natural string comparison
Tue, May 24, 3:15 AM · User Interface
Campbell Barton (campbellbarton) committed rBbb6f0b085e6e: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Tue, May 24, 3:02 AM
Campbell Barton (campbellbarton) committed rBd55e1caa75c9: Fix T98185: Assertion saving while fullscreen (authored by Campbell Barton (campbellbarton)).
Fix T98185: Assertion saving while fullscreen
Tue, May 24, 3:01 AM
Campbell Barton (campbellbarton) awarded rB0d7311345295: UI Code Quality: Resolve frankenstein bit-flag usage for widget drawing a Like token.
Tue, May 24, 1:25 AM

Mon, May 23

Campbell Barton (campbellbarton) added inline comments to D14989: Python API: add mathutils.Color functions to convert color spaces.
Mon, May 23, 2:41 PM
Campbell Barton (campbellbarton) accepted D14989: Python API: add mathutils.Color functions to convert color spaces.
Mon, May 23, 2:39 PM
Campbell Barton (campbellbarton) added a comment to D15012: Do not provide python libraries for linking if building python module..

Accepting but only for the Linux side, I won't apply in case other reviewers wanted to reply.

Mon, May 23, 11:22 AM · BF Blender
Cian Jinks (Hobbes) awarded rB690ecaae208d: Fix T97153: Knife project crashes a Love token.
Mon, May 23, 11:14 AM
Campbell Barton (campbellbarton) accepted D15012: Do not provide python libraries for linking if building python module..
Mon, May 23, 10:53 AM · BF Blender
Campbell Barton (campbellbarton) added a comment to D14989: Python API: add mathutils.Color functions to convert color spaces.

From/to ordering would be fine by me (although no strong opinion either way).

Mon, May 23, 10:51 AM
Hadrien Brissaud (hadrien) awarded D14986: UI support for showing candidates for string properties a Love token.
Mon, May 23, 8:53 AM · User Interface
Hadrien Brissaud (hadrien) awarded T88021: Edit-Mesh Performance Overview a Love token.
Mon, May 23, 8:48 AM · Modeling
Campbell Barton (campbellbarton) committed rBad33e6834861: Cleanup: remove "texture" from ED_mesh_uv_texture_* funcitons (authored by Campbell Barton (campbellbarton)).
Cleanup: remove "texture" from ED_mesh_uv_texture_* funcitons
Mon, May 23, 4:50 AM
Campbell Barton (campbellbarton) committed rB1e882b86579b: PyDoc: quiet output and minor cleanup (authored by Campbell Barton (campbellbarton)).
PyDoc: quiet output and minor cleanup
Mon, May 23, 4:39 AM
Campbell Barton (campbellbarton) committed rB4d509fd6e14c: Fix error in sphinx_doc_gen.py when logging (authored by Campbell Barton (campbellbarton)).
Fix error in sphinx_doc_gen.py when logging
Mon, May 23, 4:38 AM
Campbell Barton (campbellbarton) committed rBc92f137a7556: Merge branch 'blender-v3.2-release' (authored by Campbell Barton (campbellbarton)).
Merge branch 'blender-v3.2-release'
Mon, May 23, 4:38 AM
Campbell Barton (campbellbarton) committed rB47b0ca85cd95: Fix float representation for Python API docs (authored by Campbell Barton (campbellbarton)).
Fix float representation for Python API docs
Mon, May 23, 4:36 AM
Campbell Barton (campbellbarton) added a comment to D14989: Python API: add mathutils.Color functions to convert color spaces.

Having all these methods with color space names as top-level methods clutters the namespace.

Mon, May 23, 3:04 AM
Campbell Barton (campbellbarton) updated the summary of D14986: UI support for showing candidates for string properties.
Mon, May 23, 2:41 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Additional doc-strings, correct & expand on docs.
Mon, May 23, 2:34 AM · User Interface
Campbell Barton (campbellbarton) updated the summary of D14986: UI support for showing candidates for string properties.
Mon, May 23, 2:32 AM · User Interface

Sun, May 22

Campbell Barton (campbellbarton) committed rB45ed325443a3: PyDoc: resolve/quiet warnings for pylint (authored by Campbell Barton (campbellbarton)).
PyDoc: resolve/quiet warnings for pylint
Sun, May 22, 5:37 AM
Campbell Barton (campbellbarton) committed rB84901adec55e: PyDoc: cleanup doc-generator (authored by Campbell Barton (campbellbarton)).
PyDoc: cleanup doc-generator
Sun, May 22, 5:37 AM

Sat, May 21

Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Fix reference counting error with last update
Sat, May 21, 8:07 AM · User Interface
Campbell Barton (campbellbarton) updated the diff for D14986: UI support for showing candidates for string properties.
  • Support Python iterators/generators (without converting them into lists first)
Sat, May 21, 8:03 AM · User Interface
Harley Acheson (harley) awarded D14986: UI support for showing candidates for string properties a Party Time token.
Sat, May 21, 7:46 AM · User Interface

Fri, May 20

Erick Tukuniata (erickblender) awarded D14986: UI support for showing candidates for string properties a Like token.
Fri, May 20, 3:47 PM · User Interface