Page MenuHome

Cheryl Chen (chnchryl)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2018, 10:59 AM (163 w, 4 d)

Recent Activity

Mar 14 2018

Cheryl Chen (chnchryl) updated the diff for D3098: T53971: Render Result showing the wrong renderlayer in image editor.

I think the issue was with render_get_active_layer() looking up re->r.actlay in rr->layers (maybe as an optimisation?). Since rr->layers only contains the rendered layers, it sometimes returns the wrong layer when not layers are rendered. Also sima->iuser.layer did not always get updated because of the layer != rj->last_layer condition...

Mar 14 2018, 10:28 AM · BF Blender
Cheryl Chen (chnchryl) added a comment to D3098: T53971: Render Result showing the wrong renderlayer in image editor.

Ah...right. I did try doing nothing in render_image_restore_layer(), but for some reason, sima->iuser.layer is not always the right value before all render layers are rendered. I think it is because rr->renlay->name, which is used to look up the layer index, sometimes gets set to a previous layer's name (though somehow, the layer name being looked up is correct while rendering). Also, currently sima->iuser.layer is never set to 0, since it is only set when layer != rj->last_layer, and rj->last_layer is always 0...

Mar 14 2018, 1:16 AM · BF Blender

Mar 13 2018

Cheryl Chen (chnchryl) added a comment to D3098: T53971: Render Result showing the wrong renderlayer in image editor.

Thanks for the feedback!

Mar 13 2018, 1:14 AM · BF Blender

Mar 9 2018

Cheryl Chen (chnchryl) added a task to D3098: T53971: Render Result showing the wrong renderlayer in image editor: T53971: Render Result showing the wrong renderlayer in image editor.
Mar 9 2018, 11:09 PM · BF Blender
Cheryl Chen (chnchryl) added a revision to T53971: Render Result showing the wrong renderlayer in image editor: D3098: T53971: Render Result showing the wrong renderlayer in image editor.
Mar 9 2018, 11:09 PM · Rendering, BF Blender
Cheryl Chen (chnchryl) added a reviewer for D3098: T53971: Render Result showing the wrong renderlayer in image editor: Brecht Van Lommel (brecht).
Mar 9 2018, 11:07 PM · BF Blender
Cheryl Chen (chnchryl) created D3098: T53971: Render Result showing the wrong renderlayer in image editor.
Mar 9 2018, 10:57 PM · BF Blender

Mar 8 2018

Cheryl Chen (chnchryl) added a comment to T53971: Render Result showing the wrong renderlayer in image editor.

Yes, I think iuser->layer should be automatically set to the active render layer when "Only render active layer" is enabled. This means changing render_image_restore_layer() behavior.

Mar 8 2018, 11:41 AM · Rendering, BF Blender

Mar 6 2018

Cheryl Chen (chnchryl) added a comment to T53971: Render Result showing the wrong renderlayer in image editor.

Hi there, I'm new to this, but I've been poking around with this bug to find my way around. From what I gather, the displayed render-layer is affected by the value of ‘iuser->layer’ in ‘uiblock_layer_pass_buttons’, which displays the rendered layer corresponding to the index of ‘iuser->layer’. It's set to 1 initially, so when multiple layers are rendered consecutively, it keeps displaying the second layer in the rendered stack. (If there isn't a layer at that index, it'll just display the closest one.) If you select a different layer to be displayed in the image editor, ‘iuser->layer’ is properly updated to that layer's index, and then it'll keep displaying the render layer at that index until you set another layer.

Mar 6 2018, 11:02 PM · Rendering, BF Blender