Dalai Felinto (dfelinto)
Architect and Developer

Projects (17)

User Details

User Since
Jun 2 2006, 5:16 AM (577 w, 8 h)

Author of Game Development with Blender [ more info ]

Recent Activity

Today

Dalai Felinto (dfelinto) updated the diff for D2722: Fix grease pencil in sequencer not responding to scene scale [WIP].
  • Revert "Fix grease pencil in sequencer not responding to scene scale [WIP]"
  • Different approach, same results
Fri, Jun 23, 1:00 PM
Dalai Felinto (dfelinto) created D2722: Fix grease pencil in sequencer not responding to scene scale [WIP].
Fri, Jun 23, 12:50 PM
Dalai Felinto (dfelinto) committed rBc2d285f0ffc0: Grease Pencil: Fix hardcoded DKEY for continous drawing (authored by Dalai Felinto (dfelinto)).
Grease Pencil: Fix hardcoded DKEY for continous drawing
Fri, Jun 23, 10:46 AM

Yesterday

Dalai Felinto (dfelinto) edited P505 Masterwork From Distant Lands.
Thu, Jun 22, 7:19 PM
Dalai Felinto (dfelinto) committed rB5b2e596ce937: Eevee: Fix max range of lightprobes (authored by Dalai Felinto (dfelinto)).
Eevee: Fix max range of lightprobes
Thu, Jun 22, 6:37 PM
Dalai Felinto (dfelinto) edited P504 Masterwork From Distant Lands.
Thu, Jun 22, 6:35 PM
Dalai Felinto (dfelinto) assigned T51871: Eevee: Plane reflection probes artifacts to Clément Foucault (fclem).
Thu, Jun 22, 5:55 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T51871: Eevee: Plane reflection probes artifacts.
Thu, Jun 22, 5:54 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rBd9c5433144a0: Eevee: Interface and units (authored by Dalai Felinto (dfelinto)).
Eevee: Interface and units
Thu, Jun 22, 5:38 PM
Dalai Felinto (dfelinto) committed rB4cd9a3e3375e: Light Probes: interface changes, and renames (authored by Dalai Felinto (dfelinto)).
Light Probes: interface changes, and renames
Thu, Jun 22, 5:31 PM
Dalai Felinto (dfelinto) edited P503 Masterwork From Distant Lands.
Thu, Jun 22, 5:02 PM
Dalai Felinto (dfelinto) committed rB7773a8ad0482: Indicate to users when manual conversion of Eevee materials is needed (authored by Dalai Felinto (dfelinto)).
Indicate to users when manual conversion of Eevee materials is needed
Thu, Jun 22, 10:48 AM
Dalai Felinto (dfelinto) committed rBbe4b5551c7a4: Fix T51863: CompositorNodeSwitchView have the wrong rna API (authored by Dalai Felinto (dfelinto)).
Fix T51863: CompositorNodeSwitchView have the wrong rna API
Thu, Jun 22, 10:28 AM
Dalai Felinto (dfelinto) closed T51863: PYAPI: CompositorNodeSwitchView have the wrong api docs as "Resolved" by committing rBbe4b5551c7a4: Fix T51863: CompositorNodeSwitchView have the wrong rna API.
Thu, Jun 22, 10:28 AM · Python, Documentation, Compositing, BF Blender
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

Also @Clément Foucault (fclem) shouldn't we have this for all modes/engines? Instead of only Eevee?

Thu, Jun 22, 10:12 AM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

I'm not sure. Hopefully MSAA or TAA would be default for rendering, and not crappy FXAA. The performance impact of even the highest setting on Haswell intel GPU is so small...

Thu, Jun 22, 10:09 AM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

As for the settings, if we really need to expose them, maybe we could think of an enum with presets (low-medium-high).
We can even use DRW_state_is_image_render() as a test and use a higher quality if rendering. (you may need to re-merge 2.8 in for that).

Thu, Jun 22, 9:47 AM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

I finally managed to test this (thanks for using arcanist). I like the results. However I wonder:

Thu, Jun 22, 9:44 AM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

One question I have about this is the second clause of the BSD license in the FXAA shader. Is there someplace in the manual or whatever this can be placed?

Thu, Jun 22, 9:25 AM

Wed, Jun 21

Dalai Felinto (dfelinto) committed rB4ceb00670657: Merge remote-tracking branch 'origin/master' into blender2.8 (authored by Dalai Felinto (dfelinto)).
Merge remote-tracking branch 'origin/master' into blender2.8
Wed, Jun 21, 4:30 PM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

Just to clarify, when using arcanist we get:

  • Context for the patch, so we can look at the patched files and see the lines before/after
  • The exactly revision the patch was created against. This way when I do arc patch D2717 it always work flawlessly. Otherwise it tries to apply to the current branch as it is, and it often generates conflicts.
Wed, Jun 21, 2:10 PM
Dalai Felinto (dfelinto) abandoned D2718: Disable blenderplayer for buildbot in 2.8.

Can I automatically get an email at blender.studio whenever the 2.8 (or all) builbots fail then? That would be enough. Anyways, closing this for now.

Wed, Jun 21, 2:08 PM
Dalai Felinto (dfelinto) committed rB22466a5bdff7: Fix typo in builtbot config (authored by Dalai Felinto (dfelinto)).
Fix typo in builtbot config
Wed, Jun 21, 2:05 PM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

An important thing, please start using arcanist for your patch submission. It makes testing it way simpler. As it is the patch is not applying cleanly.

Wed, Jun 21, 12:40 PM
Dalai Felinto (dfelinto) created D2718: Disable blenderplayer for buildbot in 2.8.
Wed, Jun 21, 12:38 PM
Dalai Felinto (dfelinto) committed rB2ae172ec32da: Fix blenderplayer (tm) (authored by Dalai Felinto (dfelinto)).
Fix blenderplayer (tm)
Wed, Jun 21, 12:25 PM

Tue, Jun 20

Dalai Felinto (dfelinto) committed rB0ef7ccb4d753: Introduce functions/options to indicate the type of render (authored by Dalai Felinto (dfelinto)).
Introduce functions/options to indicate the type of render
Tue, Jun 20, 8:07 PM
Dalai Felinto (dfelinto) added a comment to D2717: eevee: add FXAA post-processing pass.

Some minor comments inline, I will test the patch later.

Tue, Jun 20, 7:28 PM
Dalai Felinto (dfelinto) committed rBc2f4308e6ba2: Fix blenderplayer build (tm) (authored by Dalai Felinto (dfelinto)).
Fix blenderplayer build (tm)
Tue, Jun 20, 3:52 PM
Dalai Felinto (dfelinto) committed rB63d71edfcabb: Fix collada build after gawain rename/refactor (authored by Dalai Felinto (dfelinto)).
Fix collada build after gawain rename/refactor
Tue, Jun 20, 3:44 PM

Mon, Jun 19

Dalai Felinto (dfelinto) assigned T51830: cyrillic script and string property maxlen bug. to Bastien Montagne (mont29).

Confirmed. And just to state the obvious (for developers), the same is valid for Japanese and probably any other unicode.

Mon, Jun 19, 3:31 PM · BF Blender
Dalai Felinto (dfelinto) added a comment to D2678: Gawain refactor.

Small inline changes I had to do for OpenColorIO building (rB701a76769d4acb2dfda14a8fe2ef18ebd805d91c).

Mon, Jun 19, 3:22 PM
Dalai Felinto (dfelinto) committed rB701a76769d4a: Fixup for gawan rename (authored by Dalai Felinto (dfelinto)).
Fixup for gawan rename
Mon, Jun 19, 3:19 PM
Dalai Felinto (dfelinto) accepted D2678: Gawain refactor.
Mon, Jun 19, 11:07 AM
Dalai Felinto (dfelinto) added a comment to D2678: Gawain refactor.

Overall I like the idea of adding consistence to the API. But I think we are shortening things more than we really need. See some inline comments.
That said I'm not passionate either way.

Mon, Jun 19, 10:47 AM

Fri, Jun 16

Dalai Felinto (dfelinto) committed rB946bc4d3c1da: Fix object selection doversion issue since Workspace (authored by Dalai Felinto (dfelinto)).
Fix object selection doversion issue since Workspace
Fri, Jun 16, 6:15 PM

Thu, Jun 15

Dalai Felinto (dfelinto) renamed T51821: Eevee: Switching World update issues from "Switching World update issues" to "Eevee: Switching World update issues".
Thu, Jun 15, 6:54 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T51821: Eevee: Switching World update issues.
Thu, Jun 15, 6:54 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB281a4540e238: Expose World ID panel for Eevee (authored by Dalai Felinto (dfelinto)).
Expose World ID panel for Eevee
Thu, Jun 15, 6:46 PM
Dalai Felinto (dfelinto) committed rBcd21236ea1d1: Fix duplication of scene, it was missing duplication of layer properties (authored by Dalai Felinto (dfelinto)).
Fix duplication of scene, it was missing duplication of layer properties
Thu, Jun 15, 6:37 PM
Dalai Felinto (dfelinto) edited projects for T51576: Blender crash when change to edit mode with Intel GPU, added: OpenGL / Gfx; removed BF Blender: 2.8.
Thu, Jun 15, 6:11 PM · OpenGL / Gfx
Dalai Felinto (dfelinto) added a comment to T51576: Blender crash when change to edit mode with Intel GPU.

Driver 4534 has problems.
Drivers 4590 and 4627 work.

Thu, Jun 15, 5:17 PM · OpenGL / Gfx
Dalai Felinto (dfelinto) merged T51788: blender-2.80 builds crash immediately upon TAB into T51576: Blender crash when change to edit mode with Intel GPU.
Thu, Jun 15, 5:04 PM · OpenGL / Gfx
Dalai Felinto (dfelinto) merged task T51788: blender-2.80 builds crash immediately upon TAB into T51576: Blender crash when change to edit mode with Intel GPU.
Thu, Jun 15, 5:04 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB60a36f202837: Eevee: Use PROP_NONE for probe grid resolution (authored by Dalai Felinto (dfelinto)).
Eevee: Use PROP_NONE for probe grid resolution
Thu, Jun 15, 3:03 PM
Dalai Felinto (dfelinto) committed rB32cd8ac71065: Layers: Scene copy should copy selection as well. (authored by Dalai Felinto (dfelinto)).
Layers: Scene copy should copy selection as well.
Thu, Jun 15, 1:47 PM
Dalai Felinto (dfelinto) closed T51433: Eevee and multi-view: Visual artifacts (blurness) as "Resolved".

Fixed on rB1a7099f3ecf52fa8a54c2ba3f652d5827ca9103c.

Thu, Jun 15, 12:29 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB1a7099f3ecf5: Fix T51463: Eevee motion blur not working (with AMD) (authored by Dalai Felinto (dfelinto)).
Fix T51463: Eevee motion blur not working (with AMD)
Thu, Jun 15, 11:33 AM
Dalai Felinto (dfelinto) closed T51463: Eevee motion blur not workig with core profile as "Resolved" by committing rB1a7099f3ecf5: Fix T51463: Eevee motion blur not working (with AMD).
Thu, Jun 15, 11:32 AM · BF Blender: 2.8
Dalai Felinto (dfelinto) moved T51813: Grid is opaque and different scale on macOS from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Thu, Jun 15, 11:11 AM · BF Blender: 2.8

Wed, Jun 14

Dalai Felinto (dfelinto) created T51806: Eevee Metallness/Specular nodes to become shader nodes, connected to output node.
Wed, Jun 14, 5:57 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) moved T51485: 2.8 branch crashes regardless of renderer when entering edit mode from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:04 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) moved T51576: Blender crash when change to edit mode with Intel GPU from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:03 PM · OpenGL / Gfx
Dalai Felinto (dfelinto) moved T51644: Crash upon Startup from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:03 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) moved T51721: Blender 2.80 won't open. from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:02 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) moved T51724: Blender 2.80 EEVEE, Cycles, Clay Black Wall Graphical Glitch from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:02 PM · BF Blender: 2.8, Cycles
Dalai Felinto (dfelinto) moved T51788: blender-2.80 builds crash immediately upon TAB from Backlog to OpenGL-Compatibility on the BF Blender: 2.8 board.
Wed, Jun 14, 5:02 PM · BF Blender: 2.8

Tue, Jun 13

Dalai Felinto (dfelinto) closed T51041: The specified texture is not displayed in the uiTemplatePreview as "Resolved".

Fixed since e791e01c0b0b58facf69eef11b4c46de869886d9

Tue, Jun 13, 5:24 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) closed T51098: Duplicate object doesn't transform and creates 2x users in 2.8x as "Resolved".

Resolved a few weeks/months ago.

Tue, Jun 13, 4:49 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB6ea6c516708a: Better Fix for T51777: Separating objects by selected vertices (authored by Dalai Felinto (dfelinto)).
Better Fix for T51777: Separating objects by selected vertices
Tue, Jun 13, 4:38 PM
Dalai Felinto (dfelinto) added a reverting commit for rB47b9d0d04030: Fix T51777: Separating objects by selected vertices in Eevee causes crash: rB6ea6c516708a: Better Fix for T51777: Separating objects by selected vertices.
Tue, Jun 13, 4:38 PM
Dalai Felinto (dfelinto) committed rB8d3e2af8775e: Grease Pencil: Fix problems linking object with Pallete (authored by Dalai Felinto (dfelinto)).
Grease Pencil: Fix problems linking object with Pallete
Tue, Jun 13, 4:01 PM
Dalai Felinto (dfelinto) committed rBe534fc8a878d: Silence tons of warnings (authored by Dalai Felinto (dfelinto)).
Silence tons of warnings
Tue, Jun 13, 12:58 PM
Dalai Felinto (dfelinto) assigned T51734: batch previews segfault on some materials to Sergey Sharybin (sergey).

Confirmed, crash log: P498

Tue, Jun 13, 12:28 PM · BF Blender
Dalai Felinto (dfelinto) edited P498 Masterwork From Distant Lands.
Tue, Jun 13, 12:28 PM
Dalai Felinto (dfelinto) assigned T50973: Directional blur node doesn't clamp value if using driver to Sergey Sharybin (sergey).
Tue, Jun 13, 12:02 PM · Compositing, BF Blender
Dalai Felinto (dfelinto) assigned T51794: Workspace: Crash on hair file when opening with no UI to Julian Eisel (Severin).
Tue, Jun 13, 11:43 AM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T51794: Workspace: Crash on hair file when opening with no UI.
Tue, Jun 13, 11:43 AM · BF Blender: 2.8
Dalai Felinto (dfelinto) created P496 (An Untitled Masterwork).
Tue, Jun 13, 11:35 AM

Mon, Jun 12

Dalai Felinto (dfelinto) committed rB47b9d0d04030: Fix T51777: Separating objects by selected vertices in Eevee causes crash (authored by Dalai Felinto (dfelinto)).
Fix T51777: Separating objects by selected vertices in Eevee causes crash
Mon, Jun 12, 6:37 PM
Dalai Felinto (dfelinto) closed T51777: Sparating objects by selected vertices in Eevee causes crash as "Resolved" by committing rB47b9d0d04030: Fix T51777: Separating objects by selected vertices in Eevee causes crash.
Mon, Jun 12, 6:37 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB193a1df8fa8d: Renaming: *_Iterator_begin/next > *_iterator_begin/next (authored by Dalai Felinto (dfelinto)).
Renaming: *_Iterator_begin/next > *_iterator_begin/next
Mon, Jun 12, 6:37 PM
Dalai Felinto (dfelinto) assigned T51782: Workspace: Cycles material preview crash to Julian Eisel (Severin).
Mon, Jun 12, 5:47 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T51782: Workspace: Cycles material preview crash.
Mon, Jun 12, 5:46 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created P495 (An Untitled Masterwork).
Mon, Jun 12, 5:46 PM
Dalai Felinto (dfelinto) added a comment to T50973: Directional blur node doesn't clamp value if using driver.

(for the records the original claim that clamping is the issue could be solved with P494, but RNA is already clamping the values before we get to the compositor, so this patch is uneeded)

Mon, Jun 12, 5:01 PM · Compositing, BF Blender
Dalai Felinto (dfelinto) edited P494 Masterwork From Distant Lands.
Mon, Jun 12, 5:00 PM
Dalai Felinto (dfelinto) added a comment to T50973: Directional blur node doesn't clamp value if using driver.

This is not related to the directional blur node. Here is an even simpler file using another node:


Note that the compositor node is not even being used.

Mon, Jun 12, 4:57 PM · Compositing, BF Blender
Dalai Felinto (dfelinto) added a comment to T51780: If an object is in two collections and I do a full copy of scene things go bad.

The asan crash on exit was fixed on rB109447d008b4719f24a807560c6cb9a63fc8f51f.

Mon, Jun 12, 4:20 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB109447d008b4: Draw Manager: Fix memory issues when copying scene (authored by Dalai Felinto (dfelinto)).
Draw Manager: Fix memory issues when copying scene
Mon, Jun 12, 4:17 PM
Dalai Felinto (dfelinto) committed rB8ca497b9117c: Depsgraph: Traversing should be consistent for nodes and relationship (authored by Dalai Felinto (dfelinto)).
Depsgraph: Traversing should be consistent for nodes and relationship
Mon, Jun 12, 4:10 PM
Dalai Felinto (dfelinto) closed T51780: If an object is in two collections and I do a full copy of scene things go bad as "Resolved" by committing rB8ca497b9117c: Depsgraph: Traversing should be consistent for nodes and relationship.
Mon, Jun 12, 4:10 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) triaged T50973: Directional blur node doesn't clamp value if using driver as "Confirmed" priority.

Confirmed. Note to other testers on how to test it:

  • Load file, enable auto-run scripts
  • Switch viewport to rendered
  • The viewport has nothing rendered.
Mon, Jun 12, 4:01 PM · Compositing, BF Blender
Dalai Felinto (dfelinto) added a comment to T51780: If an object is in two collections and I do a full copy of scene things go bad.

Another way of testing the depsgraph warnings, which may (or may not) be related:

Mon, Jun 12, 3:33 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) updated the language for P493 Masterwork From Distant Lands from autodetect to python.
Mon, Jun 12, 3:31 PM
Dalai Felinto (dfelinto) edited P493 Masterwork From Distant Lands.
Mon, Jun 12, 3:29 PM
Dalai Felinto (dfelinto) added a comment to T51780: If an object is in two collections and I do a full copy of scene things go bad.

To reproduce it without the file:

./blender -b --python-expr "import bpy;bpy.context.scene.master_collection.collections.new('My Collection').objects.link(bpy.data.objects['Cube']);bpy.ops.scene.new(type='FULL_COPY');"
Mon, Jun 12, 3:01 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) claimed T51780: If an object is in two collections and I do a full copy of scene things go bad.
Mon, Jun 12, 2:49 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T51780: If an object is in two collections and I do a full copy of scene things go bad.
Mon, Jun 12, 2:49 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) edited P492 Masterwork From Distant Lands.
Mon, Jun 12, 2:45 PM
Dalai Felinto (dfelinto) edited P491 Masterwork From Distant Lands.
Mon, Jun 12, 2:45 PM
Dalai Felinto (dfelinto) created P490 (An Untitled Masterwork).
Mon, Jun 12, 2:43 PM
Dalai Felinto (dfelinto) claimed T51777: Sparating objects by selected vertices in Eevee causes crash.
Mon, Jun 12, 12:44 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) closed T51779: BMESH_ASSERT when go to edit mode as "Invalid".

Mesh is corrupt, closing the report.

Mon, Jun 12, 12:31 PM · BF Blender
Dalai Felinto (dfelinto) updated subscribers of T51779: BMESH_ASSERT when go to edit mode.

Full disclosure: This file may just be corrupt. Maybe it happened when applying modifiers, maybe at some other point. Unless there is anything we can do about those, I suggest we just close this bug.
@Bastien Montagne (mont29) @Campbell Barton (campbellbarton) ?

Mon, Jun 12, 12:21 PM · BF Blender
Dalai Felinto (dfelinto) edited the description of T51779: BMESH_ASSERT when go to edit mode.
Mon, Jun 12, 12:15 PM · BF Blender
Dalai Felinto (dfelinto) created T51779: BMESH_ASSERT when go to edit mode.
Mon, Jun 12, 12:04 PM · BF Blender
Dalai Felinto (dfelinto) created P489 (An Untitled Masterwork).
Mon, Jun 12, 11:55 AM

Sun, Jun 11

Dalai Felinto (dfelinto) added a comment to T51219: Gawain API general consistency RFC.

@Campbell Barton (campbellbarton) are all the critical topics addressed/committed already?

Sun, Jun 11, 12:26 PM · BF Blender: 2.8

Fri, Jun 9

Dalai Felinto (dfelinto) committed rBdadb99074c54: Fix crash when using sculpt dynamic smooth (authored by Dalai Felinto (dfelinto)).
Fix crash when using sculpt dynamic smooth
Fri, Jun 9, 5:33 PM