- User Since
- Jun 2 2006, 5:16 AM (636 w, 5 d)
Address issues raised on review.
Final fix for object trackers and regular trackers (they were working for the initial frame only)
Final patch, original patch description to be updated.
Mon, Aug 13
I just ran into this too.
Wed, Aug 1
Wed, Jul 18
Jul 16 2018
Jun 29 2018
There is a chance that this never worked in 2.8. But there is also a chance this was crashed with the recent OpenGL and BLF refactors.
To be honest I can barely bisect this since the moment I roll a few commits back, I get GWN_vao_alloc(): Assertion active_ctx' failed.` or worse.
And for the records, you can reproduce the error with: ./blender -a -f 24 1.0 -s 1 -e 10 -j 1 /tmp/0001.png for a rendered sequence (it crashes once you scrab).
Note, the crash is because we are trying to divide by zero.
in blf_glyph.c i is zero:
i = (int)((gc->p2_width - (gc->pad * 2)) / gc->glyph_width_max);
Recalculate Normals is a nice example of things that gotta go. I believe we are better off having Ctrl+N to open a new file regardless of the editor/mode.
Jun 28 2018
After a clean build the problem no longer happens.
Jun 27 2018
I can reproduce in the reported commit, but indeed it seems fine now. Closing.
I can't reproduce the crash with latest Blender. Please re-build and re-test.
For the records:
- It doesn't happen with 2.79a with or without --enable-new-despgraph.
- It is reproducible very reliably in 2.8.
Jun 26 2018
I think the new thing billreynish is bringing here is that colors (and thickness) is an individual property of the strokes, not something that is shared among all the strokes in a layer.
That allows for what @Joshua Leung (aligorith) was proposing, which was to have in the same document different revisions of notes (note v1, note v2, ..., note final-final).
FYI when adding a new material slot, inside BKE_material_resize_object() we call:
Issue introduced on: 40e1e8ebed4
Assigning to self, I will bisect it to see what is causing this.
Note: If I change the visualization to Look Dev, it still crashes, although elsewhere:
I second what @Campbell Barton (campbellbarton) said. And to be fair I tried with decorators for checkboxes and it doesn't look bad, even though the decorator is far from the checkbox:
Jun 25 2018
Jun 22 2018
I was gathering some feedback in the studio and it seems that clicking individual "icons" in the outliner (for in-line icons, not level 0 icons) is not that useful really.
So I propose after this patch is greenlit to make them not-clickable as well.
For reference this is the intended original design: