Dalai Felinto (dfelinto)
Architect and Developer

Projects (18)

User Details

User Since
Jun 2 2006, 5:16 AM (594 w, 3 d)

Author of Game Development with Blender [ more info ]

Recent Activity

Today

Dalai Felinto (dfelinto) added a comment to D2882: Initial Tool System.

I gave it a short try today. It's definitively interesting, nice work. Questions:

  1. Is there already a way to go back to have no active tool?
  2. Lamp Place:

You are using this to enable the widget instead of directly mapping RMB to lamp placement. I then wonder if we shouldn't we see the widget of all the select lamps, not only the active one.

  1. Transformation widget:

It looks like there is some redundancy with the transformation widgets and the transformation tools. Do we really want to be able to directly transform without the widgets? (short of using shortcuts)

Mon, Oct 23, 3:52 PM

Fri, Oct 20

Dalai Felinto (dfelinto) created D2892: Groups and collections.
Fri, Oct 20, 11:06 PM
Dalai Felinto (dfelinto) committed rBa8553c9fa248: Silence warning on subsurf modifier (authored by Dalai Felinto (dfelinto)).
Silence warning on subsurf modifier
Fri, Oct 20, 10:17 PM
Dalai Felinto (dfelinto) accepted D2887: Multiview OpenEXR save/load refactor and fixes..
Combined.Combined was introduced in 2.75 along with the multiview changes

Oh ouch. You are right then, no changes to non-multiview EXR should have been introduced, my bad.

Fri, Oct 20, 9:26 PM
Dalai Felinto (dfelinto) added a comment to D2887: Multiview OpenEXR save/load refactor and fixes..

Single-layer is perfect now. For multi-layer you introduced a few changes. They may be by design, but I would like to hear from you on these, so they would at least be mentioned in the commit log:

Fri, Oct 20, 7:25 PM
Dalai Felinto (dfelinto) triaged T53115: Memleak with instanced groups and Cycles as Confirmed priority.

Although this is noticed with Cycles there is a big chance that this has nothing to do with Cycles.

Fri, Oct 20, 5:03 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) renamed T53115: Memleak with instanced groups and Cycles from Memleak when making proxies and using Cycles to Memleak with instanced groups and Cycles.
Fri, Oct 20, 5:02 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T53115: Memleak with instanced groups and Cycles.
Fri, Oct 20, 4:58 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) added a comment to D2887: Multiview OpenEXR save/load refactor and fixes..

"/* if rendered only one view, we treat as a a non-view render */"

Fri, Oct 20, 3:45 PM
Dalai Felinto (dfelinto) requested changes to D2887: Multiview OpenEXR save/load refactor and fixes..

You are introducing a regression for multi-layer Multi-View files that are rendering only one eye.
For example:

Fri, Oct 20, 2:52 PM

Thu, Oct 19

Dalai Felinto (dfelinto) added a comment to T53108: Proxy creation error.

Note to self: I'm tagging the scene before adding the object to the collections. I may need to split the object_add_common in a pre and post routines. (I'll try tomorrow).

Thu, Oct 19, 11:57 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) added a comment to T53108: Proxy creation error.

Ah right. It was one of my tests files for my work on collection and groups, ... so I didn't realize the issue was that. That said armature proxies are broken until I force depsgraph refresh (e.g., save and re-open the file, or add a new object). But it's a separated issue since there is no error printing in this case. It was even more broken before fc10484f7c55 - not even saving/reopening fixes it back then.

Thu, Oct 19, 11:35 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) assigned T53108: Proxy creation error to Sergey Sharybin (sergey).

I have no idea if this problem is depsgraph related or ID refactor related. So although I assigned it to @Sergey Sharybin (sergey) it may be related to @Bastien Montagne (mont29) too.

Thu, Oct 19, 10:23 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T53108: Proxy creation error.
Thu, Oct 19, 10:21 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) edited P543 Masterwork From Distant Lands.
Thu, Oct 19, 10:21 PM
Dalai Felinto (dfelinto) committed rBfc10484f7c55: Fix/properly implement: "make group proxy" (authored by Dalai Felinto (dfelinto)).
Fix/properly implement: "make group proxy"
Thu, Oct 19, 10:04 PM
Dalai Felinto (dfelinto) added a comment to D2887: Multiview OpenEXR save/load refactor and fixes..

Your file breaks my 2.79 release entirely :)
I will test your patch first thing tomorrow morning just to double-check. Particularly for non-multiview cases, to make sure things are still 100%.

Thu, Oct 19, 9:33 PM
Dalai Felinto (dfelinto) added a comment to D2887: Multiview OpenEXR save/load refactor and fixes..

Loading multiview images with a single view from other software failed.

Thu, Oct 19, 8:38 PM

Wed, Oct 18

Dalai Felinto (dfelinto) committed rB0bcb61b2fe94: Follow up to engine in workspaces, using clay as default (authored by Dalai Felinto (dfelinto)).
Follow up to engine in workspaces, using clay as default
Wed, Oct 18, 12:35 AM
Dalai Felinto (dfelinto) committed rB5aff67fb5ee5: Fix crash when Making Duplicates Real for groups (authored by Dalai Felinto (dfelinto)).
Fix crash when Making Duplicates Real for groups
Wed, Oct 18, 12:14 AM

Tue, Oct 17

Dalai Felinto (dfelinto) committed rB028a558116d0: Layers: Fix selected lamp and dupli count for info stats (authored by Dalai Felinto (dfelinto)).
Layers: Fix selected lamp and dupli count for info stats
Tue, Oct 17, 11:56 PM
Dalai Felinto (dfelinto) closed T53096: Object Outlines are broken when zooming inside of objects as Invalid.

This is by design, thus not a bug.

Tue, Oct 17, 7:13 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) added a comment to T53095: Black cube on start and no material updates.

@Aleksander Petkov (AKIRA_SAN) you need to run blender from the cmd, and pipe the output:
blender.exe --debug 1>out.txt 2>err.txt

Tue, Oct 17, 7:12 PM · BF Blender: 2.8

Mon, Oct 16

Dalai Felinto (dfelinto) committed rB314542ffd4c8: Fix for objects trailing in viewport when using BI in scene+Eevee in workspace (authored by Dalai Felinto (dfelinto)).
Fix for objects trailing in viewport when using BI in scene+Eevee in workspace
Mon, Oct 16, 10:43 PM
Dalai Felinto (dfelinto) committed rB73ca54283cb5: Fixup for recent workspace changes: Python files (authored by Dalai Felinto (dfelinto)).
Fixup for recent workspace changes: Python files
Mon, Oct 16, 10:00 PM
Dalai Felinto (dfelinto) committed rBd3e7a737de01: Silence warning (authored by Dalai Felinto (dfelinto)).
Silence warning
Mon, Oct 16, 9:54 PM
Dalai Felinto (dfelinto) committed rBeae622d2ddf5: Workspace: Call BKE_viewrender_free from the right place (authored by Dalai Felinto (dfelinto)).
Workspace: Call BKE_viewrender_free from the right place
Mon, Oct 16, 9:54 PM
Dalai Felinto (dfelinto) committed rBe4f2b2be26ad: Workspace: Move engines to workspace and Properties Editor cleanup (authored by Dalai Felinto (dfelinto)).
Workspace: Move engines to workspace and Properties Editor cleanup
Mon, Oct 16, 9:31 PM
Dalai Felinto (dfelinto) closed D2842: Bring engines to workspace and UI sanitize by committing rBe4f2b2be26ad: Workspace: Move engines to workspace and Properties Editor cleanup.
Mon, Oct 16, 9:31 PM
Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.

Final touchups - so I can review it online

Mon, Oct 16, 9:09 PM
Dalai Felinto (dfelinto) committed rBe8962f90de42: Fix compatibility flag for nodetree (authored by Dalai Felinto (dfelinto)).
Fix compatibility flag for nodetree
Mon, Oct 16, 8:50 PM
Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.
  • From review: No longer need to change mainb type
  • From review: dont use pointer to ViewRender in DNA_*
  • From review: Use "e" prefix for enums
Mon, Oct 16, 4:32 PM
Dalai Felinto (dfelinto) added a comment to T52886: UI Text messed up on 2nd display/video card Mac.

@Arto Kitula (akitula) can you see if P486 "fixes" the issue for you?

Mon, Oct 16, 3:15 PM · Platform: Mac OS X, BF Blender
Dalai Felinto (dfelinto) added a comment to T53078: Object moving handles misplaced in animation.

For the records, we will at some point in the near future have viewports (or at the very least workspaces or windows) with different frames among themselves. So although a viewport may be animating, the others won't be animating necessarily. The visibility of manipulators should respect that (i.e., hide only for the viewports that are animated).

Mon, Oct 16, 2:55 PM · BF Blender: 2.8, Animation

Sat, Oct 14

Dalai Felinto (dfelinto) added a comment to D2842: Bring engines to workspace and UI sanitize.

@Campbell Barton (campbellbarton) There is one thing I need to test further, but I updated the patch with yours and @Julian Eisel (Severin)'s suggestion. It became a much bigger patch, but we now have a "ViewRender" struct. Feel free to take another look at it.

Sat, Oct 14, 2:15 AM
Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.
  • From review: handle rna_workspace_engine_set differently
  • Frow review: Rename engine_name > engine_id
  • From review: Rename BKE_render_* to BKE_viewrender_*
  • From review: Massive changes: own struct for ViewRender data (engine, ...)
Sat, Oct 14, 2:10 AM
Dalai Felinto (dfelinto) edited P539 Masterwork From Distant Lands.
Sat, Oct 14, 1:43 AM

Wed, Oct 11

Dalai Felinto (dfelinto) updated the summary of D2878: Layer evaluation --set-advanced-collection-evaluation.
Wed, Oct 11, 9:36 PM
Dalai Felinto (dfelinto) updated subscribers of D2878: Layer evaluation --set-advanced-collection-evaluation.

Guys, this is the patch with both options.

Wed, Oct 11, 9:23 PM
Dalai Felinto (dfelinto) created D2878: Layer evaluation --set-advanced-collection-evaluation.
Wed, Oct 11, 9:22 PM
Dalai Felinto (dfelinto) updated the task description for T53047: Tool System Proposal.
Wed, Oct 11, 1:02 PM · User Interface, BF Blender: 2.8

Tue, Oct 10

Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.
  • Fix doversion for char engine[]
  • From review: Use workspace engine only for buttons window preview
Tue, Oct 10, 12:39 AM

Mon, Oct 9

Dalai Felinto (dfelinto) committed rBfdeb125c7a8c: Fix T53014: Cycles material preview not working (authored by Dalai Felinto (dfelinto)).
Fix T53014: Cycles material preview not working
Mon, Oct 9, 4:44 PM
Dalai Felinto (dfelinto) closed T53014: Cycles material preview no light as Resolved by committing rBfdeb125c7a8c: Fix T53014: Cycles material preview not working.
Mon, Oct 9, 4:44 PM · Cycles, BF Blender: 2.8
Dalai Felinto (dfelinto) assigned T53033: Crash in sculpt mode since work on 2D Falloff to Campbell Barton (campbellbarton).

Confirmed. Crash is:

Mon, Oct 9, 3:58 PM · Sculpting and Painting, BF Blender
Dalai Felinto (dfelinto) created P538 (An Untitled Masterwork).
Mon, Oct 9, 3:57 PM

Sat, Oct 7

Dalai Felinto (dfelinto) updated subscribers of T53014: Cycles material preview no light.

Note to self (or @Sergey Sharybin (sergey) if he feels like):
Take a look at render_preview.c::preview_prepare_scene and see if depsgraph is flushing the visibility / disability properly.

Sat, Oct 7, 12:02 AM · Cycles, BF Blender: 2.8

Fri, Oct 6

Dalai Felinto (dfelinto) committed rB8a1d787b8982: Initial fix for T53014: Cycles material preview no light (authored by Dalai Felinto (dfelinto)).
Initial fix for T53014: Cycles material preview no light
Fri, Oct 6, 11:56 PM
Dalai Felinto (dfelinto) claimed T53014: Cycles material preview no light.
Fri, Oct 6, 7:25 PM · Cycles, BF Blender: 2.8
Dalai Felinto (dfelinto) created T53014: Cycles material preview no light.
Fri, Oct 6, 7:25 PM · Cycles, BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB321f773ca659: Merge remote-tracking branch 'origin/master' into blender2.8 (authored by Dalai Felinto (dfelinto)).
Merge remote-tracking branch 'origin/master' into blender2.8
Fri, Oct 6, 6:11 PM
Dalai Felinto (dfelinto) committed rB5ec270c20c83: Merge remote-tracking branch 'origin/master' into blender2.8 (authored by Dalai Felinto (dfelinto)).
Merge remote-tracking branch 'origin/master' into blender2.8
Fri, Oct 6, 5:41 PM
Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.
  • From review: split SETLOOPER usecases
Fri, Oct 6, 3:40 PM
Dalai Felinto (dfelinto) edited P537 Masterwork From Distant Lands.
Fri, Oct 6, 2:49 PM
Dalai Felinto (dfelinto) abandoned D2868: Testing arcanist.
Fri, Oct 6, 2:14 AM
Dalai Felinto (dfelinto) updated the diff for D2868: Testing arcanist.
  • Testing arcanist 2
Fri, Oct 6, 2:13 AM
Dalai Felinto (dfelinto) created D2868: Testing arcanist.
Fri, Oct 6, 2:13 AM
Dalai Felinto (dfelinto) edited P536 Masterwork From Distant Lands.
Fri, Oct 6, 1:51 AM

Thu, Oct 5

Dalai Felinto (dfelinto) added a comment to T50845: Top Bar Design.
The user can simply create a clone of the current workspace if he/she wants an alternative layout.
Thu, Oct 5, 4:02 PM · User Interface, BF Blender: 2.8

Wed, Oct 4

Dalai Felinto (dfelinto) lowered the priority of T52991: Again 2.8 crash by segmentation fault under Ubuntu from Confirmed to Incomplete.

And also, @Enrico Valenza (env) / @Joshua Leung (aligorith) if you run with --debug --debug-gpu you will see the exactly shader error the compiler error line is referring to (spoiler alert, shares are > 5k lines)

Wed, Oct 4, 4:56 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) added a comment to T52991: Again 2.8 crash by segmentation fault under Ubuntu.

@Joshua Leung (aligorith) could you bisect it? Clement is on his own hardware and likely is not even running into this.

Wed, Oct 4, 4:53 PM · BF Blender: 2.8

Thu, Sep 28

Dalai Felinto (dfelinto) updated the diff for D2842: Bring engines to workspace and UI sanitize.
  • Cleanup
  • From review: use eval_context to store engine instead of workspace
  • From review: use RenderEngineType instead of const char *engine_name
Thu, Sep 28, 5:57 PM

Wed, Sep 27

Dalai Felinto (dfelinto) added a comment to T51467: Eevee: Shader recompilation issue.

Confirmed the really low times linking times due to branching. I even added a new --debug-gpu-shaders that for now dumps the compiled shaders in the Blender temp session folder.

Wed, Sep 27, 6:26 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB16edfc516e97: --debug-gpu-shader: Dump GLSL shaders to disk (authored by Dalai Felinto (dfelinto)).
--debug-gpu-shader: Dump GLSL shaders to disk
Wed, Sep 27, 6:05 PM

Tue, Sep 26

Dalai Felinto (dfelinto) awarded rB30f9cd710b3a: GPUFramebuffer: Enable multisample when binding a Multisample FBO a Love token.
Tue, Sep 26, 2:31 PM

Sep 22 2017

Dalai Felinto (dfelinto) added a comment to D2852: Build Info: Splash screen color change.

This is how the splashscreen looks:

Sep 22 2017, 5:12 PM
Dalai Felinto (dfelinto) created D2852: Build Info: Splash screen color change.
Sep 22 2017, 5:11 PM

Sep 21 2017

Dalai Felinto (dfelinto) committed rB6294ca8b7e9b: Merge remote-tracking branch 'origin/blender2.8' into experimental-build (authored by Dalai Felinto (dfelinto)).
Merge remote-tracking branch 'origin/blender2.8' into experimental-build
Sep 21 2017, 7:37 PM
Dalai Felinto (dfelinto) committed rB70bbccb478be: Revert "Test fix for eevee textures" (authored by Dalai Felinto (dfelinto)).
Revert "Test fix for eevee textures"
Sep 21 2017, 7:37 PM
Dalai Felinto (dfelinto) added a reverting commit for rBff1cdddf704a: Test fix for eevee textures: rB70bbccb478be: Revert "Test fix for eevee textures".
Sep 21 2017, 7:37 PM
Dalai Felinto (dfelinto) committed rBff1cdddf704a: Test fix for eevee textures (authored by Dalai Felinto (dfelinto)).
Test fix for eevee textures
Sep 21 2017, 7:37 PM
Dalai Felinto (dfelinto) created T52866: Eevee: Texture and colorramp issues.
Sep 21 2017, 7:26 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rB803c757c2b64: Fix T52855: Eevee: viewport artifacts (authored by Dalai Felinto (dfelinto)).
Fix T52855: Eevee: viewport artifacts
Sep 21 2017, 5:47 PM
Dalai Felinto (dfelinto) closed T52855: Eevee: viewport artifacts as Resolved by committing rB803c757c2b64: Fix T52855: Eevee: viewport artifacts.
Sep 21 2017, 5:46 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) committed rBa99c64b12fbe: Eevee: Fix wrong MEM_callocN allocation size (authored by Dalai Felinto (dfelinto)).
Eevee: Fix wrong MEM_callocN allocation size
Sep 21 2017, 3:53 PM
Dalai Felinto (dfelinto) added a comment to D2851: Collection enable/disable: use camera visibility as behaviour.

@Brecht Van Lommel (brecht) you helped with the patch yesterday (D2849) yet you didn't say your opinion on that. What do you think?

Sep 21 2017, 3:12 PM
Dalai Felinto (dfelinto) added a comment to D2851: Collection enable/disable: use camera visibility as behaviour.

Just to be clear, the concerns raised by @Sergey Sharybin (sergey) are related to having an object used for boolean casting shadows even if you turn it invible.
Same goes for groups or particles, where you often wants to hide the original "group" objects entirely.

Sep 21 2017, 3:10 PM
Dalai Felinto (dfelinto) created D2851: Collection enable/disable: use camera visibility as behaviour.
Sep 21 2017, 3:06 PM
Dalai Felinto (dfelinto) added a comment to D2849: (1) Depsgraph and collection enable/visibility:.

For the records, I committed this without the changes @Sergey Sharybin (sergey) was raising concerns about. I'll open a new patch to discuss this.

Sep 21 2017, 2:47 PM
Dalai Felinto (dfelinto) committed rB9ad2c0b6154b: Depsgraph and collection enable/visibility (authored by Dalai Felinto (dfelinto)).
Depsgraph and collection enable/visibility
Sep 21 2017, 2:46 PM
Dalai Felinto (dfelinto) closed D2849: (1) Depsgraph and collection enable/visibility: by committing rB9ad2c0b6154b: Depsgraph and collection enable/visibility.
Sep 21 2017, 2:46 PM
Dalai Felinto (dfelinto) updated subscribers of D2849: (1) Depsgraph and collection enable/visibility:.
Sep 21 2017, 11:08 AM
Dalai Felinto (dfelinto) added a comment to D2849: (1) Depsgraph and collection enable/visibility:.

Guess it's more matter of question whether object visibility affects on "visibility for camera" or "visibility for everything". This patch switched from latter to former one, which could work but is a bit weird. Means, making objects invisible wouldn't really speed up your viewport -- shadow buffers will still be recalculated.

Sep 21 2017, 10:54 AM
Dalai Felinto (dfelinto) updated the diff for D2849: (1) Depsgraph and collection enable/visibility:.
  • Rename: hidden > is_visible
  • From review: loop cleanup
  • From review: BKE_object_is_visible() util
Sep 21 2017, 10:47 AM

Sep 20 2017

Dalai Felinto (dfelinto) assigned T52855: Eevee: viewport artifacts to Clément Foucault (fclem).

@Clément Foucault (fclem) I will be surprised if you don't get this problem in your Intel as well.

Sep 20 2017, 7:04 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T52855: Eevee: viewport artifacts.
Sep 20 2017, 7:03 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created D2849: (1) Depsgraph and collection enable/visibility:.
Sep 20 2017, 6:47 PM
Dalai Felinto (dfelinto) raised the priority of T52802: Denoise artifacts with Direct Glossy from Normal to Confirmed.
Sep 20 2017, 3:55 PM · Cycles, BF Blender
Dalai Felinto (dfelinto) committed rBf2db6cefa086: Layer collection enable flag (authored by Dalai Felinto (dfelinto)).
Layer collection enable flag
Sep 20 2017, 2:23 PM
Dalai Felinto (dfelinto) closed D2848: Layer collection enable flag by committing rBf2db6cefa086: Layer collection enable flag.
Sep 20 2017, 2:23 PM
Dalai Felinto (dfelinto) added inline comments to D2848: Layer collection enable flag.
Sep 20 2017, 12:54 PM
Dalai Felinto (dfelinto) added a comment to D2848: Layer collection enable flag.

@Campbell Barton (campbellbarton) the slow part was coming from getting the scene layer from collection, and then getting collection id for scene layer. This was running for every collection.
It's not necessarily slow, there is only too many collections a user will have. But it's running as part of the UI code, and I think it doesn't justify.

Sep 20 2017, 11:01 AM
Dalai Felinto (dfelinto) updated the diff for D2848: Layer collection enable flag.
  • Do not use operator in outliner (for now)
  • Change icon (use checkbox)
Sep 20 2017, 10:56 AM

Sep 19 2017

Dalai Felinto (dfelinto) updated the diff for D2848: Layer collection enable flag.
  • Another approach, passing collection index to operator
Sep 19 2017, 7:10 PM
Dalai Felinto (dfelinto) added a comment to D2848: Layer collection enable flag.

@Campbell Barton (campbellbarton) I need your help here.

Sep 19 2017, 6:45 PM
Dalai Felinto (dfelinto) closed T52829: Eevee: Shadows not updated when moving lamp as Resolved.

Fantastic, thanks @Sergey Sharybin (sergey). It's fixed.

Sep 19 2017, 6:44 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) edited P532 Masterwork From Distant Lands.
Sep 19 2017, 6:40 PM
Dalai Felinto (dfelinto) updated the diff for D2848: Layer collection enable flag.
  • From review: Python API changes
  • From review: collection toggle operator
Sep 19 2017, 6:40 PM
Dalai Felinto (dfelinto) assigned T52829: Eevee: Shadows not updated when moving lamp to Clément Foucault (fclem).
Sep 19 2017, 3:32 PM · BF Blender: 2.8
Dalai Felinto (dfelinto) created T52829: Eevee: Shadows not updated when moving lamp.
Sep 19 2017, 3:32 PM · BF Blender: 2.8