Page MenuHome

Edward O'Callaghan (funfunctor)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2016, 8:38 AM (160 w, 22 h)

Recent Activity

Nov 8 2016

Edward O'Callaghan (funfunctor) added a comment to D2342: Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

This is not about performance in this case, it is about covering such extreme cases (as forced software fallback) with something which works when Automatic option is used.

Nov 8 2016, 1:24 PM
Edward O'Callaghan (funfunctor) added a comment to D2342: Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

Mesa is not necessarily supporting hardware acceleration and your change forces it to be considered a hardware accelerated. Can imagine it'll cause problems with blender-softwaregl at least, which is the way we troubleshoot OpenGL things. it might also cause issues with other hardware/driver configurations.

Nov 8 2016, 12:16 PM
Edward O'Callaghan (funfunctor) added a comment to T49945: Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

Just curious, where do you expect triple buffer _not_ to work? Apple's OpenGL implementation I suppose?

Nov 8 2016, 11:36 AM · BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2342: Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

This doesn't seem to be a correct fix. It might fix one of your particular cases but it's logically incorrect and can cause breakage somewhere else.

Nov 8 2016, 11:33 AM

Nov 7 2016

Edward O'Callaghan (funfunctor) added a comment to T49945: Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

Proposed fix in https://developer.blender.org/D2342

Nov 7 2016, 2:49 AM · BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2342: Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

The intent here is to ensure within the function,

Nov 7 2016, 2:48 AM
Edward O'Callaghan (funfunctor) retitled D2342: Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic from to Fix for T49945 - Linux AMD drivers UI glitches when Window Draw Method is set to automatic.
Nov 7 2016, 2:44 AM

Nov 5 2016

Edward O'Callaghan (funfunctor) added a comment to T49945: Linux AMD drivers UI glitches when Window Draw Method is set to automatic.

This does not sound like a blender issue but rather a GPU driver issue.

Nov 5 2016, 3:23 PM · BF Blender

Sep 5 2016

Edward O'Callaghan (funfunctor) added a comment to D2188: Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles.

Ok, I've fixed a couple of those cases in rBe76e8fcdcc53.

Sep 5 2016, 2:08 AM

Sep 3 2016

Edward O'Callaghan (funfunctor) added a comment to D2188: Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles.

D2171 is also coupled with that work.

Sep 3 2016, 3:37 AM
Edward O'Callaghan (funfunctor) added a comment to D2188: Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles.

We don't intentionally use doubles in the kernel. Rather than enabling this extension, we probably just need to change a few constants or functions to use the f postfix.

Sep 3 2016, 3:35 AM

Sep 2 2016

Edward O'Callaghan (funfunctor) retitled D2188: Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles from to Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles.
Sep 2 2016, 2:13 PM

Aug 25 2016

Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

There is no resistance. We just need to know the support level and what users might/should expect from the changes. Even if the option is hidden behind environment variable check users will try using newly added Clover and if they encounter something they will report issue to us, so it is we who would need to deal with all the incoming frustration. Now, if we have a clear commit log or wiki page or whatever where we explicitly state support level that would (a) help us communicate this to users (b) reduce frustration level of Blender users.

Aug 25 2016, 10:34 AM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

What would be ideal is a validation suite if you would like to have a check list style is/is-not supported report like we do with piglit for example in Mesa for GL support.

We have some coverage with ctest, but that currently only works for CPU. We can try extending that to do GPU rendering as well. That would give some ballpark figures, but will also cause some false-positive failures because SSS/Volume is not supported in split kernel yet.

Aug 25 2016, 2:12 AM · Cycles, BF Blender

Aug 24 2016

Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

@Martijn Berger (juicyfruit), for OpenCL we use whitelist and currently it is only Apple and AMD Accelerated Parallel Processing being displayed by default, so there is no real need to hide something behind Experimental option. But it is still important to communicate limitations and expectations from the change. That's the only thing.
P.S. Only thing which will concern me a lot is if every simple file (like default cube scene) fails to render.

Aug 24 2016, 5:09 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

Understood totally, problem is a bit of a chicken and egg one though. My take would be to add something in the release notes..

Or hide this behind the experimental flag or some environment variable. There are many possibilities. I do not really believe the chicken egg thing here. While blender might important it is no where near crucial to making clover a good compliment OpenCl implementation

Aug 24 2016, 4:57 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

I think this discussion boils down to the question:
Do we want to add support for a currently non working ( from a user perspective ) opencl implementation ?
I think @Sergey Sharybin (sergey) seems to trend towards the answer is that we should add support for implementation that actually work.
I would tend to agree, while I love open source and would like cycles to run on all opencl implementations ever created we are trying to make a tool for users to make great art. I think adding support for implementation that *currently* do not yield usable pictures for our users needs to be behind some kind of flag / toggle so not to confuse them and or raise expectations.

Aug 24 2016, 4:50 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

I'm not talking about comparing speed, i'm talking about getting clear picture of what is supported and what is not supported.

Aug 24 2016, 4:49 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

When we add functionality to Blender, we need to give clear indication to users what they can/should expect from it and how/if they can benefit from it.
Here you can at least provide information like:

  • Which benchmark files work correctly
Aug 24 2016, 4:09 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) added a comment to D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

Several questions:

  • What are the requirements for the Mesa version?
Aug 24 2016, 12:47 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) updated the diff for D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.

Use 'KERNEL_ADV_SHADING' instead of explicitly stating each define.

Aug 24 2016, 12:33 PM · Cycles, BF Blender
Edward O'Callaghan (funfunctor) retitled D2172: Consolidate the various split CL kernel feature defines within the AMD platform from to Consolidate the various split CL kernel feature defines within the AMD platform.
Aug 24 2016, 12:26 PM
Edward O'Callaghan (funfunctor) retitled D2171: Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator from to Handle Mesa3D's OpenCL implementation (Clover) in the platform enumerator.
Aug 24 2016, 2:24 AM · Cycles, BF Blender

Aug 23 2016

Edward O'Callaghan (funfunctor) added a comment to T49144: src/clew.c: Fix dlopen() of libOpenCL.so to follow proper ABI.

Actually no!

Aug 23 2016, 1:06 PM · BF Blender
Edward O'Callaghan (funfunctor) created T49144: src/clew.c: Fix dlopen() of libOpenCL.so to follow proper ABI.
Aug 23 2016, 8:42 AM · BF Blender