Page MenuHome

John Pavel (jrp)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Feb 3 2014, 9:08 PM (297 w, 6 d)

Recent Activity

Sep 1 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Go ahead and close it. I was using it to keep track of things that I had found.

Sep 1 2014, 12:36 PM · BF Blender, Platform: Windows

May 29 2014

John Pavel (jrp) added a comment to T40413: Building Blender with Mac Pro 2013.

Thanks, @Bastien Montagne (mont29). I can see that you would not want transient build configuration issues clogging up the system. However, when the build process is inconsistent with the wiki documentation that seems to me to be worth noting (and I'm grateful to @jens verwiebe (jensverwiebe) for fixing the issue in this case). I am capable of fixing many of the build issues that I encounter myself, but it seems wasteful not to report out of the box build experience issues so that they can be fixed for everyione.

May 29 2014, 1:42 PM · BF Blender, Platform: macOS
John Pavel (jrp) updated subscribers of T40413: Building Blender with Mac Pro 2013.

Thanks, @Bastien Montagne (mont29). I can see that you would not want transient build configuration issues clogging up the system. However, when the build process is inconsistent with the wiki documentation that seems to me to be worth noting (and I'm grateful to @jens verwiebe (jensverwiebe) for fixing the issue in this case). I am capable of fixing many of the build issues that I encounter myself, but it seems wasteful not to report out of the box build experience issues so that they can be fixed for everyione.

May 29 2014, 1:42 PM · BF Blender, Platform: macOS
John Pavel (jrp) assigned T40413: Building Blender with Mac Pro 2013 to jens verwiebe (jensverwiebe).
May 29 2014, 12:37 AM · BF Blender, Platform: macOS

May 20 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Visual Studio 20013 Update 2 is here. Supports AVX2, so time for a new Cycles kernel??

May 20 2014, 7:25 PM · BF Blender, Platform: Windows

May 4 2014

John Pavel (jrp) raised the priority of T40022: Blender developer website: iPad, iPhone landscape format from to Needs Triage by Developer.
May 4 2014, 4:41 PM · Infrastructure: Websites

May 2 2014

John Pavel (jrp) added a comment to T39972: Switch to VC2013 - Windows.

Are you saying that I don't need the CUDA SDK? When I cmake build, I get no CUDA renderer in cycles (as I do with OpenGL if I set the env variable, with no OpenCL SDK). I don't really want to add new compilers / Windows SDK's.

May 2 2014, 12:47 AM · BF Blender, Platform: Windows

May 1 2014

John Pavel (jrp) added a comment to T39972: Switch to VC2013 - Windows.

Problem with dropping VC 2012 is that it is needed for CUDA, at least until the summer.

May 1 2014, 12:18 AM · BF Blender, Platform: Windows

Apr 22 2014

John Pavel (jrp) added a comment to T39843: recent Win64 builds fail to render BMW.

The title should be recent Win64 builds fail to render BMW.

Apr 22 2014, 8:01 PM · BF Blender, Cycles
John Pavel (jrp) raised the priority of T39843: recent Win64 builds fail to render BMW from to Needs Triage by Developer.
Apr 22 2014, 7:57 PM · BF Blender, Cycles

Apr 19 2014

John Pavel (jrp) assigned T39788: Building RUN_TESTS fails a number of tests to Martijn Berger (juicyfruit).
Apr 19 2014, 12:19 AM · BF Blender

Apr 18 2014

John Pavel (jrp) added a comment to T39772: Floating point exceptions, infinity arithmentic.

Thanks. Let's take it case-by-case:

Apr 18 2014, 2:20 PM · BF Blender, Cycles

Apr 17 2014

John Pavel (jrp) updated subscribers of T39772: Floating point exceptions, infinity arithmentic.

I agree the div by zero does not always need to be fixed if, as you say, you are using what I call infinity arithmetic for shorthand. My point it that it is not used uniformly. For example, we have the likes of bvh_clamp_direction which suggested to me that it was not being used. Even where it is being used, the NaN cases may still need to be dealt with. While I can see that you may not want to do that in the Release builds, it may be worth trapping them in debug builds. More generally, it may be worth asserting the preconditions for performance-sensitive routines to aid debugging, and make the code easier to follow.

Apr 17 2014, 8:07 PM · BF Blender, Cycles
John Pavel (jrp) assigned T39772: Floating point exceptions, infinity arithmentic to Brecht Van Lommel (brecht).
Apr 17 2014, 1:46 PM · BF Blender, Cycles

Apr 12 2014

John Pavel (jrp) added a comment to T39686: Unused omp firstprivate variable sphdata at line 4439 of particle.c.

I don't have commit access, so can I leave it to you, please, @Alex Fraser (z0r)?

Apr 12 2014, 1:06 PM · BF Blender

Apr 11 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

storage.c has a call to _wstat that translates to a call to _wstat64i32 which is not right, as that expects a _stat64*, not stat* arg. The following removes the warning by calling stat

Apr 11 2014, 10:36 PM · BF Blender, Platform: Windows
John Pavel (jrp) assigned T39686: Unused omp firstprivate variable sphdata at line 4439 of particle.c to Alex Fraser (z0r).
Apr 11 2014, 9:38 PM · BF Blender

Apr 5 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

It is no longer necessary, if it ever was, to include explicit function binds when calling thread.

Apr 5 2014, 11:38 PM · BF Blender, Platform: Windows

Mar 31 2014

John Pavel (jrp) added a comment to T38034: Cycles optimization: move srgb/alpha conversion out of cycles kernel.

Halley does seem to be a fraction faster as the previous post illustrates. I've included the complete project file so that you can check that I am timing the right thing. In the great scheme of things the classic powerf doesn't do too badly.

Mar 31 2014, 12:47 AM · BF Blender, Cycles

Mar 30 2014

John Pavel (jrp) added a comment to T38034: Cycles optimization: move srgb/alpha conversion out of cycles kernel.

An here's a patch that includes the slightly faster robust power function (fasterpower24) but also has another (approxpow24) that just uses a polynomial approximation, which is adequate for the limited range needed.

Mar 30 2014, 5:43 PM · BF Blender, Cycles
John Pavel (jrp) added a comment to T38034: Cycles optimization: move srgb/alpha conversion out of cycles kernel.

Here's a slightly enhanced converter. The ^2.4 function is still rather extravagant as it only needs to work in the range 0-1.

Mar 30 2014, 12:57 AM · BF Blender, Cycles

Mar 28 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

And another quickie to set fast transcendentals

Mar 28 2014, 10:16 PM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

A patch to pick up standard versions of isnan, isfinite, isinfinite

Mar 28 2014, 9:54 PM · BF Blender, Platform: Windows

Mar 26 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

FFTW 3.3.4 has been released. This set of project files allows you to build it in VS2013, providing AVX support if your cpu does.

Mar 26 2014, 11:26 PM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Not sure what has changed, recently, but I can now compile cycles with whole program optimization (/GL) and it gives a just noticeable speedup (2:14 v 2:23 on the BMW test).

Mar 26 2014, 3:27 PM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

... missed a couple of uses of thread / mutex in the device_network

Mar 26 2014, 12:36 AM · BF Blender, Platform: Windows

Mar 24 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Thanks. That's v helpful. I am very tempted to change KERNEL_SSE to something like CCL_USE_SIMD to make it clearer that is a different type of animal from the other __KERNEL_SSEs.

Mar 24 2014, 9:38 PM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

@Sv. Lockal (lockal), just so that I get this right, can you please tell me what the different KERNEL defines are used to distinguish (KERNEL_SSE, KERNEL_SSE2, KERNEL_OPENCL_, KERNEL_GPU)? Thanks.

Mar 24 2014, 1:02 AM · BF Blender, Platform: Windows

Mar 23 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Thanks for the pointers. I've now tried with OpenCL and see what you mean. I'll clean things up so that it works with OpenCL again.

Mar 23 2014, 5:16 PM · BF Blender, Platform: Windows
John Pavel (jrp) updated subscribers of T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.
Mar 23 2014, 12:53 AM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

This patch has all the differences between my working copy and the git repository. (I see that I put in an updated glew, which makes the patch humongous, I'm afraid.)

Mar 23 2014, 12:51 AM · BF Blender, Platform: Windows

Mar 20 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Thanks. You are, of course, right. I have just tried to make the minimum change to the code to test the concept. It demonstrates that the new std:: library approach works and, as such, i "#if defined( _MSC_VER ) && (_MSC_VER >= 1800)" should be replaced by some more generic flag that switches on C++11 library support as an alternative to Boost. The C++11 approach might allow us to write more C++ like code (getting rid of pointers to threads, etc).

Mar 20 2014, 12:08 AM · BF Blender, Platform: Windows

Mar 19 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

VC++ 2013 now has a std:: implementation of threads and mutexes.

Mar 19 2014, 9:48 PM · BF Blender, Platform: Windows

Mar 15 2014

John Pavel (jrp) assigned T39202: Invalid call to PyList_New to Campbell Barton (campbellbarton).
Mar 15 2014, 1:55 PM · BF Blender
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Hmmm. Found that MS recommend /O2 over /Ox (enable buffer checks and function level linking, otherwise the same).

Mar 15 2014, 1:42 AM · BF Blender, Platform: Windows

Mar 9 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

A few random observations:

Mar 9 2014, 12:48 AM · BF Blender, Platform: Windows

Mar 5 2014

John Pavel (jrp) added a comment to T38248: blend files open blank from shared drive.

Is the issue that Blender takes the initial \\ to mean that the path is relative (which it should do only if it sees an initial //)?

Mar 5 2014, 11:26 PM · BF Blender, Platform: Windows

Feb 23 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

The other flag that it would be good to enable, particularly for internal parts of the code using SIMD is /Gv (http://blogs.msdn.com/b/vcblog/archive/2013/07/12/introducing-vector-calling-convention.aspx) for x64 builds at least. The trick will be figuring out where not to use it because it won't work with pre-built libraries.

Feb 23 2014, 11:29 PM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

I see that someone has enabled /f arch avx, etc, for the cycles files. They should also do so for the Eigen files.

Feb 23 2014, 7:57 PM · BF Blender, Platform: Windows

Feb 22 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Recent versions of MSVC have unordered map. (Earlier versions also have a version.)

Feb 22 2014, 2:13 PM · BF Blender, Platform: Windows

Feb 20 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Some further findings:

Feb 20 2014, 9:39 PM · BF Blender, Platform: Windows

Feb 10 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

Well I have now managed to get blender to run (it needed a couple of files from the VC2012 OAL library - warp_oal.dll and a dx file).

Feb 10 2014, 12:32 AM · BF Blender, Platform: Windows

Feb 9 2014

John Pavel (jrp) added a comment to T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.

I'll leave it to your discretion (and indeed to apply the patches to the source, as I don't have commit rights).

Feb 9 2014, 1:13 AM · BF Blender, Platform: Windows

Feb 8 2014

John Pavel (jrp) claimed T38551: Minor code cleanups for Visual Studio 2013, which now has a better standard C++ library.
Feb 8 2014, 9:24 PM · BF Blender, Platform: Windows

Feb 7 2014

John Pavel (jrp) added a comment to T38372: Blender crashes on startup if playback device disabled.

OK. I was going by the

Feb 7 2014, 9:39 AM · BF Blender, Platform: Windows
John Pavel (jrp) added a comment to T38372: Blender crashes on startup if playback device disabled.

I think that there is a missing

								if (speaker->sound)
Feb 7 2014, 12:02 AM · BF Blender, Platform: Windows