Page MenuHome

Lukas Toenne (lukastoenne)
User

Projects (16)

User Details

User Since
Dec 20 2009, 11:39 AM (623 w, 4 d)

Recent Activity

Thu, Nov 4

Lukas Toenne (lukastoenne) awarded T72629: Library Override: Support editing of animation data in overriden data-blocks. a Like token.
Thu, Nov 4, 11:33 PM · Core, BF Blender

Nov 2 2021

Lukas Toenne (lukastoenne) added a comment to T88219: 2.92 to 3.0 - Massive drops in Animation playback (fps) in the viewport.

I'm seeing the same issue, on two different machines (both win10, different NVidia cards). Viewport shows 18-25 fps in solid mode, drops to ~12 fps in shaded or rendered.
I have narrowed it down to a combination of armature and subdiv modifiers. Order of modifiers doesn't seem to matter, presumably if the the armature comes first it forces the subdiv to update every frame, or conversely if subdiv comes first it creates more work for the armature deform. The number of bones seems to affect it quite a bit.

Nov 2 2021, 10:33 AM · EEVEE & Viewport, BF Blender

Nov 1 2021

Lukas Toenne (lukastoenne) added a comment to T92452: Rigify Wolf Meta Rig Bone Issue.

Can confirm the issue. I'm using the quadruped rig for a horse, and when the hip is twisted even slightly the spine flips around and causes this unwanted deformation on the back. The issue goes away when i set the roll value of the first spine bone to 180 (in the metarig) so the spine bones' Z axes are all aligned. I'm assuming this is caused by the StretchTo constraint.

Nov 1 2021, 11:14 PM · Add-ons (Community)

Sep 12 2021

Robert Windefjord (Robonnet) awarded D11736: Nodes: Improvements to edge panning in the node editor. a Love token.
Sep 12 2021, 12:49 PM

Aug 31 2021

Alexey Adamitsky (AlexeyAdamitsky) awarded rB19da434e9cc0: Nodes: Improvements to edge panning in the node editor. a Love token.
Aug 31 2021, 10:47 AM

Aug 26 2021

Lukas Toenne (lukastoenne) added a comment to D12292: Utility classes for compact node definitions in C++..

I've stripped down the code to bare minimum now, just with the base type setup function that creates a runtime RNA struct definition, which can then be augmented with ID properties.

Aug 26 2021, 11:06 AM · Geometry Nodes, Nodes
Lukas Toenne (lukastoenne) updated the diff for D12292: Utility classes for compact node definitions in C++..
  • Merge branch 'master' into temp-runtime-node-def
  • Simplified runtime node type definition.
Aug 26 2021, 11:02 AM · Geometry Nodes, Nodes

Aug 24 2021

Hans Goudey (HooglyBoogly) awarded rB19da434e9cc0: Nodes: Improvements to edge panning in the node editor. a Love token.
Aug 24 2021, 7:43 PM
Lukas Toenne (lukastoenne) committed rB19da434e9cc0: Nodes: Improvements to edge panning in the node editor. (authored by Lukas Toenne (lukastoenne)).
Nodes: Improvements to edge panning in the node editor.
Aug 24 2021, 7:02 PM
Lukas Toenne (lukastoenne) closed D11736: Nodes: Improvements to edge panning in the node editor..
Aug 24 2021, 7:01 PM
Lukas Toenne (lukastoenne) added a comment to D11736: Nodes: Improvements to edge panning in the node editor..

Increased the delay to 0.5 seconds now.

Aug 24 2021, 10:16 AM
Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..
  • Merge branch 'master' into node-scrolling-improvements
  • Bump scroll delay in node editor up to 0.5 seconds.
Aug 24 2021, 10:16 AM
Lukas Toenne (lukastoenne) added a comment to D12292: Utility classes for compact node definitions in C++..

Or we could just add defaults in the base class for everything expected, so a "T::<fieldname>" expression will never fail to compile.

Aug 24 2021, 9:25 AM · Geometry Nodes, Nodes
Lukas Toenne (lukastoenne) added a comment to D12292: Utility classes for compact node definitions in C++..

Moving more stuff into files for specific nodes should be done separately from refactoring how nodes are defined in general.

Aug 24 2021, 8:56 AM · Geometry Nodes, Nodes

Aug 23 2021

Lukas Toenne (lukastoenne) updated the diff for D12292: Utility classes for compact node definitions in C++..
  • Revert cleanup changes to node DNA.
Aug 23 2021, 10:11 AM · Geometry Nodes, Nodes
Lukas Toenne (lukastoenne) planned changes to D12292: Utility classes for compact node definitions in C++..
Aug 23 2021, 10:08 AM · Geometry Nodes, Nodes

Aug 22 2021

Lukas Toenne (lukastoenne) added projects to D12292: Utility classes for compact node definitions in C++.: Nodes, Geometry Nodes.
Aug 22 2021, 6:18 PM · Geometry Nodes, Nodes
Lukas Toenne (lukastoenne) requested review of D12292: Utility classes for compact node definitions in C++..
Aug 22 2021, 6:16 PM · Geometry Nodes, Nodes

Aug 10 2021

Lukas Toenne (lukastoenne) added a comment to D10912: Nodes: Add a button to change group socket types.

Is there an intention to add the ability to change subtype in this patch or will this be in a future patch?

Aug 10 2021, 11:09 AM · Nodes & Physics, BF Blender, Geometry Nodes
Charlie Jolly (charlie) awarded D10912: Nodes: Add a button to change group socket types a Love token.
Aug 10 2021, 10:41 AM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) added a comment to T90233: Crash choosing interface socket type of custom tree.

Fixes in D12179.

Aug 10 2021, 10:35 AM · Nodes & Physics, Nodes, BF Blender
Lukas Toenne (lukastoenne) added a project to D12179: Nodes: Fix T90233: Nodes.
Aug 10 2021, 10:29 AM · Nodes
Lukas Toenne (lukastoenne) added a revision to T90233: Crash choosing interface socket type of custom tree: D12179: Nodes: Fix T90233.
Aug 10 2021, 10:28 AM · Nodes & Physics, Nodes, BF Blender
Lukas Toenne (lukastoenne) added a task to D12179: Nodes: Fix T90233: T90233: Crash choosing interface socket type of custom tree.
Aug 10 2021, 10:28 AM · Nodes
Lukas Toenne (lukastoenne) retitled D12179: Nodes: Fix T90233 from Nodes: Fix crash when adding a custom tree socket. to Nodes: Fix T90233.
Aug 10 2021, 10:28 AM · Nodes
Lukas Toenne (lukastoenne) requested review of D12179: Nodes: Fix T90233.
Aug 10 2021, 10:27 AM · Nodes
Lukas Toenne (lukastoenne) claimed T90233: Crash choosing interface socket type of custom tree.

Confirmed, will take a look. At first glance looks like the custom socket has a default_value pointer, which should not be happening (is only used for C socket types, custom sockets use only IDProperties).

Aug 10 2021, 9:17 AM · Nodes & Physics, Nodes, BF Blender

Aug 1 2021

Lukas Toenne (lukastoenne) requested changes to D10787: Node Editor: Paste Node on mouse position.
Aug 1 2021, 10:21 AM · Nodes
Lukas Toenne (lukastoenne) added a comment to D10787: Node Editor: Paste Node on mouse position.

Thanks for this patch, should make copy/paste much more usable.

Aug 1 2021, 10:21 AM · Nodes

Jul 24 2021

Lukas Toenne (lukastoenne) updated the summary of D12022: Nodes: Make link insert optional and improved unlink.
Jul 24 2021, 1:46 PM · Nodes
Lukas Toenne (lukastoenne) retitled D12022: Nodes: Make link insert optional and improved unlink from Nodes: Modal "unlink" support in node transform. to Nodes: Make link insert optional and improved unlink.
Jul 24 2021, 1:46 PM · Nodes
Lukas Toenne (lukastoenne) updated the summary of D12022: Nodes: Make link insert optional and improved unlink.
Jul 24 2021, 1:25 PM · Nodes
Lukas Toenne (lukastoenne) added a project to D12022: Nodes: Make link insert optional and improved unlink: Nodes.
Jul 24 2021, 1:00 PM · Nodes
Lukas Toenne (lukastoenne) requested review of D12022: Nodes: Make link insert optional and improved unlink.
Jul 24 2021, 12:59 PM · Nodes

Jul 18 2021

Yuro (Yuro) awarded D11736: Nodes: Improvements to edge panning in the node editor. a Love token.
Jul 18 2021, 1:21 PM

Jul 16 2021

Lukas Toenne (lukastoenne) added a comment to D11736: Nodes: Improvements to edge panning in the node editor..

In the interest of getting this patch finished i've added back some of the delay for smooth scrolling. It's faster than the previous value, so please check if that works for you.

Jul 16 2021, 8:56 AM
Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..

Added back some of the delay in node edge panning.

Jul 16 2021, 8:55 AM

Jul 14 2021

Lukas Toenne (lukastoenne) added a comment to D11736: Nodes: Improvements to edge panning in the node editor..

Without it, I find the panning feels robotic, instant, and too often makes big changes when I just want to move the view slightly. It loses the subtlety and elegance it had before.

Obviously this is going to be somewhat subjective, and that's just my opinion. But I wonder if we would want to try committing this without the change to the delay and see how that does.

Jul 14 2021, 5:53 PM

Jul 13 2021

Lukas Toenne (lukastoenne) added a comment to T89829: Geometry Nodes: Crash when selecting attribute name.

The problem appears to be related to the "Viewer Node" mode of the spreadsheet editor. When i set it back to "Evaluated" the attribute search works correctly.
On cursory inspection it looks like geometry nodes destroys the search data during cleanup after execution.

Jul 13 2021, 12:52 AM · Nodes & Physics, Geometry Nodes, BF Blender
Lukas Toenne (lukastoenne) created T89829: Geometry Nodes: Crash when selecting attribute name.
Jul 13 2021, 12:40 AM · Nodes & Physics, Geometry Nodes, BF Blender

Jul 9 2021

Lukas Toenne (lukastoenne) retitled D11736: Nodes: Improvements to edge panning in the node editor. from Improvements to edge panning in the node editor. to Nodes: Improvements to edge panning in the node editor..
Jul 9 2021, 9:12 AM
Lukas Toenne (lukastoenne) committed rB07faa3c5acac: Nodes: Moved group interface panel code to python. (authored by Lukas Toenne (lukastoenne)).
Nodes: Moved group interface panel code to python.
Jul 9 2021, 8:59 AM
Lukas Toenne (lukastoenne) closed D11834: Nodes: Moved node group interface panel code to python..
Jul 9 2021, 8:59 AM

Jul 8 2021

Lukas Toenne (lukastoenne) added a comment to T68733: Node Group Inputs.

I started a draft for the single-socket nodes: D11853

Jul 8 2021, 4:55 PM · Nodes

Jul 6 2021

Lukas Toenne (lukastoenne) added reviewers for D11834: Nodes: Moved node group interface panel code to python.: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke).
Jul 6 2021, 8:24 PM
Lukas Toenne (lukastoenne) retitled D11834: Nodes: Moved node group interface panel code to python. from Moved node group interface panel code to python. to Nodes: Moved node group interface panel code to python..
Jul 6 2021, 8:23 PM
Lukas Toenne (lukastoenne) requested review of D11834: Nodes: Moved node group interface panel code to python..
Jul 6 2021, 8:21 PM
Lukas Toenne (lukastoenne) closed D10912: Nodes: Add a button to change group socket types.
Jul 6 2021, 7:41 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) committed rB586cf8b19052: Nodes: Adds button to groups to change type of sockets. (authored by Lukas Toenne (lukastoenne)).
Nodes: Adds button to groups to change type of sockets.
Jul 6 2021, 7:41 PM
Lukas Toenne (lukastoenne) added a comment to D10912: Nodes: Add a button to change group socket types.

Images for posterity:

Jul 6 2021, 7:31 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the summary of D10912: Nodes: Add a button to change group socket types.
Jul 6 2021, 7:23 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) added inline comments to D10912: Nodes: Add a button to change group socket types.
Jul 6 2021, 6:36 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.
  • Changing sock->type is done by node_socket_set_typeinfo.
  • Formatting fixes.
Jul 6 2021, 6:33 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) added a comment to D10912: Nodes: Add a button to change group socket types.
  • Don't show the socket icon (the colored circle) to the left of the type enum. It breaks up the alignment so it looks messy, and doesn't really add anything
    • If anything, the icons should show in the enum list. I'm not sure that is possible currently though, since they are "special" icons.
  • Don't show the "plug" icons in the enum. They're messy and don't add anything.
Jul 6 2021, 7:47 AM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.
  • Put back socket type enums that were removed.
  • Removed the colored circle next to type button.
  • Remove the ICON_PLUGIN from node socket RNA.
  • Nicer labels for integer and color sockets.
Jul 6 2021, 7:46 AM · Nodes & Physics, BF Blender, Geometry Nodes

Jul 5 2021

Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.
  • Remove the valid_socket_type_full method. The valid_socket_type callback was added very recently, so there is no harm in changing it at this point. That avoids the complication of having two variants in the API.
Jul 5 2021, 9:30 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the summary of D10912: Nodes: Add a button to change group socket types.
Jul 5 2021, 7:29 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) added a comment to T68733: Node Group Inputs.

Use the existing socket-hiding mechanism for creating single-socket inputs (ctrl+h key, the old SOCK_UNAVAIL flag).

Do you mean to use SOCK_HIDDEN or SOCK_UNAVAIL? Ctrl+h modifies SOCK_HIDDEN.

Jul 5 2021, 3:35 PM · Nodes
Lukas Toenne (lukastoenne) added a comment to D10912: Nodes: Add a button to change group socket types.

On the topic of sockets vs. socket interfaces:
The node groups use the bNodeSocketType BKE struct both for node sockets as well as socket declarations in node groups. This can make things really confusing, and i'm itching to separate these types and match the RNA classes ("NodeSocket" and "NodeSocketInterface") to their own respective BKE structs. However, i don't want to get carried away here, so i'll just mention the issue and leave it for another time. Would be nice if we could clean up the crusty old RNA in the process, although that's optional and might break the API. Then again, if it's ever going to happen then Blender 3.0 might be the time to do it ...

Jul 5 2021, 8:39 AM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) planned changes to D10912: Nodes: Add a button to change group socket types.

I would like to add subtype support along with the "primary" type here. To that end it might be preferable to switch from an operator to a property for the type and subtype. It would also make the UI a little bit easier, not requiring the hack to emulate layout split for properties.

Jul 5 2021, 8:20 AM · Nodes & Physics, BF Blender, Geometry Nodes

Jul 4 2021

Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.

UI improvements for the socket type operator.

Jul 4 2021, 5:40 PM · Nodes & Physics, BF Blender, Geometry Nodes

Jul 3 2021

Lukas Toenne (lukastoenne) added inline comments to D10912: Nodes: Add a button to change group socket types.
Jul 3 2021, 6:48 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.

Removed accidentally committed test script.

Jul 3 2021, 6:44 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) added inline comments to D10912: Nodes: Add a button to change group socket types.
Jul 3 2021, 6:43 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.

Changing sockets now based on type idname.

Jul 3 2021, 6:43 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) updated the diff for D10912: Nodes: Add a button to change group socket types.

Type change in the group socket update function.

Jul 3 2021, 12:56 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) commandeered D10912: Nodes: Add a button to change group socket types.

Had some discussion with @Wannes Malfait (Wannes) and we've agreed that i will take over this patch.

Jul 3 2021, 12:41 PM · Nodes & Physics, BF Blender, Geometry Nodes
Lukas Toenne (lukastoenne) requested changes to D10912: Nodes: Add a button to change group socket types.

Thank you for implementing this feature, it's been sorely needed for a long time.

Jul 3 2021, 9:23 AM · Nodes & Physics, BF Blender, Geometry Nodes

Jul 2 2021

Lukas Toenne (lukastoenne) added a comment to T68733: Node Group Inputs.

@Tomas (Rusculleda) Thanks, i'll be following that patch discussion. At a glance it seems there is some opposition (when is there ever none) to popping up a menu on the drop. I can think of some alternatives (context menu on socket, pie menu, etc). It should still work without this feature though. Potentially can also be an API extension such that a "node from noodle" feature like this can be implemented in a python addon.

Jul 2 2021, 4:15 PM · Nodes
Lukas Toenne (lukastoenne) added a comment to T68733: Node Group Inputs.

I would like start this task with a list of relatively simple and uncontroversial changes:

  • Use the existing socket-hiding mechanism for creating single-socket inputs (ctrl+h key, the old SOCK_UNAVAIL flag). This can be implemented quite easily and it gives us backward compatibility. Adding a group input just hides all but one socket by default.
Jul 2 2021, 12:37 PM · Nodes
Alexey Adamitsky (AlexeyAdamitsky) awarded D11073: Edge-scrolling for node editor a Burninate token.
Jul 2 2021, 8:53 AM · Nodes, User Interface
Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..

Increase default node scroll speed again.

Jul 2 2021, 8:11 AM

Jul 1 2021

Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..

Zoom influence factor for edge scroll speed.

Jul 1 2021, 11:33 AM

Jun 30 2021

Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..
  • Zero delay in node editor scrolling.
Jun 30 2021, 8:10 AM

Jun 29 2021

Lukas Toenne (lukastoenne) added a comment to D11736: Nodes: Improvements to edge panning in the node editor..

I've tested settings with zero "delay" on the scrolling, which feels quite nice and reactive. Also slightly slower speed here:

Jun 29 2021, 6:38 PM
Lukas Toenne (lukastoenne) requested review of D11736: Nodes: Improvements to edge panning in the node editor..
Jun 29 2021, 6:21 PM
Lukas Toenne (lukastoenne) planned changes to D11736: Nodes: Improvements to edge panning in the node editor..
Jun 29 2021, 6:18 PM
Lukas Toenne (lukastoenne) updated the diff for D11736: Nodes: Improvements to edge panning in the node editor..
  • Only reset the node view when links are cancelled.
Jun 29 2021, 6:18 PM
Rahul Chaudhary (RC12) awarded D11736: Nodes: Improvements to edge panning in the node editor. a Love token.
Jun 29 2021, 2:24 PM
Lukas Toenne (lukastoenne) requested review of D11736: Nodes: Improvements to edge panning in the node editor..
Jun 29 2021, 1:38 PM

Jun 27 2021

Lukas Toenne (lukastoenne) awarded D11209: [WIP] Reroute node improvements a Love token.
Jun 27 2021, 12:15 AM · Nodes & Physics, User Interface

Jun 23 2021

Lukas Toenne (lukastoenne) created T89390: Geometry node crash when Join Geometry has only muted inputs.
Jun 23 2021, 7:32 PM · Nodes & Physics, Geometry Nodes, BF Blender

Jun 22 2021

Gilberto Rodrigues (gilberto_rodrigues) awarded D11073: Edge-scrolling for node editor a Love token.
Jun 22 2021, 9:22 PM · Nodes, User Interface
炎臻 (PrettyFireNOI7) awarded D11073: Edge-scrolling for node editor a Love token.
Jun 22 2021, 11:12 AM · Nodes, User Interface

Jun 21 2021

Lukas Toenne (lukastoenne) awarded D11406: Volumes: Adds ability for non-visualizable openvdb grids to generate an alternate grid for display a Love token.
Jun 21 2021, 9:40 AM
Lukas Toenne (lukastoenne) closed T49092: Object Nodes Proposal for Blender 2.8 as Archived.

This is ancient, i'm archiving it.

Jun 21 2021, 8:42 AM · Nodes

Jun 18 2021

Lukas Toenne (lukastoenne) committed rBM8143: Nodes: Docs for the raycast geometry node..
Nodes: Docs for the raycast geometry node.
Jun 18 2021, 12:43 PM
Lukas Toenne (lukastoenne) closed D11620: Documentation for Raycast geometry node.
Jun 18 2021, 12:39 PM
Damian (damian) awarded D11619: Raycast geometry node. a Love token.
Jun 18 2021, 11:44 AM
Lopo Isaac (lopoIsaac) awarded D11619: Raycast geometry node. a Love token.
Jun 18 2021, 8:06 AM
Andres Stephens (Draise) awarded D11073: Edge-scrolling for node editor a Love token.
Jun 18 2021, 4:11 AM · Nodes, User Interface
Andres Stephens (Draise) awarded D11619: Raycast geometry node. a Love token.
Jun 18 2021, 4:11 AM
Wilsimar (wilBr) awarded rB4b673ebb9906: Raycast geometry node. a Love token.
Jun 18 2021, 3:43 AM

Jun 17 2021

Lukas Toenne (lukastoenne) committed rB4b673ebb9906: Raycast geometry node. (authored by Lukas Toenne (lukastoenne)).
Raycast geometry node.
Jun 17 2021, 10:12 PM
Lukas Toenne (lukastoenne) closed D11619: Raycast geometry node..
Jun 17 2021, 10:12 PM
Lukas Toenne (lukastoenne) added a comment to D11620: Documentation for Raycast geometry node.

Updated the image.

Jun 17 2021, 9:57 PM
Lukas Toenne (lukastoenne) updated the diff for D11620: Documentation for Raycast geometry node.

Unselected node for image and socket doc clarified.

Jun 17 2021, 9:57 PM
Lukas Toenne (lukastoenne) added inline comments to D11619: Raycast geometry node..
Jun 17 2021, 9:15 PM
kursad k (kursadk) awarded D11619: Raycast geometry node. a Love token.
Jun 17 2021, 5:50 PM
Lukas Toenne (lukastoenne) updated the summary of D11620: Documentation for Raycast geometry node.
Jun 17 2021, 10:58 AM