Page MenuHome

Bastien Montagne (mont29)
AnimalAdministrator

Projects (21)

User Details

User Since
Oct 7 2010, 12:19 PM (552 w, 3 h)
Roles
Administrator

Recent Activity

Yesterday

Bastien Montagne (mont29) committed rB5f7f90d5a222: Merge branch 'blender-v2.93-release' (authored by Bastien Montagne (mont29)).
Merge branch 'blender-v2.93-release'
Wed, May 5, 4:43 PM
Bastien Montagne (mont29) committed rB0e5f58b68eb0: LibOverride: More fixes to properly ignore non-overridable ID pointers. (authored by Bastien Montagne (mont29)).
LibOverride: More fixes to properly ignore non-overridable ID pointers.
Wed, May 5, 4:42 PM
Bastien Montagne (mont29) committed rBcbb057e378e1: LibOverride: Tag base's object pointer as not overridable. (authored by Bastien Montagne (mont29)).
LibOverride: Tag base's object pointer as not overridable.
Wed, May 5, 4:42 PM
Bastien Montagne (mont29) committed rB1f184066ba53: Merge branch 'blender-v2.93-release' (authored by Bastien Montagne (mont29)).
Merge branch 'blender-v2.93-release'
Wed, May 5, 2:22 PM
Bastien Montagne (mont29) committed rBfff80afe3993: LibQuery: Cleanup: Document more fields of `LibraryForeachIDData` struct. (authored by Bastien Montagne (mont29)).
LibQuery: Cleanup: Document more fields of `LibraryForeachIDData` struct.
Wed, May 5, 2:22 PM
Bastien Montagne (mont29) committed rB693a215dc446: LibOverride: Fix usage of IDProps that are not overridable. (authored by Bastien Montagne (mont29)).
LibOverride: Fix usage of IDProps that are not overridable.
Wed, May 5, 2:22 PM
Bastien Montagne (mont29) committed rBb616c522d9b3: LibOverride/LibQuery: Refactor 'non-overridable' status management. (authored by Bastien Montagne (mont29)).
LibOverride/LibQuery: Refactor 'non-overridable' status management.
Wed, May 5, 2:22 PM
Bastien Montagne (mont29) updated <SPAMMER> (smithmachinist725).
Wed, May 5, 11:28 AM

Tue, May 4

Bastien Montagne (mont29) accepted D11145: Fix T87983: Motion tracker button tooltips identical.
Tue, May 4, 12:45 PM

Mon, May 3

Bastien Montagne (mont29) added a comment to T87999: Undo "SVG as Grease Pencil" Crashes.

Hrmmm.... This smells like some ID being added or changed without proper tagging, or without proper call to collections/layercollections update functions (guys like BKE_main_collection_sync_remap). Or maybe a missing object cache clearing (BKE_collection_object_cache_free)?

Mon, May 3, 7:01 PM · Grease Pencil, BF Blender
Bastien Montagne (mont29) requested changes to D11145: Fix T87983: Motion tracker button tooltips identical.

Indeed TIP_ is mandatory here. Besides picky note about UI messages style, looks fine.

Mon, May 3, 6:45 PM
Bastien Montagne (mont29) added a comment to T87983: Motion tracker tooltips identical for different buttons.

@Sergey Sharybin (sergey) in that case I would say yes.

Mon, May 3, 6:41 PM · BF Blender (2.93), VFX & Video, Motion Tracking
Bastien Montagne (mont29) added inline comments to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Mon, May 3, 4:45 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) added a comment to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.

What's the reason to not just fix the depsgraph in those places where it created or removed some of those evaluated dependencies? What's against taking the appropriate action at that time, instead of always performing this post-build check?

Mon, May 3, 4:29 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) committed rBTd2d33a435d35: Updated from svn trunk (rBTS5667). (authored by Bastien Montagne (mont29)).
Updated from svn trunk (rBTS5667).
Mon, May 3, 12:53 PM
Bastien Montagne (mont29) committed rBTS5667: Updated trunk from branches (rBTS5666)..
Updated trunk from branches (rBTS5666).
Mon, May 3, 12:39 PM
Bastien Montagne (mont29) committed rBTS5666: Updated branches from Blender 2.93 (rBa53d34a28a9db646)..
Updated branches from Blender 2.93 (rBa53d34a28a9db646).
Mon, May 3, 12:26 PM
Bastien Montagne (mont29) committed rBa53d34a28a9d: Minor updates to i18n spellcheck tool. (authored by Bastien Montagne (mont29)).
Minor updates to i18n spellcheck tool.
Mon, May 3, 12:23 PM
Bastien Montagne (mont29) committed rBTS5665: Updated Vietnamese translations (from Hồ Châu)..
Updated Vietnamese translations (from Hồ Châu).
Mon, May 3, 12:18 PM
Bastien Montagne (mont29) committed rBTS5664: Updated Slovak translations (from Jozef Matta @pegas923)..
Updated Slovak translations (from Jozef Matta @pegas923).
Mon, May 3, 12:18 PM

Fri, Apr 30

Bastien Montagne (mont29) committed rB5e53504b3bc0: Merge branch 'blender-v2.93-release' (authored by Bastien Montagne (mont29)).
Merge branch 'blender-v2.93-release'
Fri, Apr 30, 6:50 PM
Bastien Montagne (mont29) committed rBe61020049aa6: LibOverride: Make drivers' 'mute' flag overridable. (authored by Bastien Montagne (mont29)).
LibOverride: Make drivers' 'mute' flag overridable.
Fri, Apr 30, 6:49 PM
Bastien Montagne (mont29) committed rBa8e7c8d59b32: LibOverride: Fix infinite resync loop in some invalid file cases. (authored by Bastien Montagne (mont29)).
LibOverride: Fix infinite resync loop in some invalid file cases.
Fri, Apr 30, 6:49 PM
Bastien Montagne (mont29) accepted D11126: Modify poll functions to resolve NULL pointer dereference for modifier/constraint/fx operators.

LGTM, don't see any reason no to check that here indeed.

Fri, Apr 30, 12:33 PM · Core

Mon, Apr 26

Bastien Montagne (mont29) updated subscribers of D10881: Cleanup: Fix incorrect error in mesh validation code.

AFAIK Z-up is the convention when there is no way to get a proper normal from vco...

Mon, Apr 26, 4:48 PM
Bastien Montagne (mont29) accepted D10893: Added Operator tests: unsubdivide, shading, vertex connect and mark seam.

LGTM from quick look. :)

Mon, Apr 26, 4:04 PM
Bastien Montagne (mont29) added a comment to D10881: Cleanup: Fix incorrect error in mesh validation code.

Am not sure I understand that 'fix'? How having a NULL normal is ever a good thing? I would rather fix the code using vco to detect zero case and generate that dummy 'Z-up' normal then?

Mon, Apr 26, 3:49 PM
Bastien Montagne (mont29) committed rBT2c9eee69e654: Updated from svn trunk (rBTS5659). (authored by Bastien Montagne (mont29)).
Updated from svn trunk (rBTS5659).
Mon, Apr 26, 10:25 AM
Bastien Montagne (mont29) committed rBa65d5dadeb61: DeprecationWarning fix (authored by Erik Abrahamsson (erik85)).
DeprecationWarning fix
Mon, Apr 26, 9:48 AM
Bastien Montagne (mont29) closed D10998: DeprecationWarning fix.
Mon, Apr 26, 9:48 AM · Python API
Bastien Montagne (mont29) committed rBTS5659: Updated trunk from branches (rBTS5658)..
Updated trunk from branches (rBTS5658).
Mon, Apr 26, 9:30 AM
Bastien Montagne (mont29) accepted D10998: DeprecationWarning fix.

Thanks (but please avoid assigning patches to people yourself in the future).

Mon, Apr 26, 9:23 AM · Python API
Bastien Montagne (mont29) committed rBTS5658: Updated branches from blender 2.93 (rBa17ea1a6691920cc)..
Updated branches from blender 2.93 (rBa17ea1a6691920cc).
Mon, Apr 26, 9:21 AM
Bastien Montagne (mont29) committed rBTS5657: Updated Slovak translations (from Jozef Matta @pegas923)..
Updated Slovak translations (from Jozef Matta @pegas923).
Mon, Apr 26, 9:06 AM

Fri, Apr 23

Bastien Montagne (mont29) added a comment to D10983: Fix T87489: Text Data-Blocks get deleted on Recursive Purge.

Text datablocks have always been handled similar to scenes as far as I know. It's not clear to me why that is being changed to fake user now as a fix, instead of adding it to the list of exceptions.

The new fake user button in the text editor is not helpful to most end users, it's mostly a button that helps you lose data by accident. If the datablock selector is redesigned and this moves into a menu it's less of a risk. I guess for text datablocks autogenerated by scripts there may be a use case.

Fri, Apr 23, 4:29 PM
Bastien Montagne (mont29) added a comment to D10983: Fix T87489: Text Data-Blocks get deleted on Recursive Purge.

Also, we should stop adding things like this in new code:

if (ELEM(GS(id->name), ID_WM, ID_WS, ID_SCE, ID_SCR, ID_LI)) {

That's what IDTypeInfo is for.

Fri, Apr 23, 4:20 PM
Bastien Montagne (mont29) committed rB8adeac7c2793: Merge branch 'blender-v2.93-release' (authored by Bastien Montagne (mont29)).
Merge branch 'blender-v2.93-release'
Fri, Apr 23, 2:36 PM
Bastien Montagne (mont29) committed rB9afa73854288: Fix bug/crash in ID bulk deletion code. (authored by Bastien Montagne (mont29)).
Fix bug/crash in ID bulk deletion code.
Fri, Apr 23, 2:35 PM

Thu, Apr 22

Bastien Montagne (mont29) accepted D10983: Fix T87489: Text Data-Blocks get deleted on Recursive Purge.

Patch looks good to me now...

Thu, Apr 22, 1:58 PM

Wed, Apr 21

Bastien Montagne (mont29) requested changes to D11000: Don't Make Depsgraph Links For Disabled Modifiers.

Well... First of all, think this should be tagged to Dependency Graph more than Modifiers really... Also please avoid assigning reviewers directly.

Wed, Apr 21, 8:45 AM · Core, Dependency Graph, BF Blender, Modifiers
Bastien Montagne (mont29) removed a reviewer for D10862: Expose Face Sets to Python: Python API.
Wed, Apr 21, 8:24 AM · Python API, Sculpt, Paint & Texture

Mon, Apr 19

Bastien Montagne (mont29) added a comment to T87310: Add "Asset User" to the data-block user counting.

Once again I think we should rather seriously spend time on T61209: Always write unused IDs on save, this would also solve that case imho.

Mon, Apr 19, 8:34 PM · Core, Asset Browser (Milestone 1: Basic, Local Asset Browser)

Fri, Apr 16

Bastien Montagne (mont29) accepted D10848: Override: API update_operations..
Fri, Apr 16, 4:55 PM
Bastien Montagne (mont29) requested changes to D10983: Fix T87489: Text Data-Blocks get deleted on Recursive Purge.

Looks mostly fine, mainly missing a sub-version bump.

Fri, Apr 16, 4:19 PM

Wed, Apr 14

Bastien Montagne (mont29) added a comment to T87490: Recursive Purge Orphans datablocks on file save.

@Demeter Dzadik (Mets) would keep both for now, while related they are not entirely the same. We can re-iterate on designs and such once we actually start working on those.

Wed, Apr 14, 5:09 PM · Core, BF Blender
Bastien Montagne (mont29) edited Description on Core.
Wed, Apr 14, 5:03 PM
Bastien Montagne (mont29) edited Description on Pipeline, Assets & I/O.
Wed, Apr 14, 5:02 PM
Bastien Montagne (mont29) edited Description on Pipeline, Assets & I/O.
Wed, Apr 14, 5:00 PM
Bastien Montagne (mont29) edited Description on Pipeline, Assets & I/O.
Wed, Apr 14, 4:59 PM
Bastien Montagne (mont29) changed the subtype of T87490: Recursive Purge Orphans datablocks on file save from "Report" to "Design".

Also related to T61209: Always write unused IDs on save

Wed, Apr 14, 1:29 PM · Core, BF Blender

Tue, Apr 13

Konstantins Visnevskis (kivig) awarded rBe1ae5bd45fd0: LibOverride: Add a dedicated view in the Outliner. a Love token.
Tue, Apr 13, 5:17 PM

Mon, Apr 12

Bastien Montagne (mont29) committed rBTf7b706dd6434: Updated from svn trunk (rBTS5649). (authored by Bastien Montagne (mont29)).
Updated from svn trunk (rBTS5649).
Mon, Apr 12, 11:41 AM
Bastien Montagne (mont29) committed rBTS5649: Updated trunk from branches (rBTS5648)..
Updated trunk from branches (rBTS5648).
Mon, Apr 12, 10:51 AM
Bastien Montagne (mont29) committed rBTS5648: Updated branches from Blender master (rB71cb0bdc43368)..
Updated branches from Blender master (rB71cb0bdc43368).
Mon, Apr 12, 10:45 AM
Bastien Montagne (mont29) committed rBTS5647: Updated Vietnamese translations (from Hồ Châu)..
Updated Vietnamese translations (from Hồ Châu).
Mon, Apr 12, 10:34 AM
Bastien Montagne (mont29) committed rBTS5646: Updated Slovak translations (from Jozef Matta @pegas923)..
Updated Slovak translations (from Jozef Matta @pegas923).
Mon, Apr 12, 10:29 AM

Sat, Apr 10

Bastien Montagne (mont29) committed rBed5507de8a25: LibOverride: Fix resync bug on recursive overrides. (authored by Bastien Montagne (mont29)).
LibOverride: Fix resync bug on recursive overrides.
Sat, Apr 10, 6:39 PM
Bastien Montagne (mont29) committed rB3bd892a74c82: LibOverride: Fix (unreported) assert when creating overrides of linked… (authored by Bastien Montagne (mont29)).
LibOverride: Fix (unreported) assert when creating overrides of linked…
Sat, Apr 10, 6:39 PM
Bastien Montagne (mont29) committed rBc9e054c5de51: LibOverride: Add own flag to copy or not overrides to ID copy code. (authored by Bastien Montagne (mont29)).
LibOverride: Add own flag to copy or not overrides to ID copy code.
Sat, Apr 10, 6:39 PM

Fri, Apr 9

Bastien Montagne (mont29) added a comment to T87333: Proposal for type hint use in Blender's Python scripts.

For the records, proposal LGTM... Personnaly I would be very conservative about what module we switch to type hinting though.

Fri, Apr 9, 2:35 PM · Core
Bastien Montagne (mont29) added inline comments to D10922: Fix const-correctness in ID preview code.
Fri, Apr 9, 11:53 AM · Core, BF Blender
Bastien Montagne (mont29) added a comment to T86943: Startup & Core Scripts Code Style.

In general proposal LGTM.

Fri, Apr 9, 11:40 AM · Python API, Core

Thu, Apr 8

Bastien Montagne (mont29) placed T60695: Optimized per-datablock global undo up for grabs.
Thu, Apr 8, 9:02 PM · Core, BF Blender, Performance
Bastien Montagne (mont29) moved T83806: Undo - Current Status and Important Fixes Needed from Blender 2.93 to Long-Term - Official on the Core board.
Thu, Apr 8, 9:01 PM · BF Blender, Core
Bastien Montagne (mont29) edited projects for T83806: Undo - Current Status and Important Fixes Needed, added: BF Blender; removed BF Blender (2.93).
Thu, Apr 8, 9:01 PM · BF Blender, Core
Bastien Montagne (mont29) added inline comments to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Thu, Apr 8, 8:49 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) updated the diff for D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.

Minor updates.

Thu, Apr 8, 8:48 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) added inline comments to D10922: Fix const-correctness in ID preview code.
Thu, Apr 8, 8:35 PM · Core, BF Blender
Bastien Montagne (mont29) added inline comments to D10332: Code quality: Use ID-type callback to get an ID's preview-image.
Thu, Apr 8, 8:20 PM · Core
Bastien Montagne (mont29) requested changes to D10332: Code quality: Use ID-type callback to get an ID's preview-image.
Thu, Apr 8, 5:05 PM · Core
Bastien Montagne (mont29) added a comment to D10332: Code quality: Use ID-type callback to get an ID's preview-image.

To be clear, what I call overhead here is:

  • Adding extra function to API only to deal with const/non-const cases (this remains C code for now, this is fairly annoying imho).
  • Adding hard-to-decipher things like * const *;
Thu, Apr 8, 5:04 PM · Core
Bastien Montagne (mont29) requested review of D10922: Fix const-correctness in ID preview code.
Thu, Apr 8, 5:04 PM · Core, BF Blender
Bastien Montagne (mont29) updated the diff for D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.

Minor updates from review.

Thu, Apr 8, 3:46 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) added inline comments to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Thu, Apr 8, 3:45 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) added inline comments to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Thu, Apr 8, 3:42 PM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) removed a reviewer for D6703: Python Handlers: Add export events.: Pipeline, Assets & I/O.

@Sybren A. Stüvel (sybren) please do not add whole projects as reviewers (tagging is fine of course). This only adds lots of noise for many people.

Thu, Apr 8, 2:26 PM · Pipeline, Assets & I/O
Bastien Montagne (mont29) closed D10855: LibOverride: Initial dedicated view in the Outliner..

Committed as listed above.

Thu, Apr 8, 11:50 AM
Bastien Montagne (mont29) committed rBc1b1ed4d5b2f: Minor cleanup to `scene_collection_array`. (authored by Bastien Montagne (mont29)).
Minor cleanup to `scene_collection_array`.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rBe92a7800b576: LibOverride: Fix several issues with resync code. (authored by Bastien Montagne (mont29)).
LibOverride: Fix several issues with resync code.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rBb4d6fe1f87c8: Cleanup: Typos in comments. (authored by Bastien Montagne (mont29)).
Cleanup: Typos in comments.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rB89e353354f11: Outliner Override: Tweak to order of error messages. (authored by Bastien Montagne (mont29)).
Outliner Override: Tweak to order of error messages.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rB14d74fb34174: BKE_collection: Add a util returning a gset with all objects in given scene's… (authored by Bastien Montagne (mont29)).
BKE_collection: Add a util returning a gset with all objects in given scene's…
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rB92dfc8f2673e: Outliner: regroup more type of entries under a single icon. (authored by Bastien Montagne (mont29)).
Outliner: regroup more type of entries under a single icon.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rBe1ae5bd45fd0: LibOverride: Add a dedicated view in the Outliner. (authored by Bastien Montagne (mont29)).
LibOverride: Add a dedicated view in the Outliner.
Thu, Apr 8, 11:48 AM
Bastien Montagne (mont29) committed rB8b68a7587237: LibOverride: Add a new 'leftover' flag to ID. (authored by Bastien Montagne (mont29)).
LibOverride: Add a new 'leftover' flag to ID.
Thu, Apr 8, 11:48 AM

Wed, Apr 7

Bastien Montagne (mont29) closed T87265: Lack of file overwrite prompt leads to data loss as Archived.

Thanks for the report, but this is absolutely not a bug, everything is working as expected.

Wed, Apr 7, 8:33 PM · BF Blender
Bastien Montagne (mont29) added a comment to T82404: Library Overrides: Shader drivers stop working after save and reload.

NodeTrees are definitely not supported currently by overrides, and are indeed a known TODO, no bug here.

Wed, Apr 7, 8:28 PM · Core, BF Blender
Bastien Montagne (mont29) added a comment to T87262: Random freezes.

@Guillaume Pinchon (Tableuraz) please do not quote spammers, now I also have to nuke your comments ;)

Wed, Apr 7, 3:21 PM · BF Blender
Bastien Montagne (mont29) updated <SPAMMER> (vanessaaustin).
Wed, Apr 7, 3:20 PM
Bastien Montagne (mont29) added inline comments to D10855: LibOverride: Initial dedicated view in the Outliner..
Wed, Apr 7, 11:57 AM
Bastien Montagne (mont29) updated the diff for D10855: LibOverride: Initial dedicated view in the Outliner..

Updated from review, thanks.

Wed, Apr 7, 11:57 AM
Bastien Montagne (mont29) added projects to D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections: BF Blender, Core, Dependency Graph.
Wed, Apr 7, 11:07 AM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) requested review of D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Wed, Apr 7, 11:03 AM · Dependency Graph, Core, BF Blender
Bastien Montagne (mont29) added a revision to T85752: Collection Instance Crash when instancing collections with disabled subcollections: D10907: Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections.
Wed, Apr 7, 11:03 AM · Dependency Graph, BF Blender (2.93), Core

Apr 6 2021

Bastien Montagne (mont29) abandoned D10860: WIP: Fix T85752: Collection Instance Crash when instancing collections with view-layer excluded subcollections..

Scratch that, while it does fix the issue, it is not a proper way nor is it addressing the root of the problem.

Apr 6 2021, 10:57 AM

Apr 1 2021

Martin Malmqvist (Malmqvist) awarded T73318: Library overrides a Love token.
Apr 1 2021, 8:16 PM · Core, BF Blender (2.93)

Mar 30 2021

Bastien Montagne (mont29) added a comment to D10860: WIP: Fix T85752: Collection Instance Crash when instancing collections with view-layer excluded subcollections..

@Sergey Sharybin (sergey) would not mind getting your advice on that, even though i don't think this is enough/fully fixing all possible issues there?

Mar 30 2021, 2:26 PM
Bastien Montagne (mont29) added a revision to T85752: Collection Instance Crash when instancing collections with disabled subcollections: D10860: WIP: Fix T85752: Collection Instance Crash when instancing collections with view-layer excluded subcollections..
Mar 30 2021, 2:25 PM · Dependency Graph, BF Blender (2.93), Core
Bastien Montagne (mont29) requested review of D10860: WIP: Fix T85752: Collection Instance Crash when instancing collections with view-layer excluded subcollections..
Mar 30 2021, 2:25 PM
Bastien Montagne (mont29) committed rB05fa5ca337eb: Cleanup: Typo in comment. (authored by Bastien Montagne (mont29)).
Cleanup: Typo in comment.
Mar 30 2021, 12:15 PM