- User Since
- Oct 7 2010, 12:19 PM (552 w, 3 h)
Tue, May 4
Mon, May 3
Hrmmm.... This smells like some ID being added or changed without proper tagging, or without proper call to collections/layercollections update functions (guys like BKE_main_collection_sync_remap). Or maybe a missing object cache clearing (BKE_collection_object_cache_free)?
Indeed TIP_ is mandatory here. Besides picky note about UI messages style, looks fine.
@Sergey Sharybin (sergey) in that case I would say yes.
Fri, Apr 30
LGTM, don't see any reason no to check that here indeed.
Mon, Apr 26
AFAIK Z-up is the convention when there is no way to get a proper normal from vco...
LGTM from quick look. :)
Am not sure I understand that 'fix'? How having a NULL normal is ever a good thing? I would rather fix the code using vco to detect zero case and generate that dummy 'Z-up' normal then?
Thanks (but please avoid assigning patches to people yourself in the future).
Fri, Apr 23
Thu, Apr 22
Patch looks good to me now...
Wed, Apr 21
Mon, Apr 19
Once again I think we should rather seriously spend time on T61209: Always write unused IDs on save, this would also solve that case imho.
Fri, Apr 16
Looks mostly fine, mainly missing a sub-version bump.
Wed, Apr 14
@Demeter Dzadik (Mets) would keep both for now, while related they are not entirely the same. We can re-iterate on designs and such once we actually start working on those.
Also related to T61209: Always write unused IDs on save
Tue, Apr 13
Mon, Apr 12
Sat, Apr 10
Fri, Apr 9
For the records, proposal LGTM... Personnaly I would be very conservative about what module we switch to type hinting though.
In general proposal LGTM.
Thu, Apr 8
To be clear, what I call overhead here is:
- Adding extra function to API only to deal with const/non-const cases (this remains C code for now, this is fairly annoying imho).
- Adding hard-to-decipher things like * const *;
Minor updates from review.
@Sybren A. Stüvel (sybren) please do not add whole projects as reviewers (tagging is fine of course). This only adds lots of noise for many people.
Committed as listed above.
Wed, Apr 7
Thanks for the report, but this is absolutely not a bug, everything is working as expected.
NodeTrees are definitely not supported currently by overrides, and are indeed a known TODO, no bug here.
@Guillaume Pinchon (Tableuraz) please do not quote spammers, now I also have to nuke your comments ;)
Updated from review, thanks.
Apr 6 2021
Scratch that, while it does fix the issue, it is not a proper way nor is it addressing the root of the problem.
Apr 1 2021
Mar 30 2021
@Sergey Sharybin (sergey) would not mind getting your advice on that, even though i don't think this is enough/fully fixing all possible issues there?