Let's go with adding these into the Group category.

Mockup of the blocking popup based on Brecht's suggestions (and a friendly nudge for this to be tackled for the LTS :)

Another great addition! Thanks for working on it @Fabian Schempp (fabian_schempp) !

Hey @mathieu menuet (bliblubli) o/! Any plans to update this patch to master?
Thanks!

Posting this mockup of how a more advanced version of this node would be. (shared it on blender.chat but keeping it here for later reference)

Great! Thanks Nathan!

Initial design proposal.

+1 ! Thanks @Harley Acheson (harley)!

I agree with Dalai here that they should be under Input and Output respectively.

Snapshot of how it looks currently at the beginning of the month:

In D10348#259896, @Harley Acheson (harley) wrote:

I doubt your intention is that nodes in regular state and when minimized would look this different.

In D10348#259889, @Scott Ramsay (smramsay) wrote:

Zooming out though, it completely falls apart

Looking nice! Only issue I found is when zoomed out the dots look rather large, maybe as we zoom out they could blend to the background color so they disappear.

In D10348#259887, @Harley Acheson (harley) wrote:

A complex node tree is a jumble of noodle wires, so adding a horizontal rule of similar width and color might add to the visual confusion, not reduce it. I do agree they look "nicer", cleaner, and more modern-looking to my eye. But I worry that there will be loss of visual clarity using a design language that mixes two uses for lines like this.

Could it be that this patch makes sockets lose anti-alising? I'm testing the zip bundle patch from D10067

The overall experience is super nice! I've got two comments:

Just compiled the bundled patches zip a couple hours ago. Does anybody else have this issue where disconnecting an input noodle drags the output?

To update on this: after discussion with the team thinking of different options, the idea is to go with a dedicated node for visibility Is Viewport. A bit verbose but in the long run these will be the building blocks of more complex trees.

Great node!

Great improvement! Visually it's a +1 from me, code-wise I leave it to you @Hans Goudey (HooglyBoogly)

Nice find, much nicer. Thanks!

+1!

+999… Thank you for working on this!

The last iteration is much more clear and conservative in a way that preserves the Ctrl+L shortcut relevant. +1!

Just a note that screenshots of most nodes need to be re-taken since the color of the sockets for float and shader have changed, as well as the category for Shader nodes.

In T82689#1092905, @Brecht Van Lommel (brecht) wrote:

I also changed the shader sockets and node headers back to green now in rB09fe0e8aa94c: Nodes: use green color again for shader sockets and shader category, since we're in bcon3 and this was still not in a good state in my opinion.

In T82689#1091189, @Brecht Van Lommel (brecht) wrote:

Is there an intent to address the issues I raised for 2.92? If not I propose we revert this change for the most part, as to me this looks like a regression for shading nodes at least.

Looks good to me! (based on the screenshots by @James Monteath (jmonteath), can't test the patch)

Off-topic but please provide an image of before and after changes when submitting UI diffs. D9683 is a good example. Makes reviewing faster without having to compile if the changes are purely aesthetic.

Just played with it, this is awesome!

Could you please mention in the commit log and/or link to the changes on GitHub?

In D7946#233894, @Ilya Shurupov (Hto-Ya) wrote:

@Hans Goudey (HooglyBoogly), @Pablo Vazquez (pablovazquez), do You think it'll be nice to have a little bit of near-edge snapping by default?

This should be considered a fix and make it to 2.92, since the current behavior of Ctrl+G in master is pretty useless.

Moving New Collection and Scene Collection was a design decision.

Looking great! Thanks for working on this!

After some discussion on #user-interface-module, it turns out Blender is already inconsistent with this anyway.

Looks so much better!

GPencil is correct, the other modes should swap from a Value Slider to a Number Slider.

Looks much nicer! +1 on the aesthetic side.

Missed this during the review, but we should consider renaming this node from Rotate Points to Point Rotate. Following the naming convention of other Point nodes as well as other Rotate nodes.

Thanks! <3

Isn't this now fixed by f193b1afb313?

Looks good from the UI side!

Indeed the order should be shuffled according to hierarchy.

1. Source
2. Type
3. Pickers

If you reset the theme, the Shader category color matches the socket color. The commit should've had versioning code to change this automatically, this will be tackled soon.

+1