Page MenuHome

Patrick Mours (pmoursnv)
User

Projects

User Details

User Since
Feb 21 2019, 1:26 PM (33 w, 5 d)

Recent Activity

Yesterday

Patrick Mours (pmoursnv) updated the diff for D6068: Cycles: Fix out of memory when rendering some scenes with OptiX that work with CUDA.

Added some asserts to be safe

Tue, Oct 15, 2:37 PM
Patrick Mours (pmoursnv) added a comment to T70838: [Segfault<>BKE_object_is_visible_in_viewport] when rendering the default cube in cycles, despite viewport rendering works fine..

Can confirm too. Happens because the old code in visible_in_viewport_get_func checked whether b_v3d is NULL before accessing it, but the new code doesn't (and the viewport can be NULL).

Tue, Oct 15, 2:28 PM · Cycles, BF Blender
Patrick Mours (pmoursnv) added a comment to rB280d6b03a7a9: Fix T70670: Hidden collections are still rendered by Cycles in the Viewport.
Tue, Oct 15, 2:26 PM
Patrick Mours (pmoursnv) created D6068: Cycles: Fix out of memory when rendering some scenes with OptiX that work with CUDA.
Tue, Oct 15, 12:29 PM

Wed, Oct 2

Patrick Mours (pmoursnv) committed rB0091b84df028: Fix T70268: Render failures with Vector pass active with OptiX in Cycles (authored by Patrick Mours (pmoursnv)).
Fix T70268: Render failures with Vector pass active with OptiX in Cycles
Wed, Oct 2, 1:24 PM
Patrick Mours (pmoursnv) closed T70268: Optix crash with Vector pass as Resolved by committing rB0091b84df028: Fix T70268: Render failures with Vector pass active with OptiX in Cycles.
Wed, Oct 2, 1:24 PM · BF Blender
Patrick Mours (pmoursnv) closed D5968: Fix T70268: Render failures with Vector pass active with OptiX in Cycles.
Wed, Oct 2, 1:24 PM
Patrick Mours (pmoursnv) created D5968: Fix T70268: Render failures with Vector pass active with OptiX in Cycles.
Wed, Oct 2, 12:08 PM

Tue, Oct 1

Patrick Mours (pmoursnv) closed T69801: Cycles Optix tasks for 2.81 as Resolved.
Tue, Oct 1, 8:04 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) committed rB8dd9172aa23b: Fix "motion_blur" tests with OptiX in Cycles (authored by Patrick Mours (pmoursnv)).
Fix "motion_blur" tests with OptiX in Cycles
Tue, Oct 1, 8:04 PM
Patrick Mours (pmoursnv) closed D5961: Cycles: Fix "motion_blur" tests with OptiX.
Tue, Oct 1, 8:03 PM
Patrick Mours (pmoursnv) updated the summary of D5961: Cycles: Fix "motion_blur" tests with OptiX.
Tue, Oct 1, 7:46 PM
Patrick Mours (pmoursnv) created D5961: Cycles: Fix "motion_blur" tests with OptiX.
Tue, Oct 1, 7:45 PM

Mon, Sep 30

Patrick Mours (pmoursnv) updated the task description for T69801: Cycles Optix tasks for 2.81.
Mon, Sep 30, 3:39 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) committed rBb89a1687ce89: Fix "denoise_animation" tests with OptiX in Cycles (authored by Patrick Mours (pmoursnv)).
Fix "denoise_animation" tests with OptiX in Cycles
Mon, Sep 30, 3:38 PM
Patrick Mours (pmoursnv) closed D5946: Cycles: Fix "denoise_animation" tests with OptiX.
Mon, Sep 30, 3:38 PM
Patrick Mours (pmoursnv) updated the summary of D5946: Cycles: Fix "denoise_animation" tests with OptiX.
Mon, Sep 30, 2:47 PM
Patrick Mours (pmoursnv) created D5946: Cycles: Fix "denoise_animation" tests with OptiX.
Mon, Sep 30, 2:45 PM
Patrick Mours (pmoursnv) updated the task description for T69801: Cycles Optix tasks for 2.81.
Mon, Sep 30, 2:08 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) committed rB91f6aa6a5759: Fix memory leak after using OptiX in Cycles (authored by Patrick Mours (pmoursnv)).
Fix memory leak after using OptiX in Cycles
Mon, Sep 30, 2:06 PM
Patrick Mours (pmoursnv) closed D5944: Cycles: Fix memory leak after using OptiX.
Mon, Sep 30, 2:06 PM
Patrick Mours (pmoursnv) created D5944: Cycles: Fix memory leak after using OptiX.
Mon, Sep 30, 12:15 PM

Thu, Sep 26

Patrick Mours (pmoursnv) added a comment to T70268: Optix crash with Vector pass.

Yes, will take a look soon.

Thu, Sep 26, 3:53 PM · BF Blender

Wed, Sep 25

Patrick Mours (pmoursnv) committed rBa1e40087c5ce: Cycles: Fix undefined behavior which can causes crashes with a misaligned… (authored by Patrick Mours (pmoursnv)).
Cycles: Fix undefined behavior which can causes crashes with a misaligned…
Wed, Sep 25, 2:25 PM
Patrick Mours (pmoursnv) closed D5883: Cycles: Fix undefined behavior which can causes crashes with a misaligned address error.
Wed, Sep 25, 2:25 PM
Paul R (intracube) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Wed, Sep 25, 10:47 AM · BF Blender (2.81), Cycles

Tue, Sep 24

Patrick Mours (pmoursnv) added a comment to D5883: Cycles: Fix undefined behavior which can causes crashes with a misaligned address error.

Forgot to run kernel_types.h through clang-format again.

Tue, Sep 24, 5:55 PM
Patrick Mours (pmoursnv) added a comment to D5883: Cycles: Fix undefined behavior which can causes crashes with a misaligned address error.

Added comment explaining the alignment change

Tue, Sep 24, 1:18 PM
Patrick Mours (pmoursnv) retitled D5883: Cycles: Fix undefined behavior which can causes crashes with a misaligned address error from Fix undefined behavior which causes Cycles to crash with a misaligned address error with newer CUDA toolkits due to a compiler optimization to Cycles: Fix undefined behavior which can causes crashes with a misaligned address error.
Tue, Sep 24, 11:57 AM
Patrick Mours (pmoursnv) created D5883: Cycles: Fix undefined behavior which can causes crashes with a misaligned address error.
Tue, Sep 24, 11:55 AM

Sep 13 2019

Metin Seven (MetinSeven) awarded rBa2b52dc5716a: Cycles: add Optix device backend a Love token.
Sep 13 2019, 9:03 PM
Way awarded rBa2b52dc5716a: Cycles: add Optix device backend a Yellow Medal token.
Sep 13 2019, 8:20 PM
Marco (nacioss) awarded rBa2b52dc5716a: Cycles: add Optix device backend a Love token.
Sep 13 2019, 4:19 PM

Sep 11 2019

derek barker (lordodin) awarded D5363: Add OptiX device implementation to Cycles a Y So Serious token.
Sep 11 2019, 12:04 PM · BF Blender (2.81), Cycles

Sep 7 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Added warning message to OptiX device selection and fixed an invalid assert on the GPU

Sep 7 2019, 11:58 AM · BF Blender (2.81), Cycles

Aug 27 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

 - Revert changes to AO code

  • Add missing "ccl_device_noinline_cpu" definition for OptiX
  • Hide branched path tracing and baking options in UI when OptiX is active
Aug 27 2019, 4:03 PM · BF Blender (2.81), Cycles

Aug 26 2019

B (bnzs) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Aug 26 2019, 8:49 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Did another run of performance tests and it looks like the AO change is performing worse in some scenes under OptiX now too and does no longer give a noticeable speedup in others compared to when I first implemented it (on an older OptiX version). So it's likely safe to skip it and leave things how they currently are.

Aug 26 2019, 7:15 PM · BF Blender (2.81), Cycles

Aug 23 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Fixed some missing changes to "decode_node_uchar4" calls after rebase

Aug 23 2019, 4:10 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Rebase against master and fix merge conflicts

Aug 23 2019, 1:54 PM · BF Blender (2.81), Cycles

Aug 21 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Cleaned up some unnecessary changes

Aug 21 2019, 5:59 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

@Michael March (cowmix): Yes, drivers >= 435.80 will work.

Aug 21 2019, 5:03 PM · BF Blender (2.81), Cycles

Aug 16 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Fixed modified branched connect to light functions

Aug 16 2019, 4:28 PM · BF Blender (2.81), Cycles

Aug 14 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Fixed performance regression that caused BMW benchmark scene to only be 1.1x faster instead of 1.6x

Aug 14 2019, 5:04 PM · BF Blender (2.81), Cycles

Aug 12 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

 - Fixed a compile error when building with Embree (thanks @Alex Fuller (mistaed))

  • Fixed an OptiX warning during pipeline creation
  • Reduced number of used attributes in OptiX pipeline to two
Aug 12 2019, 6:15 PM · BF Blender (2.81), Cycles

Aug 9 2019

Andrei Toma (tomitz) awarded D5363: Add OptiX device implementation to Cycles a Cup of Joe token.
Aug 9 2019, 8:00 AM · BF Blender (2.81), Cycles

Aug 8 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Fixes some of the formatting issues that were brought up. The #ifdefs in geom_subd_triangle.h were missing on accident.

Aug 8 2019, 3:01 PM · BF Blender (2.81), Cycles

Aug 7 2019

Stefan Z Camilleri (szc001) awarded D5363: Add OptiX device implementation to Cycles a Like token.
Aug 7 2019, 8:49 PM · BF Blender (2.81), Cycles
Alex Fuller (mistaed) awarded D5363: Add OptiX device implementation to Cycles a 100 token.
Aug 7 2019, 2:07 AM · BF Blender (2.81), Cycles

Aug 6 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Laid groundwork for baking support

Aug 6 2019, 2:41 PM · BF Blender (2.81), Cycles

Aug 5 2019

Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Sounds good!
Just a note regarding the CUDA backend: I don't think this can fully replace that one, since OptiX only works on Maxwell and up, with full performance only on Turing, so the CUDA backend would still be necessary to support older cards.

Aug 5 2019, 6:50 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Rebase against master and fix merge conflicts

Aug 5 2019, 2:17 PM · BF Blender (2.81), Cycles

Aug 3 2019

Alessandro (MarioKart7z) awarded D5363: Add OptiX device implementation to Cycles a 100 token.
Aug 3 2019, 12:30 PM · BF Blender (2.81), Cycles

Aug 2 2019

Camilo Moreno (FreakNoizer) awarded D5363: Add OptiX device implementation to Cycles a Like token.
Aug 2 2019, 9:30 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

CPU + GPU doesn't currently work with this because OptiX manages its own BVH format, but Cycles only builds a single BVH for everything (with CPU + CUDA this is BVH2 for example). The CPU clearly cannot make use of the OptiX BVH though (since that one is designed for RT Cores and not usable from the outside). So Cycles would have to be extended to allow building and using multiple BVHs simultaneously, which was out of scope for this initial implementation (is something to keep in mind for the future though).

Aug 2 2019, 3:59 PM · BF Blender (2.81), Cycles

Aug 1 2019

Bartosz Moniewski (monio) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Aug 1 2019, 3:50 PM · BF Blender (2.81), Cycles
Leonardo Marini (Bamarin) awarded D5363: Add OptiX device implementation to Cycles a 100 token.
Aug 1 2019, 2:05 PM · BF Blender (2.81), Cycles

Jul 31 2019

dorian (helloidonthaveanyideaformyusername) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 31 2019, 3:52 PM · BF Blender (2.81), Cycles

Jul 30 2019

Joseph Brandenburg (TheAngerSpecialist) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 30 2019, 10:32 PM · BF Blender (2.81), Cycles
Christina McKay (CMC) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 30 2019, 10:07 PM · BF Blender (2.81), Cycles
swann (slumber) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 30 2019, 9:41 AM · BF Blender (2.81), Cycles

Jul 29 2019

Zino Guerr (Zino) awarded D5363: Add OptiX device implementation to Cycles a Orange Medal token.
Jul 29 2019, 7:34 PM · BF Blender (2.81), Cycles
Antti Tikka (symstract) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 6:54 PM · BF Blender (2.81), Cycles
Eitan (EitanSomething) awarded D5363: Add OptiX device implementation to Cycles a Burninate token.
Jul 29 2019, 6:44 PM · BF Blender (2.81), Cycles
Way awarded D5363: Add OptiX device implementation to Cycles a Party Time token.
Jul 29 2019, 6:39 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) added a comment to D5363: Add OptiX device implementation to Cycles.

Does it leverage NVLink memory addition to have 16Gb or 22Gb if you use 2xRTX cards?

It doesn't currently. Multi-GPU is implemented via the existing MULTI-device in Cycles and just broadcasts the BVH to all GPUs (so each gets a copy).
Adding proper NVLink support would be more suited for a separate change independent of this one I think.

Jul 29 2019, 6:38 PM · BF Blender (2.81), Cycles
Daniel Santana (dgsantana) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 6:07 PM · BF Blender (2.81), Cycles
Emir Sinan Gürlek (filibis) awarded D5363: Add OptiX device implementation to Cycles a The World Burns token.
Jul 29 2019, 6:04 PM · BF Blender (2.81), Cycles
Jason Clarke (jtheninja) awarded D5363: Add OptiX device implementation to Cycles a Burninate token.
Jul 29 2019, 5:52 PM · BF Blender (2.81), Cycles
Antonio Vazquez (antoniov) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 5:12 PM · BF Blender (2.81), Cycles
Daniel Salazar (zanqdo) awarded D5363: Add OptiX device implementation to Cycles a Burninate token.
Jul 29 2019, 5:11 PM · BF Blender (2.81), Cycles
Juan Gea (juang3d) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 5:03 PM · BF Blender (2.81), Cycles
Duarte Farrajota Ramos (duarteframos) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 4:09 PM · BF Blender (2.81), Cycles
William Reynish (billreynish) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Jul 29 2019, 3:04 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) updated the summary of D5363: Add OptiX device implementation to Cycles.
Jul 29 2019, 2:58 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) updated the summary of D5363: Add OptiX device implementation to Cycles.
Jul 29 2019, 2:50 PM · BF Blender (2.81), Cycles
Patrick Mours (pmoursnv) created D5363: Add OptiX device implementation to Cycles.
Jul 29 2019, 2:49 PM · BF Blender (2.81), Cycles