Page MenuHome

Patrick Mours (pmoursnv)
User

Projects (8)

User Details

User Since
Feb 21 2019, 1:26 PM (115 w, 1 d)

Recent Activity

Wed, Apr 28

Patrick Mours (pmoursnv) added a comment to D11061: Fix "Unknown CPU" on Apple Silicon.

I understand what it does, but I'm not familiar with macOS, so can't rate the solution. Semantically it looks good to me. So if it works I see no problem with committing this.

Wed, Apr 28, 5:33 PM

Mon, Apr 26

Patrick Mours (pmoursnv) committed rB94960250b539: Cycles: Fix build with OptiX 7.3 SDK (authored by Patrick Mours (pmoursnv)).
Cycles: Fix build with OptiX 7.3 SDK
Mon, Apr 26, 2:56 PM

Wed, Apr 21

Patrick Mours (pmoursnv) added a comment to T85977: NVidia: Random crashes in 'DrvPresentBuffers'.

@Brecht Van Lommel (brecht) @Clément Foucault (fclem) Still haven't reproduced it exactly. But based on the stack trace and exception info it looks like the problem is a broken VBO binding. The driver is trying to interpret a vertex attribute offset (that Blender set up via "glVertexAttribPointer" previously) as a CPU pointer, rather than a VBO offset, which happens if no valid VBO is bound (as defined in the OpenGL spec).
I can force pretty much the same crash to happen if I replace glBindBuffer(GL_ARRAY_BUFFER, vbo_id_); with glBindBuffer(GL_ARRAY_BUFFER, 0xdeadbeef); in source\blender\gpu\opengl\gl_vertex_buffer.cc. This would indicate that at some point for some unknown reason a VBO ID breaks in Blender leading to the crash everybody above is experiencing. Maybe Blender tries to render a deleted GLVertBuf object (and therefore accessing bogus data and binding a broken VBO ID)?

Wed, Apr 21, 2:50 PM · EEVEE & Viewport, BF Blender
Alaska (Alaska) awarded rB847579b42250: Add support for building on Linux aarch64 a Love token.
Wed, Apr 21, 12:52 AM

Tue, Apr 20

Patrick Mours (pmoursnv) committed rB847579b42250: Add support for building on Linux aarch64 (authored by Patrick Mours (pmoursnv)).
Add support for building on Linux aarch64
Tue, Apr 20, 6:47 PM
Patrick Mours (pmoursnv) closed D10958: Add support for building on Linux aarch64.
Tue, Apr 20, 6:47 PM · Platforms, Builds, Tests & Devices, Platform: Linux
Patrick Mours (pmoursnv) updated the diff for D10958: Add support for building on Linux aarch64.

Replaced "BLENDER_CMAKE_SYSTEM_PROCESSOR" with a "BLENDER_PLATFORM_ARM" CMake variable and simplified some checks

Tue, Apr 20, 3:05 PM · Platforms, Builds, Tests & Devices, Platform: Linux

Tue, Apr 13

Patrick Mours (pmoursnv) committed rB7cbd66d42fb3: Cycles: Initialize all OptiX structs to zero before use (authored by Patrick Mours (pmoursnv)).
Cycles: Initialize all OptiX structs to zero before use
Tue, Apr 13, 1:56 PM
Patrick Mours (pmoursnv) updated the summary of D10958: Add support for building on Linux aarch64.
Tue, Apr 13, 1:33 PM · Platforms, Builds, Tests & Devices, Platform: Linux
Patrick Mours (pmoursnv) updated the diff for D10958: Add support for building on Linux aarch64.

@Hans Goudey (HooglyBoogly) Thanks! Rebased.

Tue, Apr 13, 1:32 PM · Platforms, Builds, Tests & Devices, Platform: Linux

Mon, Apr 12

Patrick Mours (pmoursnv) added projects to D10958: Add support for building on Linux aarch64: Platform: Linux, Platforms, Builds, Tests & Devices.
Mon, Apr 12, 5:00 PM · Platforms, Builds, Tests & Devices, Platform: Linux
Patrick Mours (pmoursnv) requested review of D10958: Add support for building on Linux aarch64.
Mon, Apr 12, 5:00 PM · Platforms, Builds, Tests & Devices, Platform: Linux

Mar 30 2021

Patrick Mours (pmoursnv) committed rBf1fe42d912f0: Cycles: Do not allocate tile buffers on all devices when peer memory is active… (authored by Patrick Mours (pmoursnv)).
Cycles: Do not allocate tile buffers on all devices when peer memory is active…
Mar 30 2021, 2:05 PM
Patrick Mours (pmoursnv) closed D10858: Cycles: Do not allocate tile buffers on all devices when peer memory is active and denoising is not.
Mar 30 2021, 2:05 PM
Patrick Mours (pmoursnv) requested review of D10858: Cycles: Do not allocate tile buffers on all devices when peer memory is active and denoising is not.
Mar 30 2021, 1:02 PM

Mar 11 2021

Patrick Mours (pmoursnv) closed T85985: Memory allocation probelms as Resolved.
Mar 11 2021, 2:15 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) committed rBf4f8b6dde32b: Cycles: Change device-only memory to actually only allocate on the device (authored by Patrick Mours (pmoursnv)).
Cycles: Change device-only memory to actually only allocate on the device
Mar 11 2021, 2:14 PM
Patrick Mours (pmoursnv) closed D10535: Cycles: Change device-only memory to actually only allocate on the device.
Mar 11 2021, 2:14 PM · Render & Cycles

Mar 3 2021

Patrick Mours (pmoursnv) updated the diff for D10535: Cycles: Change device-only memory to actually only allocate on the device.

Fixed incorrect parameter to some device_only_memory instances after previous change.

Mar 3 2021, 2:50 PM · Render & Cycles
Patrick Mours (pmoursnv) updated the diff for D10535: Cycles: Change device-only memory to actually only allocate on the device.

Implemented allow_host_memory_fallback parameter (I agree, this is nicer) and fixed the high peak memory usage during OptiX acceleration structure building by limiting the actual OptiX acceleration structure building to a single thread at a time (using a mutex lock in build_optix_bvh).
This solved the problem in my tests, while still keeping the rest of the bottom-level BVH build running in parallel, which is noticeable faster in some scenes compared to just running it serialized (presumably because of the curve conversion loops).
With this peak memory usage did not exceed the memory usage during rendering in the splash screen scene, so was still able to render it successfully on a smaller GPU where it failed before. At the same time loading speed did not regress in a perceptible fashion.

Mar 3 2021, 2:46 PM · Render & Cycles

Mar 2 2021

Aditia A. Pratama (aditiapratama) awarded rBbfb6fce6594e: Cycles: Add CPU+GPU rendering support with OptiX a Love token.
Mar 2 2021, 4:39 PM

Feb 25 2021

Patrick Mours (pmoursnv) updated the summary of D10535: Cycles: Change device-only memory to actually only allocate on the device.
Feb 25 2021, 5:16 PM · Render & Cycles
Patrick Mours (pmoursnv) requested review of D10535: Cycles: Change device-only memory to actually only allocate on the device.
Feb 25 2021, 5:13 PM · Render & Cycles

Feb 23 2021

Marco (nacioss) awarded rBb2e1b13abde7: Cycles: Add option to change input passes for viewport denoising a Like token.
Feb 23 2021, 12:15 PM
Patrick Mours (pmoursnv) committed rBb2e1b13abde7: Cycles: Add option to change input passes for viewport denoising (authored by Patrick Mours (pmoursnv)).
Cycles: Add option to change input passes for viewport denoising
Feb 23 2021, 11:45 AM
Patrick Mours (pmoursnv) closed D10404: Cycles: Add option to change input passes for viewport denoising.
Feb 23 2021, 11:45 AM · Render & Cycles

Feb 22 2021

YAFU (YAFU) awarded D10404: Cycles: Add option to change input passes for viewport denoising a Like token.
Feb 22 2021, 7:50 PM · Render & Cycles
Patrick Mours (pmoursnv) updated the diff for D10404: Cycles: Add option to change input passes for viewport denoising.

Added separator between render and viewport denoising settings and rebased on master

Feb 22 2021, 7:10 PM · Render & Cycles

Feb 19 2021

Patrick Mours (pmoursnv) added a comment to D10404: Cycles: Add option to change input passes for viewport denoising.

How about this (explicitly stating that where the other settings are)?:

Feb 19 2021, 1:11 PM · Render & Cycles
Dspazio (Dspazio) awarded rB612b83bbd183: Cycles: Enable baking panel in OptiX and redirect those requests to CUDA for now a Like token.
Feb 19 2021, 8:58 AM

Feb 17 2021

Patrick Mours (pmoursnv) added a comment to T85736: Incorrect volume rendering when enabling NanoVDB..

This is happening because lookup into the NanoVDB data structure is not clamped, whereas dense texture lookups are (see EXTENSION_CLIP, which is the default for images, including volumes). And since either linear or cubic interpolation is always enabled (you can't enable closest interpolation in Cycles ... which is rather odd and should probably be addressed at some point too), you get an interpolated result in the neighboring voxels. So I actually think the current behavior with NanoVDB is more correct?.

Feb 17 2021, 7:22 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) added a comment to D10441: Fix T85440: crash with displacement shaders and updating geometry in viewport.

Based on my understanding of the problem this makes sense and the code looks correct. Have not tested it yet though.

Feb 17 2021, 1:58 PM

Feb 16 2021

Maged afra (Maged_afra) awarded D10404: Cycles: Add option to change input passes for viewport denoising a Like token.
Feb 16 2021, 12:48 AM · Render & Cycles

Feb 12 2021

Wo!262 (wo262) awarded D10404: Cycles: Add option to change input passes for viewport denoising a Love token.
Feb 12 2021, 5:45 PM · Render & Cycles
Patrick Mours (pmoursnv) updated the summary of D10404: Cycles: Add option to change input passes for viewport denoising.
Feb 12 2021, 3:04 PM · Render & Cycles
Patrick Mours (pmoursnv) updated the summary of D10404: Cycles: Add option to change input passes for viewport denoising.
Feb 12 2021, 1:51 PM · Render & Cycles
Patrick Mours (pmoursnv) requested review of D10404: Cycles: Add option to change input passes for viewport denoising.
Feb 12 2021, 1:50 PM · Render & Cycles

Feb 8 2021

Patrick Mours (pmoursnv) added a comment to T74883: Cycles crashes with Windows GPU Scheduling and 2 or more GPUs [driver bug].

Is still being worked on, turns out to be a more complex problem, so no fix is available yet. I continue to have this on my radar though, so will update when that changes.

Feb 8 2021, 1:51 PM · Render & Cycles, Cycles, BF Blender

Jan 29 2021

Patrick Mours (pmoursnv) closed T85148: Viewport Optix glitches as Resolved.
Jan 29 2021, 1:42 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) committed rBb2e00e8f8e03: Merge branch 'blender-v2.92-release' (authored by Patrick Mours (pmoursnv)).
Merge branch 'blender-v2.92-release'
Jan 29 2021, 1:36 PM
Patrick Mours (pmoursnv) committed rB9f89166b52b1: Fix T85148: OptiX viewport denoising regression (authored by Patrick Mours (pmoursnv)).
Fix T85148: OptiX viewport denoising regression
Jan 29 2021, 1:36 PM

Jan 28 2021

Patrick Mours (pmoursnv) added a comment to T85023: Cycles OptiX portal area light toggle error.

@Brecht Van Lommel (brecht) I don't see requested_features.use_background_light changing when toggling portal. The problem appears to be that kernels are reloaded before the background light is enabled again (which happens in LightManager::test_enabled_lights, which is called after the kernel reload):

Jan 28 2021, 2:25 PM · Cycles, Render & Cycles, BF Blender

Jan 27 2021

Patrick Mours (pmoursnv) closed T84734: Denoising Data with large tiles causes instant crash and exit. as Resolved.
Jan 27 2021, 3:31 PM · BF Blender (2.92), Render & Cycles
Patrick Mours (pmoursnv) committed rB9b80291412fe: Merge branch 'blender-v2.92-release' (authored by Patrick Mours (pmoursnv)).
Merge branch 'blender-v2.92-release'
Jan 27 2021, 3:30 PM
Patrick Mours (pmoursnv) closed D10219: Fix T85089: Cycles: Prevent cuda_mem_map_mutex from being locked multiple times.
Jan 27 2021, 3:29 PM · Cycles, Render & Cycles
Patrick Mours (pmoursnv) committed rB4fbeb3e6be3e: Fix T85089: Crash when rendering scene that does not fit into GPU memory with… (authored by James Horsley (mmdanggg2)).
Fix T85089: Crash when rendering scene that does not fit into GPU memory with…
Jan 27 2021, 3:29 PM
Patrick Mours (pmoursnv) added a comment to T85078: OptiX GPU rendering artifacts with large plane.

Yeah, things get funky with OptiX when intersecting objects with huge scaling. There's another report on this here too: T81566.
To solve this we could introduce some logic that detects and skips self-intersections when they happen (e.g. by keeping track of the last hit and checking if the new hit point is behind that based on the ray direction) or something along those lines.

Jan 27 2021, 1:42 PM · BF Blender, Cycles, Render & Cycles
Patrick Mours (pmoursnv) accepted D10219: Fix T85089: Cycles: Prevent cuda_mem_map_mutex from being locked multiple times.

Looks good to me. My main concern with locking directly inside generic_free would have been the double lock when called from tex_free, but you addressed by unlocking before, so everything looks functional.
I'll do some more testing to be sure and commit later. Thank you for this!

Jan 27 2021, 1:28 PM · Cycles, Render & Cycles

Jan 25 2021

Büke Beyond (beyond) awarded D10023: Cycles: Add half precision float support to NanoVDB a Love token.
Jan 25 2021, 6:36 AM

Jan 22 2021

Patrick Mours (pmoursnv) added a comment to T84954: OptiX render engine on an RTX 3060TI producing erroneous shadows in full transparency..

This is expected behavior: There is a limit of 64 transparent hits supported for a single ray until it hits a light source (see SHADOW_STACK_MAX_HITS in Cycles source code) on the GPU. On the CPU it can dynamically allocate more memory to extend that range, and with CUDA there is a slow fallback implementation using a loop. In OptiX that fallback implementation is disabled for better general performance, so you can't do more than 64. We could enable the fallback there as well, but that would come at a performance hit even if no more than 64 hits are encountered, so decided against it for now.

Jan 22 2021, 4:03 PM · Render & Cycles, BF Blender

Jan 21 2021

Patrick Mours (pmoursnv) committed rBa92ebab5da3b: Windows: Add "--debug-cycles" argument to "blender_debug_gpu.bat" batch file (authored by Patrick Mours (pmoursnv)).
Windows: Add "--debug-cycles" argument to "blender_debug_gpu.bat" batch file
Jan 21 2021, 4:48 PM
Patrick Mours (pmoursnv) closed D10167: Windows: Add "--debug-cycles" argument to "blender_debug_gpu.bat" batch file.
Jan 21 2021, 4:48 PM
Patrick Mours (pmoursnv) requested review of D10167: Windows: Add "--debug-cycles" argument to "blender_debug_gpu.bat" batch file.
Jan 21 2021, 4:34 PM
Daniel Salazar (zanqdo) awarded rB4a09907eab2a: Fix T84049: Crash when using Cycles Progressive Refine with OptiX+CPU a Love token.
Jan 21 2021, 5:34 AM

Jan 20 2021

Patrick Mours (pmoursnv) awarded rB10d2cbfa369a: Fix T84872: OptiX GPU + CPU rendering uses branched path samples a Like token.
Jan 20 2021, 3:03 PM
Patrick Mours (pmoursnv) closed T84049: Blender crashes when using Cycles Progressive Refine in OptiX CPU + GPU mode as Resolved.
Jan 20 2021, 2:42 PM · BF Blender (2.92), Render & Cycles
Patrick Mours (pmoursnv) committed rBfc5f9a8ac900: Merge branch 'blender-v2.92-release' (authored by Patrick Mours (pmoursnv)).
Merge branch 'blender-v2.92-release'
Jan 20 2021, 2:41 PM
Patrick Mours (pmoursnv) committed rB4a09907eab2a: Fix T84049: Crash when using Cycles Progressive Refine with OptiX+CPU (authored by Patrick Mours (pmoursnv)).
Fix T84049: Crash when using Cycles Progressive Refine with OptiX+CPU
Jan 20 2021, 2:41 PM
Patrick Mours (pmoursnv) added a comment to T84049: Blender crashes when using Cycles Progressive Refine in OptiX CPU + GPU mode.

Yeah. I was finally able to reproduce this now and it's crashing because trying to write to a GPU address on the CPU. The tile stealing code steals the tile buffer for the GPU and moves the data there, but next time around the tile may be re-used on the CPU again (which only happens in progressive mode, otherwise tiles are deleted when done). The buffer is still lying on the GPU then though and never moved back, so is inaccessible to the CPU.

Jan 20 2021, 2:14 PM · BF Blender (2.92), Render & Cycles
Patrick Mours (pmoursnv) claimed T84872: Blender 2.92/2.93 Adaptive Sampling: Hybrid GPU+CPU (OptiX/RTX) is using hidden CPU Branched Path Tracing samples and not the Path Tracing samples.
Jan 20 2021, 1:34 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) added a revision to T84872: Blender 2.92/2.93 Adaptive Sampling: Hybrid GPU+CPU (OptiX/RTX) is using hidden CPU Branched Path Tracing samples and not the Path Tracing samples: D10159: Fix T84872: OptiX+CPU rendering is using hidden CPU Branched Path Tracing samples.
Jan 20 2021, 1:34 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) added a task to D10159: Fix T84872: OptiX+CPU rendering is using hidden CPU Branched Path Tracing samples: T84872: Blender 2.92/2.93 Adaptive Sampling: Hybrid GPU+CPU (OptiX/RTX) is using hidden CPU Branched Path Tracing samples and not the Path Tracing samples.
Jan 20 2021, 1:33 PM
Patrick Mours (pmoursnv) requested review of D10159: Fix T84872: OptiX+CPU rendering is using hidden CPU Branched Path Tracing samples.
Jan 20 2021, 1:33 PM

Jan 19 2021

Patrick Mours (pmoursnv) added a comment to D10143: Cycles: Fix usage of double floating precision in CNanoVDB.

@Max (maxim_d33) It's storing some matrices with double because the OpenVDB ones too are using double precision (so is done for the sake of preserving data, since it should be possible to do OpenVDB->NanoVDB->OpenVDB without data loss). But there are copies of the same matrices stored as float too, so the library user can decide which ones to use. In case of Cycles the single precision variants are used, so we really only need the double fields for correct data layout, but that could be achieved with some other placeholder type as well.

Jan 19 2021, 5:31 PM
Patrick Mours (pmoursnv) added a comment to D10143: Cycles: Fix usage of double floating precision in CNanoVDB.

Problem is that volumes will still be converted to the NanoVDB structure (in cycles/render/image_vdb.cpp), despite the OpenCL kernels then not being able to interpret the data when compiled without WITH_NANOVDB (and therefore just not rendering volumes altogether).
So to disable NanoVDB selectively we'd have to somehow pass along the information that NanoVDB is not supported up to the image loader.

Jan 19 2021, 3:27 PM

Jan 18 2021

YAFU (YAFU) awarded rB4fde594fda13: Fix T84650: CPU render + OptiX denoiser leaves empty tiles unprocessed a Like token.
Jan 18 2021, 6:11 PM
Patrick Mours (pmoursnv) closed T84650: CPU render + OptiX denoiser leaves empty tiles unprocessed (Blender from Master) as Resolved.
Jan 18 2021, 3:33 PM · BF Blender (2.92), Render & Cycles
Patrick Mours (pmoursnv) committed rBce0f212498c3: Merge branch 'blender-v2.92-release' (authored by Patrick Mours (pmoursnv)).
Merge branch 'blender-v2.92-release'
Jan 18 2021, 3:32 PM
Patrick Mours (pmoursnv) committed rB4fde594fda13: Fix T84650: CPU render + OptiX denoiser leaves empty tiles unprocessed (authored by Patrick Mours (pmoursnv)).
Fix T84650: CPU render + OptiX denoiser leaves empty tiles unprocessed
Jan 18 2021, 3:32 PM
Patrick Mours (pmoursnv) added a comment to T84650: CPU render + OptiX denoiser leaves empty tiles unprocessed (Blender from Master).

This is a bug introduced with the tile stealing implementation (rB517ff40b124bc9d1324ccf7561a59ac51bf86602). Since the OptiX denoiser runs on the GPU, the tile stealing code erroneously steals CPU tiles and moves them to the OptiX device. But in this configuration the OptiX device was only set up for denoising, not rendering, so it crashes. Will look for a fix.

Jan 18 2021, 2:19 PM · BF Blender (2.92), Render & Cycles

Jan 14 2021

Alaska (Alaska) awarded rBd259e7dcfbbd: Cycles: Increase instance limit for OptiX acceleration structure building a Love token.
Jan 14 2021, 11:12 PM
Raimund Klink (Raimund58) awarded rBd259e7dcfbbd: Cycles: Increase instance limit for OptiX acceleration structure building a Love token.
Jan 14 2021, 4:13 PM
Raimund Klink (Raimund58) awarded T81431: Optix corrupt render (incomplete scene translated) a Love token.
Jan 14 2021, 4:13 PM · BF Blender
Patrick Mours (pmoursnv) added a comment to D10023: Cycles: Add half precision float support to NanoVDB.

Yeah, it's on the upstream's TODO list. Probably would be nicer to wait for that to happen instead of doing it with a patch, so I'll put some pressure on it.

Jan 14 2021, 1:31 PM
Leon Suvorkov (kaban) awarded T83925: Crash when rendering with OptiX denoiser enabled a Party Time token.
Jan 14 2021, 8:21 AM · Render & Cycles, BF Blender

Jan 13 2021

Raimund Klink (Raimund58) awarded rB737bd549b6ee: Cycles: Add support for native OptiX curve primitive a Love token.
Jan 13 2021, 11:50 PM
Patrick Mours (pmoursnv) updated the diff for D9887: Cycles: pointcloud geometry type.

Restored some changes from Diff 32724 that were overwritten in Diff 32726 by accident

Jan 13 2021, 2:16 PM
Patrick Mours (pmoursnv) updated the diff for D9887: Cycles: pointcloud geometry type.

Fixed rendering with OptiX (added new point cloud intersection program, updated SBT + SBT offsets and fixed any-hit programs to handle point cloud primitives correctly)

Jan 13 2021, 2:05 PM

Jan 12 2021

Patrick Mours (pmoursnv) added a comment to D9887: Cycles: pointcloud geometry type.

@Brecht Van Lommel (brecht) On getting the intersection program correct:

Jan 12 2021, 6:00 PM
Brecht Van Lommel (brecht) awarded D10023: Cycles: Add half precision float support to NanoVDB a Love token.
Jan 12 2021, 12:04 PM

Jan 11 2021

Patrick Mours (pmoursnv) added a comment to T81431: Optix corrupt render (incomplete scene translated).

Yeah, I think it is better to go with 7.1 for now for increased compatibility with older drivers. It will indeed also activate support for the built-in curve primitive too, but that's still disabled by default and only enabled via a debug option, so does not change for the normal user.
There is currently no 7.2-specific feature implemented (apart from enabling validation mode when building debug kernels), so we wouldn't gain much updating all the way. I've played around with the new specialization feature, but couldn't really get useful performance benefits for Cycles out of it, so didn't add it. Maybe that changes at some point.

Jan 11 2021, 12:15 PM · BF Blender

Jan 10 2021

CRAZ (123ertyy) awarded rBbfb6fce6594e: Cycles: Add CPU+GPU rendering support with OptiX a Love token.
Jan 10 2021, 8:52 PM

Jan 8 2021

Patrick Mours (pmoursnv) updated subscribers of T81431: Optix corrupt render (incomplete scene translated).

@Brecht Van Lommel (brecht) Raising the instance limit to 134'217'727 requires building with the OptiX 7.1 SDK or higher, otherwise it continues to be capped at 8'388'607. It looks like buildbot is currently building with the OptiX 7.0 SDK still, so could be worth updating that now to support this.

Jan 8 2021, 1:57 PM · BF Blender
Patrick Mours (pmoursnv) committed rBc66f00dc26b0: Fix Cycles rendering with OptiX after instance limit increase when building… (authored by Patrick Mours (pmoursnv)).
Fix Cycles rendering with OptiX after instance limit increase when building…
Jan 8 2021, 1:54 PM
Metin Seven (MetinSeven) awarded rBd259e7dcfbbd: Cycles: Increase instance limit for OptiX acceleration structure building a Like token.
Jan 8 2021, 10:36 AM

Jan 7 2021

Patrick Mours (pmoursnv) closed T81431: Optix corrupt render (incomplete scene translated) as Resolved.
Jan 7 2021, 7:27 PM · BF Blender
Patrick Mours (pmoursnv) committed rBd259e7dcfbbd: Cycles: Increase instance limit for OptiX acceleration structure building (authored by Patrick Mours (pmoursnv)).
Cycles: Increase instance limit for OptiX acceleration structure building
Jan 7 2021, 7:27 PM
Patrick Mours (pmoursnv) claimed T81431: Optix corrupt render (incomplete scene translated).

This is happening because the current OptiX implementation in Blender only supports up to 8'388'607 instances, but this scene is using 10'012'160, which is why things fall apart for those instances that go beyond the limit.
It is technically possible to raise that limit to 134'217'727 now though, which solves the problem in this scene. I'll commit that later to fix it.

Jan 7 2021, 6:38 PM · BF Blender
Maged afra (Maged_afra) awarded rB612b83bbd183: Cycles: Enable baking panel in OptiX and redirect those requests to CUDA for now a Love token.
Jan 7 2021, 3:26 AM

Jan 6 2021

Patrick Mours (pmoursnv) requested review of D10023: Cycles: Add half precision float support to NanoVDB.
Jan 6 2021, 8:15 PM
Patrick Mours (pmoursnv) added a comment to T84449: Crash Hide Non Selected Viewport Shading Cycles CPU.

This fixed all occurrences of changing objects/geometry in the viewport causing a crash when rendering with either CPU or OptiX and this was one of those cases, so yes, should be fully fixed.

Jan 6 2021, 2:15 PM · BF Blender
Raimund Klink (Raimund58) awarded rB3373d14b1b05: Fix T83925: Crash when rendering on the CPU with OptiX denoiser enabled a Love token.
Jan 6 2021, 8:59 AM
Raimund Klink (Raimund58) awarded T83925: Crash when rendering with OptiX denoiser enabled a Love token.
Jan 6 2021, 8:59 AM · Render & Cycles, BF Blender
Evan Wilson (EAW) awarded rB166c0db3f941: Fix T83915: Subdivision Surface modifier causes visual artifacts in Cycles… a Like token.
Jan 6 2021, 12:15 AM

Jan 5 2021

Patrick Mours (pmoursnv) closed T83925: Crash when rendering with OptiX denoiser enabled as Resolved.

Should be fixed now!

Jan 5 2021, 6:40 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) committed rB3373d14b1b05: Fix T83925: Crash when rendering on the CPU with OptiX denoiser enabled (authored by Patrick Mours (pmoursnv)).
Fix T83925: Crash when rendering on the CPU with OptiX denoiser enabled
Jan 5 2021, 6:38 PM
Patrick Mours (pmoursnv) closed T83915: Subdivision Surface modifier causes visual artifacts in Cycles rendered viewport - CPU and OptiX as Resolved.
Jan 5 2021, 6:01 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) committed rB166c0db3f941: Fix T83915: Subdivision Surface modifier causes visual artifacts in Cycles… (authored by Patrick Mours (pmoursnv)).
Fix T83915: Subdivision Surface modifier causes visual artifacts in Cycles…
Jan 5 2021, 6:00 PM
Patrick Mours (pmoursnv) added a comment to T83915: Subdivision Surface modifier causes visual artifacts in Cycles rendered viewport - CPU and OptiX.

Sounds good. I think I'll just go with a Geometry::tag_bvh_update routine for now and we can then later see if it can be simplified with the update flags when that gets merged.

Jan 5 2021, 5:39 PM · Render & Cycles, BF Blender
Patrick Mours (pmoursnv) updated subscribers of T83915: Subdivision Surface modifier causes visual artifacts in Cycles rendered viewport - CPU and OptiX.

This is the same issue @Kévin Dietrich (kevindietrich) mentioned in D9555#247586 where Geometry::optix_prim_offset changes are not propagated to the Embree/OptiX BVH.

Jan 5 2021, 3:02 PM · Render & Cycles, BF Blender