Stefan Werner (swerner)
User

Projects

User Details

User Since
Mar 31 2015, 9:29 AM (172 w, 3 d)

Recent Activity

Today

Rainer Trummer (aliasguru) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Fri, Jul 20, 6:43 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Fri, Jul 20, 5:04 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Compile fixes for OpenCL kernel.
Fri, Jul 20, 3:28 PM · Cycles
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

I think I found a way to write id passes using atomics.

Fri, Jul 20, 12:32 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Cryptomatte writing now uses atomics on GPUs to avoid race conditions.
  • Cycles: Code style, fixed typos moving murmurhash to its own cpp file.
Fri, Jul 20, 12:31 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Fri, Jul 20, 12:02 PM · Cycles

Wed, Jul 18

Stefan Werner (swerner) committed rBbdda0964e0a5: Compositor: Cryptomatte compositing node. (authored by Stefan Werner (swerner)).
Compositor: Cryptomatte compositing node.
Wed, Jul 18, 1:04 PM
Stefan Werner (swerner) closed D3531: Compositor: Cryptomatte compositing node..
Wed, Jul 18, 1:03 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Reverted an accidental change.
Wed, Jul 18, 1:02 PM · Compositing

Mon, Jul 16

Stefan Werner (swerner) committed rBc29429bded85: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Mon, Jul 16, 4:08 PM
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Fixed Cryptomatte string handling.
  • Compositor: Applied Brecht's UI improvements to Cryptomatte node
  • Compositor: Fixed broken add/remove in Cryptomatte node.
  • Compositor: Raised default number of Crypto inputs to three, as recommended by the Cryptomatte specification.
Mon, Jul 16, 3:47 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Cryptomatte node now uses a dynamic string for matte ids, no more 1024 character limit.
Mon, Jul 16, 1:00 PM · Compositing
Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

Cryptomatte output for Cycles is now in D3538

Mon, Jul 16, 12:58 PM
Stefan Werner (swerner) added a project to D3538: Cycles: Added Cryptomatte passes.: Cycles.
Mon, Jul 16, 12:56 PM · Cycles

Fri, Jul 13

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Addressed Lukas' comments for Cryptomatte output.
Fri, Jul 13, 2:51 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Fri, Jul 13, 2:38 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Fri, Jul 13, 2:16 PM · Cycles
Stefan Werner (swerner) added a comment to D3540: Cycles: Save a few instructions in area light sampling.

Looks good to me. The test renders I did didn't show any differences.

Fri, Jul 13, 10:24 AM
Stefan Werner (swerner) added inline comments to D3540: Cycles: Save a few instructions in area light sampling.
Fri, Jul 13, 9:01 AM

Thu, Jul 12

Stefan Werner (swerner) added a comment to D3531: Compositor: Cryptomatte compositing node..

Cryptomatte support for Cycles is in D3538.

Thu, Jul 12, 11:14 PM · Compositing
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Still to do:

Thu, Jul 12, 11:13 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Thu, Jul 12, 11:12 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Fixed indentation.
Thu, Jul 12, 11:08 PM · Cycles
Stefan Werner (swerner) updated subscribers of D3538: Cycles: Added Cryptomatte passes..

@Brecht Van Lommel (brecht) This patch changes array<Pass> back to vector<Pass>, as it was before you did some refactoring. Is that safe to do or are there dangers that I'm overlooking? Since I'd like Pass to contain a name string, it would be important that its destructor gets called.

Thu, Jul 12, 11:05 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Fixed Cryptomatte pass names to match between Python and C++ code.
Thu, Jul 12, 11:03 PM · Cycles
Stefan Werner (swerner) added a reviewer for D3538: Cycles: Added Cryptomatte passes.: Cycles.
Thu, Jul 12, 11:00 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Code styling fixes for murmurhash.
Thu, Jul 12, 10:58 PM · Cycles
Stefan Werner (swerner) created D3538: Cycles: Added Cryptomatte passes..
Thu, Jul 12, 10:37 PM · Cycles

Wed, Jul 11

Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

A Cryptomatte compositing node is in this patch: https://developer.blender.org/D3531

Wed, Jul 11, 1:14 PM
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • More code styling changes in Cryptomatte compositing node.
  • Code styling and warning suppression in murmur3 hash.
  • Removed unused code.
Wed, Jul 11, 12:35 PM · Compositing
Stefan Werner (swerner) committed rBd4f27b960bf8: Cycles: Switched CPU cryptomatte to use unordered_map instead of map. (authored by Stefan Werner (swerner)).
Cycles: Switched CPU cryptomatte to use unordered_map instead of map.
Wed, Jul 11, 12:21 PM
Stefan Werner (swerner) committed rBc36977652aa8: Cycles: Initial addition of Cryptomatte ID writing. (authored by Stefan Werner (swerner)).
Cycles: Initial addition of Cryptomatte ID writing.
Wed, Jul 11, 12:21 PM
Stefan Werner (swerner) added inline comments to D3531: Compositor: Cryptomatte compositing node..
Wed, Jul 11, 10:58 AM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..

x - Compositor: Addressed Brecht's comments for Cryptomatte node.

  • Compositor: Added static sizeof() checks before type punning. Currently, sizeof(float) == 4 on all of our supported platforms, but the standards don't require that. You never know...
Wed, Jul 11, 10:46 AM · Compositing
Stefan Werner (swerner) added inline comments to D3531: Compositor: Cryptomatte compositing node..
Wed, Jul 11, 10:37 AM · Compositing

Tue, Jul 10

Stefan Werner (swerner) added a comment to D3531: Compositor: Cryptomatte compositing node..

This is a patch against the current master. Should I rather rebase this on top of the 2.8 branch?

Tue, Jul 10, 2:32 PM · Compositing
Stefan Werner (swerner) added a project to D3531: Compositor: Cryptomatte compositing node.: Compositing.
Tue, Jul 10, 2:30 PM · Compositing
Stefan Werner (swerner) created D3531: Compositor: Cryptomatte compositing node..
Tue, Jul 10, 2:30 PM · Compositing

Mon, Jul 9

Stefan Werner (swerner) committed rBdd446142e219: Merge branch 'master' of git.blender.org:blender into temp_cryptomatte (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into temp_cryptomatte
Mon, Jul 9, 1:19 PM
Stefan Werner (swerner) committed rB8bc1a60fb2d3: Cycles: Moved get_aov_rect method to make things easeir for git merge (authored by Stefan Werner (swerner)).
Cycles: Moved get_aov_rect method to make things easeir for git merge
Mon, Jul 9, 1:19 PM

Fri, Jul 6

Stefan Werner (swerner) committed rB7e503adf340e: More removal of unrelated AOV code (authored by Stefan Werner (swerner)).
More removal of unrelated AOV code
Fri, Jul 6, 11:13 PM
Stefan Werner (swerner) committed rB7610395cbc4c: Cleanup: Removed unrelated AOV code, made Cryptomatte work with OpenCL (authored by Stefan Werner (swerner)).
Cleanup: Removed unrelated AOV code, made Cryptomatte work with OpenCL
Fri, Jul 6, 4:42 PM
Stefan Werner (swerner) committed rBdf30b50f2f5e: Cycles: Enabled half precision textures for OpenCL devices that support the… (authored by Stefan Werner (swerner)).
Cycles: Enabled half precision textures for OpenCL devices that support the…
Fri, Jul 6, 11:42 AM
Stefan Werner (swerner) accepted rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….

Should be fixed now in d20d2bcb7fe7

Fri, Jul 6, 10:24 AM
Stefan Werner (swerner) committed rBd20d2bcb7fe7: Cycles: Fixed OpenCL kernel build, it threw a compiler error. (authored by Stefan Werner (swerner)).
Cycles: Fixed OpenCL kernel build, it threw a compiler error.
Fri, Jul 6, 10:22 AM
Stefan Werner (swerner) raised a concern with rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….
Fri, Jul 6, 9:54 AM
Stefan Werner (swerner) added inline comments to rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….
Fri, Jul 6, 9:53 AM

Thu, Jul 5

Stefan Werner (swerner) committed rB140a129f22f0: Cycles: Enabled half precision float textures for OpenCL devices that support… (authored by Stefan Werner (swerner)).
Cycles: Enabled half precision float textures for OpenCL devices that support…
Thu, Jul 5, 3:18 PM
Stefan Werner (swerner) committed rB4d00e95ee3ed: Cycles: Adding native support for UINT16 textures. (authored by Stefan Werner (swerner)).
Cycles: Adding native support for UINT16 textures.
Thu, Jul 5, 1:54 PM
Stefan Werner (swerner) closed D3523: Cycles: Adding native support for UINT16 textures..
Thu, Jul 5, 1:53 PM · Cycles
Stefan Werner (swerner) updated the diff for D3523: Cycles: Adding native support for UINT16 textures..
  • Removed whitespace change in unrelated code - let's keep this patch to the point.
Thu, Jul 5, 12:38 PM · Cycles
Stefan Werner (swerner) updated the diff for D3523: Cycles: Adding native support for UINT16 textures..
  • Addressed Sergey's comments regarding code style
Thu, Jul 5, 12:35 PM · Cycles
Stefan Werner (swerner) added inline comments to D3523: Cycles: Adding native support for UINT16 textures..
Thu, Jul 5, 12:32 PM · Cycles
Stefan Werner (swerner) updated the summary of D3523: Cycles: Adding native support for UINT16 textures..
Thu, Jul 5, 10:52 AM · Cycles
Stefan Werner (swerner) created D3523: Cycles: Adding native support for UINT16 textures..
Thu, Jul 5, 10:50 AM · Cycles

Wed, Jun 27

Stefan Werner (swerner) committed rBe17430d00dae: Cycles: Fixed broken displacement (authored by Stefan Werner (swerner)).
Cycles: Fixed broken displacement
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB66e571dfadf2: Cycles: Fixed broken bump mapping (authored by Stefan Werner (swerner)).
Cycles: Fixed broken bump mapping
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBc987f6e6e106: Cycles: improved texture differentials for bump maps, added texture… (authored by Stefan Werner (swerner)).
Cycles: improved texture differentials for bump maps, added texture…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB20825728f209: Cycles: added ray differentials to henyey-greenstein phase function (authored by Stefan Werner (swerner)).
Cycles: added ray differentials to henyey-greenstein phase function
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBd85c76e7b998: Cycles: Moved texture coordinate differential creation to after all bump maps… (authored by Stefan Werner (swerner)).
Cycles: Moved texture coordinate differential creation to after all bump maps…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB697600e78408: Cycles: Fixes for texture caching, behavior with auto convert off was broken… (authored by Stefan Werner (swerner)).
Cycles: Fixes for texture caching, behavior with auto convert off was broken…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB92bf11548d94: Cycles: Smaller fixes for differentials, taking dNdu inot account when getting… (authored by Stefan Werner (swerner)).
Cycles: Smaller fixes for differentials, taking dNdu inot account when getting…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBecdc2f7108b5: Ccyles: texture differentials now respect the hidden mapping node inside the… (authored by Stefan Werner (swerner)).
Ccyles: texture differentials now respect the hidden mapping node inside the…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBf363d080caaf: Cycles: fix for mip map paths (authored by Stefan Werner (swerner)).
Cycles: fix for mip map paths
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBbaf66bfa482e: Cycles: improved ray differentials for specular/glossy closures with DNDU/V… (authored by Stefan Werner (swerner)).
Cycles: improved ray differentials for specular/glossy closures with DNDU/V…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB3d1135385619: Cycles: Changed Mip Map names to replace, not add to suffix Added oiio_make_tx… (authored by Stefan Werner (swerner)).
Cycles: Changed Mip Map names to replace, not add to suffix Added oiio_make_tx…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rBa8e32a86e5ec: Cycles: more accurate differential approximation for glossy bounces (authored by Stefan Werner (swerner)).
Cycles: more accurate differential approximation for glossy bounces
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB15e5f06f38a0: Cycles: Don’t apply glossy blur texture filtering on singular paths (authored by Stefan Werner (swerner)).
Cycles: Don’t apply glossy blur texture filtering on singular paths
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB6d47a91220ac: Cycles: fixed normal differentials, ShaderData now contains dNdx/y instead of… (authored by Stefan Werner (swerner)).
Cycles: fixed normal differentials, ShaderData now contains dNdx/y instead of…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB443b91aebe73: Cycles: Smaller updates to texture cache, setting a few more options and… (authored by Stefan Werner (swerner)).
Cycles: Smaller updates to texture cache, setting a few more options and…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB6450e35a2f6d: Cycles: added diffuse_blur and glossy_blur parameters to texture cache (authored by Stefan Werner (swerner)).
Cycles: added diffuse_blur and glossy_blur parameters to texture cache
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB1bcad0d920ae: Cycles: fixed include statements for image cache to work on case-sensitive file… (authored by Stefan Werner (swerner)).
Cycles: fixed include statements for image cache to work on case-sensitive file…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB2925298d96c6: Cycles: Added dPdu/dPdv to area ligths so we can use filtered textures on them (authored by Stefan Werner (swerner)).
Cycles: Added dPdu/dPdv to area ligths so we can use filtered textures on them
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB34e28c29b66c: Cycles: added blurrier texture lookups for indirect diffuse paths (authored by Stefan Werner (swerner)).
Cycles: added blurrier texture lookups for indirect diffuse paths
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB693667b85ef4: Cycles: Cached textures are now assumed to be linear and converted from sRGB… (authored by Stefan Werner (swerner)).
Cycles: Cached textures are now assumed to be linear and converted from sRGB…
Wed, Jun 27, 2:05 PM
Stefan Werner (swerner) committed rB7c61f79e4da6: Cycles: Crash fix (authored by Stefan Werner (swerner)).
Cycles: Crash fix
Wed, Jun 27, 2:04 PM
Stefan Werner (swerner) committed rB9341dac2237a: Cycles: More improvements to texture filtering of light sources (authored by Stefan Werner (swerner)).
Cycles: More improvements to texture filtering of light sources
Wed, Jun 27, 2:04 PM
Stefan Werner (swerner) committed rB9d1417d21023: Cycles: Cached textures now support extension and interpolation modes (authored by Stefan Werner (swerner)).
Cycles: Cached textures now support extension and interpolation modes
Wed, Jun 27, 2:04 PM

Tue, Jun 26

Stefan Werner (swerner) added a reverting commit for rBd53093953f8f: Turned off clang warnings in third party includes.: rB73eb1bfd55d5: Revert "Turned off clang warnings in third party includes.".
Tue, Jun 26, 11:12 AM
Stefan Werner (swerner) committed rB73eb1bfd55d5: Revert "Turned off clang warnings in third party includes." (authored by Stefan Werner (swerner)).
Revert "Turned off clang warnings in third party includes."
Tue, Jun 26, 11:12 AM

Mon, Jun 25

Stefan Werner (swerner) committed rBd53093953f8f: Turned off clang warnings in third party includes. (authored by Stefan Werner (swerner)).
Turned off clang warnings in third party includes.
Mon, Jun 25, 11:02 PM

Jun 19 2018

Stefan Werner (swerner) committed rB9ff135d85dde: Cycles: Fixed crash when the camera was inside 16 volumes or more. It still… (authored by Stefan Werner (swerner)).
Cycles: Fixed crash when the camera was inside 16 volumes or more. It still…
Jun 19 2018, 4:35 PM
Stefan Werner (swerner) committed rBb69363290246: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Jun 19 2018, 2:41 PM
Stefan Werner (swerner) committed rB705eda51f0e3: Merge branch 'cycles_embree' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'cycles_embree' of git.blender.org:blender into cycles_embree
Jun 19 2018, 2:41 PM
Stefan Werner (swerner) committed rB009cd8290b70: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Jun 19 2018, 2:25 PM
Stefan Werner (swerner) committed rBcf1ecb86a947: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Jun 19 2018, 1:36 PM
Stefan Werner (swerner) committed rB101b248174a6: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Jun 19 2018, 1:36 PM
Stefan Werner (swerner) committed rBe437bab5d833: Cycles: Added NULL pointer check (authored by Stefan Werner (swerner)).
Cycles: Added NULL pointer check
Jun 19 2018, 1:35 PM

Jun 5 2018

Stefan Werner (swerner) added a comment to T55332: Cycles misses intersections when objects are too close.

Jun 5 2018, 10:31 AM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T55332: Cycles misses intersections when objects are too close.

The source of the problem is the use of ray_offset() to prevent self-intersections for rays that originate from a transparent surface. A solution to this problem is outlined in the paper "Robust Iterative Find-Next-Hit Ray Traversal": http://www.sci.utah.edu/~wald/Publications/2018/nexthit-pgv18.pdf

Jun 5 2018, 10:30 AM · Cycles, BF Blender
Stefan Werner (swerner) claimed T55332: Cycles misses intersections when objects are too close.
Jun 5 2018, 10:29 AM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T55332: Cycles misses intersections when objects are too close.

Jun 5 2018, 10:29 AM · Cycles, BF Blender
Stefan Werner (swerner) created T55332: Cycles misses intersections when objects are too close.
Jun 5 2018, 10:28 AM · Cycles, BF Blender

May 28 2018

Stefan Werner (swerner) added a comment to T55227: Cycles crashes when too many volumes overlap the camera.

The root cause is that PathState.volume_stack is a fixed size array and kernel_volume_stack_init() does not perform any bounds checking when writing to that array.

May 28 2018, 3:00 PM · Cycles, BF Blender
Stefan Werner (swerner) claimed T55227: Cycles crashes when too many volumes overlap the camera.
May 28 2018, 2:56 PM · Cycles, BF Blender
Stefan Werner (swerner) created T55227: Cycles crashes when too many volumes overlap the camera.
May 28 2018, 2:56 PM · Cycles, BF Blender

Apr 24 2018

Stefan Werner (swerner) committed rBf1e6838376a0: Build: Added explicit search for Blosc in CMake files. Unix build will now… (authored by Stefan Werner (swerner)).
Build: Added explicit search for Blosc in CMake files. Unix build will now…
Apr 24 2018, 1:31 PM
Stefan Werner (swerner) committed rB0ab30f9e391a: Build deps: Fixed TBB build with GCC 6 and newer, turning off dead store… (authored by Stefan Werner (swerner)).
Build deps: Fixed TBB build with GCC 6 and newer, turning off dead store…
Apr 24 2018, 1:31 PM
Stefan Werner (swerner) committed rBdac8b08f4cc2: Build deps: Fixed capitalisation of CMake modules path for OpenVDB. Before… (authored by Stefan Werner (swerner)).
Build deps: Fixed capitalisation of CMake modules path for OpenVDB. Before…
Apr 24 2018, 10:28 AM

Apr 12 2018

Stefan Werner (swerner) committed rB6bf57eb8bd9d: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Apr 12 2018, 8:49 AM