Page MenuHome

Stefan Werner (swerner)
User

Projects

User Details

User Since
Mar 31 2015, 9:29 AM (238 w, 2 h)

Recent Activity

Yesterday

Stefan Werner (swerner) added a comment to T68920: Reduce shadow terminator artifacts.

For what it's worth, a little insight in what other renderers do (in the case without bump maps)
LuxRender: Nothing.
"the black triangles on the edge are unavoidable, their geometric normal points away from the light source so there is no way to fix them aside increasing tessellation and/or using softer shadows (due to a larger light source, etc.)"
https://forums.luxcorerender.org/viewtopic.php?f=5&t=1286

Mon, Oct 21, 9:46 AM · Cycles, BF Blender

Fri, Oct 18

Michael Hermann (245) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Fri, Oct 18, 3:38 PM

Thu, Oct 17

derek barker (lordodin) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Thu, Oct 17, 4:42 PM
derek barker (lordodin) awarded D4676: Cycles: Improved sampling for sphere lights. a Love token.
Thu, Oct 17, 4:41 PM · Cycles
Stefan Werner (swerner) added a comment to T68920: Reduce shadow terminator artifacts.

Read the SIGGRAPH paper more closely - it applies to problems introduced by bump/normal mapped surfaces only. It is implemented and working.

Thu, Oct 17, 10:18 AM · Cycles, BF Blender

Wed, Oct 16

Stefan Werner (swerner) updated the diff for D6075: Cycles: Improved equiangular sampling..

Commenting.

Wed, Oct 16, 8:29 PM · Cycles
Stefan Werner (swerner) updated the diff for D6075: Cycles: Improved equiangular sampling..

Code deduplication.

Wed, Oct 16, 8:27 PM · Cycles
Vyacheslav (hitrpr) awarded D6075: Cycles: Improved equiangular sampling. a Love token.
Wed, Oct 16, 8:06 PM · Cycles
MasterNurmi (MasterNurmi) awarded D6075: Cycles: Improved equiangular sampling. a Party Time token.
Wed, Oct 16, 4:26 PM · Cycles
Stefan Werner (swerner) added a project to D6075: Cycles: Improved equiangular sampling.: Cycles.
Wed, Oct 16, 12:46 PM · Cycles
noki paike (amonpaike) awarded D6075: Cycles: Improved equiangular sampling. a Love token.
Wed, Oct 16, 12:15 PM · Cycles
Fin O'Riordan (fin.eskimo) awarded F7825203: original.jpg a Like token.
Wed, Oct 16, 11:53 AM
Stefan Werner (swerner) added a comment to D6075: Cycles: Improved equiangular sampling..

Come to think of it, it should be possible to apply the same ray clipping to distance sampling as well.

Wed, Oct 16, 11:00 AM · Cycles
Stefan Werner (swerner) added reviewers for D6075: Cycles: Improved equiangular sampling.: Brecht Van Lommel (brecht), Lukas Stockner (lukasstockner97).
Wed, Oct 16, 10:51 AM · Cycles
Stefan Werner (swerner) added a comment to D6075: Cycles: Improved equiangular sampling..

Wed, Oct 16, 10:50 AM · Cycles
Stefan Werner (swerner) created D6075: Cycles: Improved equiangular sampling..
Wed, Oct 16, 10:49 AM · Cycles
Stefan Werner (swerner) committed rB35a545b75231: Cycles: Allow PTX targets for CUDA kernel build. (authored by Stefan Werner (swerner)).
Cycles: Allow PTX targets for CUDA kernel build.
Wed, Oct 16, 10:30 AM
Stefan Werner (swerner) closed D5953: Cycles: Allow PTX targets for CUDA kernel build..
Wed, Oct 16, 10:30 AM · Cycles
Stefan Werner (swerner) updated the diff for D5953: Cycles: Allow PTX targets for CUDA kernel build..
  • Merge branch 'master' into cuda_ptx
Wed, Oct 16, 10:26 AM · Cycles
Stefan Werner (swerner) added a comment to D5953: Cycles: Allow PTX targets for CUDA kernel build..

I clearly don't know how to use phabricator.

Wed, Oct 16, 10:25 AM · Cycles
Stefan Werner (swerner) updated the diff for D5953: Cycles: Allow PTX targets for CUDA kernel build..
  • Cleanup: Fix naming of a functio - Cycles: Added "compute_xx" as architecture options to CUDA kernels.
Wed, Oct 16, 10:24 AM · Cycles

Tue, Oct 15

Matthew Wiebe (cerebral_malfunction) awarded D4676: Cycles: Improved sampling for sphere lights. a Love token.
Tue, Oct 15, 1:22 AM · Cycles

Sun, Oct 13

Andrey (andruxa696) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Sun, Oct 13, 4:50 PM

Wed, Oct 2

Stefan Werner (swerner) committed rBf97a64aa9b7b: Fix T70252: Reverting to macOS 10.11 compatible API. (authored by Stefan Werner (swerner)).
Fix T70252: Reverting to macOS 10.11 compatible API.
Wed, Oct 2, 10:23 AM

Tue, Oct 1

Stefan Werner (swerner) committed rB5eebd7cc1fe9: Cycles: Fixed Camera inside volumes with Embree turned on. (authored by Stefan Werner (swerner)).
Cycles: Fixed Camera inside volumes with Embree turned on.
Tue, Oct 1, 7:36 PM
Stefan Werner (swerner) added a comment to D5953: Cycles: Allow PTX targets for CUDA kernel build..

@Lukas Stockner (lukasstockner97) good catch, thanks!

Tue, Oct 1, 1:51 PM · Cycles
Stefan Werner (swerner) updated the diff for D5953: Cycles: Allow PTX targets for CUDA kernel build..
  • Merge branch 'cuda_ptx' of github.com:skwerner/blender into cuda_ptx
  • Fixed a typo.
Tue, Oct 1, 1:50 PM · Cycles
Stefan Werner (swerner) updated the summary of D5953: Cycles: Allow PTX targets for CUDA kernel build..
Tue, Oct 1, 12:45 PM · Cycles
Stefan Werner (swerner) created D5953: Cycles: Allow PTX targets for CUDA kernel build..
Tue, Oct 1, 12:42 PM · Cycles

Mon, Sep 30

Stefan Werner (swerner) added a comment to rB04133ee863b4: Revert "macOS: Replaced OSSpinLock with os_unfair_lock.".

Fix T70252

Mon, Sep 30, 8:31 AM
Stefan Werner (swerner) added a reverting change for rB9d282d7a8d68: macOS: Replaced OSSpinLock with os_unfair_lock.: rB04133ee863b4: Revert "macOS: Replaced OSSpinLock with os_unfair_lock.".
Mon, Sep 30, 8:30 AM
Stefan Werner (swerner) added a reverted change for rB04133ee863b4: Revert "macOS: Replaced OSSpinLock with os_unfair_lock.": rB9d282d7a8d68: macOS: Replaced OSSpinLock with os_unfair_lock..
Revert "macOS: Replaced OSSpinLock with os_unfair_lock."
Mon, Sep 30, 8:30 AM
Stefan Werner (swerner) closed T70252: BL 2.81 Instant crash OSX 10.11.6 as Resolved.
Mon, Sep 30, 8:30 AM · BF Blender (2.81)

Sat, Sep 28

noki paike (amonpaike) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Sat, Sep 28, 8:32 AM
Matthew Wiebe (cerebral_malfunction) awarded D4686: Adaptive Sampling for Cycles. a Burninate token.
Sat, Sep 28, 8:22 AM

Fri, Sep 27

Stefan Werner (swerner) added a comment to T70252: BL 2.81 Instant crash OSX 10.11.6.

Blender 2.80 requires 10.12 or newer. If I remember correctly, that was decided because of bugs in older OpenGL drivers. It is also mentioned on the Download page.

Fri, Sep 27, 2:12 PM · BF Blender (2.81)

Sep 18 2019

Stefan Werner (swerner) added a comment to D5843: Cycles: Correct sRGB conversion for interpolated textures..

Note that there's one case where the color space conversion still happens in the wrong place, that is when OSL is enabled and reading external textures. OpenImageIO's TextureSys is loading 8 bit sRGB textures without color transform and calculates temporary mip maps and any interpolations in the wrong color space.

Sep 18 2019, 5:14 PM · Cycles
Stefan Werner (swerner) added a comment to D5843: Cycles: Correct sRGB conversion for interpolated textures..
  • Cleanup: Whitespace
Sep 18 2019, 5:12 PM · Cycles
Stefan Werner (swerner) updated the summary of D5843: Cycles: Correct sRGB conversion for interpolated textures..
Sep 18 2019, 5:09 PM · Cycles
Stefan Werner (swerner) created D5843: Cycles: Correct sRGB conversion for interpolated textures..
Sep 18 2019, 5:07 PM · Cycles

Sep 17 2019

Stefan Werner (swerner) added a comment to T69982: Cycles: sRGB texture compression happens after interpolation .

I’m working on a fix right now, we’ll see what the performance impact is.

Sep 17 2019, 10:34 PM · Cycles, BF Blender
Stefan Werner (swerner) updated the task description for T69982: Cycles: sRGB texture compression happens after interpolation .
Sep 17 2019, 2:58 PM · Cycles, BF Blender
Stefan Werner (swerner) added a project to T69982: Cycles: sRGB texture compression happens after interpolation : Cycles.
Sep 17 2019, 2:54 PM · Cycles, BF Blender
Stefan Werner (swerner) created T69982: Cycles: sRGB texture compression happens after interpolation .
Sep 17 2019, 2:53 PM · Cycles, BF Blender

Sep 14 2019

Stefan Werner (swerner) added a comment to D5794: Remove warnings by replacing deprecated API calls.

rB2b9f4bcfa07046c2485db4d9cc2bc465c2582d39

Sep 14 2019, 9:04 PM · Platform: macOS
Stefan Werner (swerner) committed rB2b9f4bcfa070: macOS: Replaced deprecated Cocoa API calls. (authored by Stefan Werner (swerner)).
macOS: Replaced deprecated Cocoa API calls.
Sep 14 2019, 8:28 PM
Stefan Werner (swerner) committed rB9d282d7a8d68: macOS: Replaced OSSpinLock with os_unfair_lock. (authored by Stefan Werner (swerner)).
macOS: Replaced OSSpinLock with os_unfair_lock.
Sep 14 2019, 8:27 PM
Stefan Werner (swerner) updated the summary of D5794: Remove warnings by replacing deprecated API calls.
Sep 14 2019, 9:48 AM · Platform: macOS
Stefan Werner (swerner) retitled D5794: Remove warnings by replacing deprecated API calls from macOS: Replaced deprecated OSSpinlock with os_unfair_lock. to Remove warnings by replacing deprecated API calls.
Sep 14 2019, 9:46 AM · Platform: macOS
Stefan Werner (swerner) created D5794: Remove warnings by replacing deprecated API calls.
Sep 14 2019, 9:41 AM · Platform: macOS
Stefan Werner (swerner) committed rBca76ecfa0ee1: Cleanup: clang-format (authored by Stefan Werner (swerner)).
Cleanup: clang-format
Sep 14 2019, 9:27 AM

Sep 13 2019

Stefan Werner (swerner) added a comment to rBce34a6b0d727: DRW: Refactor to support draw call batching.

It should be ok now, I fixed aligned Malloc on macOS.
rBc80564ef9f557fadd235b87533b24d126e2138c9

Sep 13 2019, 11:45 PM
Stefan Werner (swerner) committed rBc80564ef9f55: macOS: Enabled posix_memalign() like on other Unix platforms. (authored by Stefan Werner (swerner)).
macOS: Enabled posix_memalign() like on other Unix platforms.
Sep 13 2019, 10:49 PM
Stefan Werner (swerner) added inline comments to rBce34a6b0d727: DRW: Refactor to support draw call batching.
Sep 13 2019, 10:32 PM
Stefan Werner (swerner) committed rB2520f7897174: Fixed macOS build, header cleanup was too agressive. (authored by Stefan Werner (swerner)).
Fixed macOS build, header cleanup was too agressive.
Sep 13 2019, 9:29 PM
Stefan Werner (swerner) added inline comments to rB0ec656466817: Cleanup: unused headers (GPU).
Sep 13 2019, 9:24 PM

Sep 12 2019

Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

I attached my test patches so others can test for themselves. They are not optimized, there are faster filter implementations that use less memory.

Sep 12 2019, 9:42 AM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

2x2 supersampling inside kernel_background_evaluate() reduces noise more than filtering when generating the distribution and leaves the quality intact with other texture filters. It should also improve the situation for procedural high-frequency environment maps. My vote would be for supersampling.

Sep 12 2019, 9:28 AM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

I played a bit with simple filters for the distribution. Both 3x3 box and 3x3 Gaussian filters improve the case with linear texture filtering, but make things worse for closest texture filtering.

Sep 12 2019, 8:47 AM · Cycles, BF Blender

Sep 11 2019

Juan Gea (juang3d) awarded D4676: Cycles: Improved sampling for sphere lights. a Love token.
Sep 11 2019, 11:19 PM · Cycles
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.
Sep 11 2019, 7:44 PM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

PBRT filters the environment map when creating the distribution:

Sep 11 2019, 3:12 PM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

I just played with 2x2 supersampling when generating the distribution, thus avoiding sampling texels exactly in the middle. This allows for texture filtering to contribute more, as opposed to sampling texels in their exact center which makes the linear filter behave exactlylike the closest filter.

Sep 11 2019, 2:52 PM · Cycles, BF Blender
Stefan Werner (swerner) updated the task description for T69745: Environment Importance Sampling gives too much noise.
Sep 11 2019, 1:15 PM · Cycles, BF Blender
Stefan Werner (swerner) added a comment to T69745: Environment Importance Sampling gives too much noise.

Working theory:
When building the initial distribution, Cycles always sample the center of a pixel, effectively a closest or box filter. When using the distribution later during the render with a different filter, we get a mismatch between the function and its PDF. When sampled with linear texture filtering, single bright pixels become spikes that bleed into the neighboring pixels, where the distribution we sample from is piecewise linear over the pixel with no bleeding.

Sep 11 2019, 1:02 PM · Cycles, BF Blender
Stefan Werner (swerner) updated the task description for T69745: Environment Importance Sampling gives too much noise.
Sep 11 2019, 12:42 PM · Cycles, BF Blender
Stefan Werner (swerner) added a project to T69745: Environment Importance Sampling gives too much noise: Cycles.
Sep 11 2019, 12:41 PM · Cycles, BF Blender
Stefan Werner (swerner) claimed T69745: Environment Importance Sampling gives too much noise.
Sep 11 2019, 12:40 PM · Cycles, BF Blender
Stefan Werner (swerner) created T69745: Environment Importance Sampling gives too much noise.
Sep 11 2019, 12:40 PM · Cycles, BF Blender

Sep 10 2019

Stefan Werner (swerner) added a comment to T37814: Artifacts in Cycles render for lowpoly models..

I spent some time looking into this.

Sep 10 2019, 3:45 PM · BF Blender
Stefan Werner (swerner) added a comment to D5399: Cycles: Add bump-map shadow terminator softening term.

I uploaded my sample file if someone needs it in the future for regression testing.

Sep 10 2019, 9:02 AM

Sep 8 2019

Jesse Y (deadpin) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Sep 8 2019, 3:20 AM

Aug 29 2019

Rafael Ristovski (Ristovski) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Aug 29 2019, 6:05 PM

Aug 27 2019

B (bnzs) awarded rBb91b9a8ecaf5: Compositor: Run only one instance of OIDN at a time. a Love token.
Aug 27 2019, 8:07 PM
Stefan Werner (swerner) committed rBcd890c4c256e: Compositor: Reversed order of Normal and Albedo in Denoising Node. (authored by Stefan Werner (swerner)).
Compositor: Reversed order of Normal and Albedo in Denoising Node.
Aug 27 2019, 2:44 PM
Stefan Werner (swerner) added a comment to T68944: When I connect the new Denoise Node it appears in Black.

@Lauri Hastholm (laurijh) I don't have a CPU without SSE4.1, it would be great if you could leave feedback here if my fix worked for you. On unsupported CPUs, you should now see a message in the node itself and it should now act as a passthrough instead of returning a black image.

Aug 27 2019, 2:19 PM · Nodes, Compositing, BF Blender
Stefan Werner (swerner) committed rBd547f9d3d291: Fix T68944: Added check for SSE4.1 to denoising node. (authored by Stefan Werner (swerner)).
Fix T68944: Added check for SSE4.1 to denoising node.
Aug 27 2019, 2:04 PM
Stefan Werner (swerner) closed T68944: When I connect the new Denoise Node it appears in Black as Resolved by committing rBd547f9d3d291: Fix T68944: Added check for SSE4.1 to denoising node..
Aug 27 2019, 2:04 PM · Nodes, Compositing, BF Blender
Stefan Werner (swerner) closed T69006: OIDN: RAM increases proportionally with each Denoise node used as Resolved.
Aug 27 2019, 11:07 AM · Nodes, Compositing, BF Blender
Stefan Werner (swerner) committed rBb91b9a8ecaf5: Compositor: Run only one instance of OIDN at a time. (authored by Stefan Werner (swerner)).
Compositor: Run only one instance of OIDN at a time.
Aug 27 2019, 11:07 AM

Aug 26 2019

B (bnzs) awarded D4255: Cycles: Added feature overrides a Love token.
Aug 26 2019, 8:49 PM · Cycles
B (bnzs) awarded D4204: Ray and Shader counters for Cycles a Love token.
Aug 26 2019, 8:49 PM · Cycles
B (bnzs) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Aug 26 2019, 8:49 PM
B (bnzs) awarded D4676: Cycles: Improved sampling for sphere lights. a Love token.
Aug 26 2019, 8:48 PM · Cycles
B (bnzs) awarded D4459: Cycles: Added fix for bump terminator problem. a Love token.
Aug 26 2019, 8:48 PM · Cycles
Stefan Werner (swerner) added a comment to D5522: GSoC2019: Embree on GPU.

I'm seeing crashes in the victor scene when rendering this on a 1080Ti on Centos 7:

Aug 26 2019, 12:24 PM
Stefan Werner (swerner) added a comment to D5522: GSoC2019: Embree on GPU.

Can you add the following snipped to make the patch also apply to builds with make deps?

Aug 26 2019, 12:23 PM

Aug 23 2019

Stefan Werner (swerner) added a comment to T69006: OIDN: RAM increases proportionally with each Denoise node used.

The compositor is running separate threads for independent nodes. In most constellations, that means that all denoising nodes run at the same time.

Aug 23 2019, 4:36 PM · Nodes, Compositing, BF Blender

Aug 21 2019

Stefan Werner (swerner) added a comment to T68239: Cryptomatte affected by Color Space change in OpenEXR multilayer..

If I understand it correctly, the cryptomatte passes should never be modified by some color space transformation. Is that correct?

Aug 21 2019, 3:04 PM · Compositing, Rendering, BF Blender

Aug 20 2019

Stefan Werner (swerner) added a comment to D5522: GSoC2019: Embree on GPU.

I am unable to get hair to render - any scene from the benchmark repository (https://svn.blender.org/svnroot/bf-blender/trunk/lib/benchmarks/cycles/) that contains hair results in a crash.

Aug 20 2019, 11:58 AM
Stefan Werner (swerner) added a comment to D2149: Cycles: Add optional Blue-Noise Dithered Sobol Sampling.

@Lukas Stockner (lukasstockner97) can you upload a version of the existing that work against the current master? That would make it easier for others to experiment with it.

Aug 20 2019, 9:29 AM

Aug 16 2019

Stefan Werner (swerner) committed rB8e4f55aba6d5: build_env: Added OpenImageDenoise to install_deps.sh (authored by Stefan Werner (swerner)).
build_env: Added OpenImageDenoise to install_deps.sh
Aug 16 2019, 2:02 PM

Aug 15 2019

Stefan Werner (swerner) added a comment to D5363: Add OptiX device implementation to Cycles.

Just thinking aloud, this might be an opportunity for a small refactor of cycles: currently, Cycles builds the BVH before it uploads geometry vertices to the device. Most ray tracing APIs (DXR, OptiX, Embree) work the other way round. Before we introduce an OptiX specific workaround, should we change Cycles to do vertices first, BVH second? That would also help the Embree backend and potentially a future DXR/Vulkan backend when we see more vendors deliver ray tracing hardware.

Aug 15 2019, 12:00 PM · BF Blender (2.81), Cycles

Aug 14 2019

Stefan Werner (swerner) committed rB5489611e5317: Compositor: Added denoising node (authored by Brecht Van Lommel (brecht)).
Compositor: Added denoising node
Aug 14 2019, 9:41 PM
Stefan Werner (swerner) closed D4304: Compositor: Added denoising node.
Aug 14 2019, 9:40 PM · BF Blender (2.81), Compositing
Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

@Brecht Van Lommel (brecht) should I land the patch in its current state (OIDN disabled by default) or do we want to wait for install_deps.sh to be fully working first?

Aug 14 2019, 1:08 PM · BF Blender (2.81), Compositing
Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

Hi.
Will the compilation and installation of OIDN dependencies through install_deps.sh be automated?

Aug 14 2019, 12:44 PM · BF Blender (2.81), Compositing

Aug 13 2019

derek barker (lordodin) awarded D4255: Cycles: Added feature overrides a Yellow Medal token.
Aug 13 2019, 4:40 AM · Cycles
Juan Gea (juang3d) awarded D4255: Cycles: Added feature overrides a Love token.
Aug 13 2019, 1:56 AM · Cycles

Aug 9 2019

Stefan Werner (swerner) added a comment to D2149: Cycles: Add optional Blue-Noise Dithered Sobol Sampling.

There were some more implementation details in the 2019 SIGGRAPH course "My favorite samples":
https://drive.google.com/file/d/1MwphDkw6HeOzA1xcrmy_c7YvartaYjnf/view

Aug 9 2019, 9:41 AM