Page MenuHome

Stefan Werner (swerner)
User

Projects (6)

User Details

User Since
Mar 31 2015, 9:29 AM (275 w, 19 h)

Recent Activity

Yesterday

Stefan Werner (swerner) added a comment to D8237: Cycles: support neon instructions for arm64 processors.

Apple’s Metal contains a ray tracing framework similar to OptiX that could be a long term solution for GPU rendering on macOS.

Tue, Jul 7, 5:11 PM · Cycles
Stefan Werner (swerner) added a comment to D8236: macOS: changes to build library dependences for arm64.

OpenImageDenoise naturally doesn’t have an ARM port. There is however a denoiser that Apple includes in the Metal framework that we could use instead.

Tue, Jul 7, 5:10 PM · Platforms, Builds & Tests, Platform: macOS
Stefan Werner (swerner) added a comment to T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.

Come to think of - hair in motion is intersected correctly, scaled and squished according to the transformation matrix. The static ones are wrong. Not sure about whether normals are correct yet.

Tue, Jul 7, 2:25 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) added a comment to T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.

This can be reproduced with Cycles' BVH, Embree and Optix (D8223), so this is not isolated to our intersection code.

Tue, Jul 7, 1:58 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) added a comment to D8223: Cycles: Add support for native OptiX curve primitive.

Thanks, that gave me a hint - mistake on my side, I inadvertently caused a code path that didn't set up usesPrimitiveTypeFlags properly.

Tue, Jul 7, 1:56 PM
Stefan Werner (swerner) added a comment to D8223: Cycles: Add support for native OptiX curve primitive.

I've tried it here, but am getting error an message from OptiX:
OPTIX_ERROR_INVALID_VALUE in optixBuiltinISModuleGet( context, &module_options, &pipeline_options, &builtin_options, &builtin_modules[0]) (device_optix.cpp:479)

Tue, Jul 7, 12:34 PM
Stefan Werner (swerner) awarded D8223: Cycles: Add support for native OptiX curve primitive a Like token.
Tue, Jul 7, 8:35 AM

Mon, Jul 6

Stefan Werner (swerner) added a comment to T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.

The cause seems to be that when BVH traversal goes into instanced BVHs, the inverse, non-uniformly scaled object matrix is being applied to the ray's origin and direction. The ray/curve intersection routines are unable to take that into account and both intersection calculation as well as the calculation of the normal are incorrect as a result.

Mon, Jul 6, 1:42 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) updated subscribers of T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.
Mon, Jul 6, 1:36 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) changed the status of T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders from Needs Triage to Confirmed.
Mon, Jul 6, 1:35 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) claimed T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.
Mon, Jul 6, 1:35 PM · Render & Cycles, BF Blender
Stefan Werner (swerner) created T78666: Non-Uniform scaling of hair emitters results in incorrect Cycles renders.
Mon, Jul 6, 1:35 PM · Render & Cycles, BF Blender

Wed, Jul 1

Stefan Werner (swerner) awarded T77889: Cycles: Many Lights Sampling a Like token.
Wed, Jul 1, 9:59 PM · Render & Cycles, Restricted Project, Cycles
Stefan Werner (swerner) committed rB8c4703127ad1: GPU: Apple/Nvidia Proxy check (authored by Stefan Werner (swerner)).
GPU: Apple/Nvidia Proxy check
Wed, Jul 1, 7:55 AM
Stefan Werner (swerner) closed D8160: GPU: Apple/Nvidia Proxy check.
Wed, Jul 1, 7:55 AM · Platform: macOS

Tue, Jun 30

Stefan Werner (swerner) updated the summary of D8160: GPU: Apple/Nvidia Proxy check.
Tue, Jun 30, 12:14 PM · Platform: macOS
Stefan Werner (swerner) added a reviewer for D8160: GPU: Apple/Nvidia Proxy check: Clément Foucault (fclem).
Tue, Jun 30, 10:52 AM · Platform: macOS
Stefan Werner (swerner) requested review of D8160: GPU: Apple/Nvidia Proxy check.
Tue, Jun 30, 10:51 AM · Platform: macOS
Stefan Werner (swerner) added a revision to T78175: Hair drawing crash with NVIDIA GPU under macOS 10.15: D8160: GPU: Apple/Nvidia Proxy check.
Tue, Jun 30, 10:51 AM · EEVEE & Viewport, BF Blender

Mon, Jun 29

Stefan Werner (swerner) committed rB0d2e62896476: Build: Point ISPC explicitly to the location of LLVM libraries. (authored by Stefan Werner (swerner)).
Build: Point ISPC explicitly to the location of LLVM libraries.
Mon, Jun 29, 2:06 PM

Sun, Jun 28

Paul R (intracube) awarded D7634: Cycles: Added shadow terminator offset parameter. a Love token.
Sun, Jun 28, 2:47 AM · Cycles

Fri, Jun 26

Stefan Werner (swerner) added a comment to T78175: Hair drawing crash with NVIDIA GPU under macOS 10.15.

It seems to go a bit further back than that. While simple scenes with hair (default cube) work, scenes like Fishy Cat were rendering wrong since cecda64e2ead502a052f9bea5ffde39e4a46bf90

Fri, Jun 26, 11:05 PM · EEVEE & Viewport, BF Blender

Tue, Jun 23

Stefan Werner (swerner) updated the task description for T78175: Hair drawing crash with NVIDIA GPU under macOS 10.15.
Tue, Jun 23, 8:57 PM · EEVEE & Viewport, BF Blender
Stefan Werner (swerner) changed the status of T78175: Hair drawing crash with NVIDIA GPU under macOS 10.15 from Needs Triage to Confirmed.
Tue, Jun 23, 8:56 PM · EEVEE & Viewport, BF Blender

Fri, Jun 19

Alaska (Alaska) awarded D4204: Ray and Shader counters for Cycles a Love token.
Fri, Jun 19, 9:22 AM · Cycles
Alaska (Alaska) awarded D4255: Cycles: Added feature overrides a Love token.
Fri, Jun 19, 9:22 AM · Cycles

Thu, Jun 18

Stefan Werner (swerner) added a comment to D8015: Cycles: enable Embree by default for CPU rendering.

The real big speedups come with motion blur. Taking the scene from the blog entry about the Agent 327 motion blur improvements (https://cloud.blender.org/blog/cycles-turbocharged-how-we-made-rendering-10x-faster), frame 105:

EmbreeBVH8
Time5m00s54m15s
Memory6778MB7987MB
Thu, Jun 18, 1:24 PM
Stefan Werner (swerner) added a comment to D8015: Cycles: enable Embree by default for CPU rendering.

Embree vs BVH8 on an Intel CPU

Thu, Jun 18, 11:42 AM

Wed, Jun 17

surya kiran reddy (Dir-Surya) awarded D4204: Ray and Shader counters for Cycles a Burninate token.
Wed, Jun 17, 5:47 PM · Cycles

Tue, Jun 16

Stefan Werner (swerner) added a comment to D7641: Update OIDN to 1.2.1.

On my Linux system (Ubuntu 1804), make deps fails for ispc with linker errors about missing llvm symbols.

Tue, Jun 16, 1:46 PM
Stefan Werner (swerner) awarded D7641: Update OIDN to 1.2.1 a Love token.
Tue, Jun 16, 10:14 AM

Mon, Jun 15

Bintang Senja Pratama (bintang) awarded D4255: Cycles: Added feature overrides a Love token.
Mon, Jun 15, 1:17 PM · Cycles

Thu, Jun 11

Aditia A. Pratama (aditiapratama) awarded D4255: Cycles: Added feature overrides a Love token.
Thu, Jun 11, 5:08 PM · Cycles

Jun 4 2020

Simon (Shimoon) awarded D4255: Cycles: Added feature overrides a Love token.
Jun 4 2020, 3:41 PM · Cycles

Jun 2 2020

Stefan Werner (swerner) closed D7634: Cycles: Added shadow terminator offset parameter..
Jun 2 2020, 7:28 AM · Cycles
Stefan Werner (swerner) committed rBc7280ce65b85: Cycles: Added shadow terminator offset parameter. (authored by Stefan Werner (swerner)).
Cycles: Added shadow terminator offset parameter.
Jun 2 2020, 7:28 AM

May 29 2020

Alaska (Alaska) awarded D7634: Cycles: Added shadow terminator offset parameter. a Love token.
May 29 2020, 10:17 AM · Cycles
Stefan Werner (swerner) updated the diff for D7634: Cycles: Added shadow terminator offset parameter..
  • Addressed review comments.
May 29 2020, 10:03 AM · Cycles

May 28 2020

derek barker (lordodin) awarded D7634: Cycles: Added shadow terminator offset parameter. a Love token.
May 28 2020, 3:01 PM · Cycles
Stefan Werner (swerner) updated the diff for D7860: Cycles: Fix visiblity for volume objects. (#121).
  • Cycles: Full consistency between volume and ray visiblity.
May 28 2020, 2:16 PM · Cycles
Stefan Werner (swerner) added a comment to T72811: Smoke sim glitch in Cycles.

Sorry for the late reply.

May 28 2020, 9:36 AM · Render & Cycles, Cycles, BF Blender
Stefan Werner (swerner) added a comment to D7860: Cycles: Fix visiblity for volume objects. (#121).

As reference, this is what the scene looks like when every volume is visible to all rays. It is obvious that the object on the left, when set invisible to shadow rays, comes out much darker than it should.

May 28 2020, 9:21 AM · Cycles
Stefan Werner (swerner) added a comment to D7860: Cycles: Fix visiblity for volume objects. (#121).

Detailed description of the issue:
When maintaining the volume stack and tracking volume visibility at intersection level, we see problems when a path enters a volume as one kind of ray and leaves it as the other. It can happen that either an enter or leave event is missed and a volume is mistaken as either missing or infinite.

May 28 2020, 9:17 AM · Cycles
Stefan Werner (swerner) added inline comments to D7860: Cycles: Fix visiblity for volume objects. (#121).
May 28 2020, 9:06 AM · Cycles
Stefan Werner (swerner) updated the diff for D7860: Cycles: Fix visiblity for volume objects. (#121).

Fixed typo.

May 28 2020, 9:04 AM · Cycles
Stefan Werner (swerner) added reviewers for D7860: Cycles: Fix visiblity for volume objects. (#121): Brecht Van Lommel (brecht), Sergey Sharybin (sergey), Lukas Stockner (lukasstockner97).
May 28 2020, 8:59 AM · Cycles
Stefan Werner (swerner) requested review of D7860: Cycles: Fix visiblity for volume objects. (#121).
May 28 2020, 8:57 AM · Cycles

May 27 2020

Stefan Werner (swerner) committed rBecc15c55d4e2: Cycles: Upgraded Embree to version 3.10.0 (authored by Stefan Werner (swerner)).
Cycles: Upgraded Embree to version 3.10.0
May 27 2020, 10:13 AM
Stefan Werner (swerner) closed D7623: Cycles: Upgraded Embree to version 3.10.0.
May 27 2020, 10:13 AM · Cycles
Stefan Werner (swerner) updated the diff for D7623: Cycles: Upgraded Embree to version 3.10.0.

Updated comments.

May 27 2020, 9:31 AM · Cycles

May 18 2020

Stefan Werner (swerner) updated the diff for D7623: Cycles: Upgraded Embree to version 3.10.0.

Updated install_deps.sh to 3.10.0.

May 18 2020, 10:59 AM · Cycles
Stefan Werner (swerner) retitled D7623: Cycles: Upgraded Embree to version 3.10.0 from Cycles: Upgraded Embree to version 3.9.0 to Cycles: Upgraded Embree to version 3.10.0.
May 18 2020, 10:57 AM · Cycles
Stefan Werner (swerner) updated the diff for D7623: Cycles: Upgraded Embree to version 3.10.0.

Upgraded Embree to version 3.10.0

May 18 2020, 10:56 AM · Cycles
Jon Ross (zlsa) awarded D7634: Cycles: Added shadow terminator offset parameter. a Yellow Medal token.
May 18 2020, 1:57 AM · Cycles

May 11 2020

Stefan Werner (swerner) added a comment to T74581: Adaptive Sampling Improvements.

Cooperative groups in CUDA 9+ should allow GPUs with SM 6.0 and newer to do adaptive sampling at the same granularity as the CPU.

May 11 2020, 2:36 PM · Render & Cycles, Cycles

May 7 2020

Stefan Werner (swerner) added a comment to D7634: Cycles: Added shadow terminator offset parameter..

May 7 2020, 12:20 PM · Cycles
Stefan Werner (swerner) committed rB04a3bdcc524d: Blenlib: Added explicit BLI_INLINE in perlin noise. (authored by Stefan Werner (swerner)).
Blenlib: Added explicit BLI_INLINE in perlin noise.
May 7 2020, 10:04 AM

May 6 2020

Stefan Werner (swerner) retitled D7634: Cycles: Added shadow terminator offset parameter. from Cycles: Added shadow terminator offset paramter. to Cycles: Added shadow terminator offset parameter..
May 6 2020, 11:20 AM · Cycles
Stefan Werner (swerner) added a reviewer for D7634: Cycles: Added shadow terminator offset parameter.: Brecht Van Lommel (brecht).
May 6 2020, 11:20 AM · Cycles
Stefan Werner (swerner) added a comment to T68920: Reduce shadow terminator artifacts.

Updated patch at D7634

May 6 2020, 11:18 AM · Render & Cycles, Cycles, BF Blender
Stefan Werner (swerner) requested review of D7634: Cycles: Added shadow terminator offset parameter..
May 6 2020, 11:18 AM · Cycles

May 5 2020

Stefan Werner (swerner) added a comment to T73778: Cycles: default to Embree for CPU ray tracing.

See D7623 for thick line support in Embree 3.9.0.

May 5 2020, 1:01 PM · Render & Cycles, BF Blender (2.90), Cycles
Stefan Werner (swerner) added a comment to D7623: Cycles: Upgraded Embree to version 3.10.0.

This enables the thick lines mentioned as missing in T73778

May 5 2020, 1:00 PM · Cycles
Stefan Werner (swerner) added a comment to D7623: Cycles: Upgraded Embree to version 3.10.0.

Mentioned in T76184

May 5 2020, 12:59 PM · Cycles
Stefan Werner (swerner) added a reviewer for D7623: Cycles: Upgraded Embree to version 3.10.0: Brecht Van Lommel (brecht).
May 5 2020, 12:59 PM · Cycles
Stefan Werner (swerner) requested review of D7623: Cycles: Upgraded Embree to version 3.10.0.
May 5 2020, 12:57 PM · Cycles
Stefan Werner (swerner) added a comment to T73778: Cycles: default to Embree for CPU ray tracing.

Thick line segments are now supported in Embree 3.9.0.

May 5 2020, 9:44 AM · Render & Cycles, BF Blender (2.90), Cycles
Stefan Werner (swerner) added a comment to T76184: Library upgrades for 2.90.

I'd like to upgrade to Embree 3.9.0 as well, since it supports thick line segments for hair. I can provide a patch. If we're now settled on TBB being a requirement, it might also be worth it to turn on TBB support in Embree.

May 5 2020, 9:42 AM · Platforms, Builds & Tests, BF Blender (2.90)

Mar 10 2020

Stefan Werner (swerner) committed rB7c027f9480a9: Cycles: Fixed Shadow and Mist passes with adaptive sampling. (authored by Stefan Werner (swerner)).
Cycles: Fixed Shadow and Mist passes with adaptive sampling.
Mar 10 2020, 4:52 PM
Stefan Werner (swerner) committed rB811569dc11de: Cycles: Using OpenCL popcount() in PMJ sampler. (authored by Stefan Werner (swerner)).
Cycles: Using OpenCL popcount() in PMJ sampler.
Mar 10 2020, 8:53 AM
bartus sz (bartus) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mar 10 2020, 8:10 AM · Cycles, BF Blender (2.83)
ChameleonScales (Caetano) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mar 10 2020, 12:35 AM · Cycles, BF Blender (2.83)

Mar 9 2020

Eduardo (TWCSwagger) awarded D4686: Adaptive Sampling for Cycles. a Burninate token.
Mar 9 2020, 9:34 PM · Cycles, BF Blender (2.83)
Fran Marz (franMarz) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Party Time token.
Mar 9 2020, 2:32 PM

Mar 8 2020

Stefan Werner (swerner) added a comment to T74537: Adaptive sampling + AO color node crashes (when shader rays exceed 32K)..

rBbc6bbe5fac864ded3a00f4a50d5eb79f89b74c75

Mar 8 2020, 9:44 PM · BF Blender
Stefan Werner (swerner) closed T74537: Adaptive sampling + AO color node crashes (when shader rays exceed 32K). as Resolved.
Mar 8 2020, 9:43 PM · BF Blender
Stefan Werner (swerner) committed rBbc6bbe5fac86: Fix T74537: Fixed out of bounds memory access in Cycles' PMJ sampler. (authored by Stefan Werner (swerner)).
Fix T74537: Fixed out of bounds memory access in Cycles' PMJ sampler.
Mar 8 2020, 9:32 PM

Mar 7 2020

carlos puebla (negativecitizen) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Love token.
Mar 7 2020, 11:07 AM

Mar 6 2020

Lino Thomas (linolafett) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mar 6 2020, 7:23 PM · Cycles, BF Blender (2.83)
Stefan Werner (swerner) added a comment to T74423: CUDA 10.2 and GTX 1080 render artifacts with path tracing.

Reproduces with 1080Ti/CUDA 10.2 on Windows as well.

Mar 6 2020, 2:52 PM · Cycles, Render & Cycles, BF Blender
Lopo Isaac (lopoIsaac) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 6 2020, 9:50 AM
Simon (Shimoon) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Like token.
Mar 6 2020, 2:44 AM

Mar 5 2020

Maxim Ponomarov (ponomarovmax) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 5 2020, 10:53 PM
Stefan Werner (swerner) added a comment to T73201: New volume object type.

We're reviewing an in-house patch right now that's per-object (not per-shader) step size as a user parameter, not determined automatically at the moment. Rationale for per-object is that we tend to reuse the same shader for multiple VDB objects, which may have different resolutions and densities.

Mar 5 2020, 10:23 PM · Nodes & Physics, BF Blender
artem ivanov (ixd) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Like token.
Mar 5 2020, 9:52 PM
Matej Junk (MJunk) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Like token.
Mar 5 2020, 9:20 PM
Stefan Werner (swerner) added a comment to T74423: CUDA 10.2 and GTX 1080 render artifacts with path tracing.

CUDA 10.2 + PMJ commit shows the render error. CUDA 10.2 and any revision before the PMJ commit renders fine.

Mar 5 2020, 8:45 PM · Cycles, Render & Cycles, BF Blender
higgsas (higgsas) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Like token.
Mar 5 2020, 6:39 PM
ogierm (ogierm) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 5 2020, 6:29 PM
noki paike (amonpaike) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 5 2020, 5:21 PM
Metin Seven (MetinSeven) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Like token.
Mar 5 2020, 5:17 PM
Stefan Werner (swerner) changed the status of T74423: CUDA 10.2 and GTX 1080 render artifacts with path tracing from Needs Developer to Reproduce to Confirmed.
Mar 5 2020, 4:39 PM · Cycles, Render & Cycles, BF Blender
Stefan Werner (swerner) added a comment to T74423: CUDA 10.2 and GTX 1080 render artifacts with path tracing.

I plugged in my GTX 1080Ti and git blame points to the commit that brought the PMJ sampler:
https://developer.blender.org/rB409074aae56138f49ce078ce919a6d02e44e521e

Mar 5 2020, 4:29 PM · Cycles, Render & Cycles, BF Blender
Aditia A. Pratama (aditiapratama) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 5 2020, 3:47 PM
Stefan Werner (swerner) added a comment to D4686: Adaptive Sampling for Cycles..

It appears that I don't have a Wiki account yet, so I wasn't able to update the release notes.

Mar 5 2020, 3:24 PM · Cycles, BF Blender (2.83)
Stefan Werner (swerner) added a comment to T74423: CUDA 10.2 and GTX 1080 render artifacts with path tracing.

Does not reproduce for me either with RTX Q4000, CUDA V10.2.89, gcc version 7.4.0, Nvidia drivers 440.33.01.

Mar 5 2020, 2:41 PM · Cycles, Render & Cycles, BF Blender
Marco (nacioss) awarded rB51e898324de3: Adaptive Sampling for Cycles. a Burninate token.
Mar 5 2020, 1:05 PM
Stefan Werner (swerner) closed D4686: Adaptive Sampling for Cycles..
Mar 5 2020, 12:22 PM · Cycles, BF Blender (2.83)
Stefan Werner (swerner) committed rB51e898324de3: Adaptive Sampling for Cycles. (authored by Stefan Werner (swerner)).
Adaptive Sampling for Cycles.
Mar 5 2020, 12:22 PM
Juan (jc4d) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mar 5 2020, 7:51 AM · Cycles, BF Blender (2.83)