Page MenuHome

Stefan Werner (swerner)
User

Projects

User Details

User Since
Mar 31 2015, 9:29 AM (211 w, 2 d)

Recent Activity

Today

Stefan Werner (swerner) added a comment to D4704: Linking Embree Libraries Accordingly.

Whatever makes the compiler happy is fine with me.

Thu, Apr 18, 4:04 PM
Stefan Werner (swerner) updated the diff for D4686: Adaptive Sampling for Cycles..
  • Merge 'master' into 'cycles_adaptive_sampling'
  • Merge 'master' into 'cycles_adaptive_sampling'
  • Merge 'master' into 'cycles_adaptive_sampling'
Thu, Apr 18, 2:58 PM
Stefan Werner (swerner) committed rBffa55fbfdd7e: Merge 'master' into 'cycles_texture_cache' (authored by Stefan Werner (swerner)).
Merge 'master' into 'cycles_texture_cache'
Thu, Apr 18, 2:42 PM
Stefan Werner (swerner) committed rBcf6eb9a7f299: Merge 'master' into 'cycles_texture_cache' (authored by Stefan Werner (swerner)).
Merge 'master' into 'cycles_texture_cache'
Thu, Apr 18, 2:42 PM
Stefan Werner (swerner) committed rB6a5dc7124be7: Merge 'master' into 'cycles_texture_cache' (authored by Stefan Werner (swerner)).
Merge 'master' into 'cycles_texture_cache'
Thu, Apr 18, 2:42 PM

Yesterday

Antti Tikka (symstract) awarded D4686: Adaptive Sampling for Cycles. a Yellow Medal token.
Wed, Apr 17, 11:12 PM
Stefan Werner (swerner) updated subscribers of D4686: Adaptive Sampling for Cycles..

@Wo!262 (wo262) This scene looks like it needs a lot more samples. The adaptive sampler can only pick up and resolve noise that it finds within the "min samples" it takes - if those initial samples turn out all black, the sampler has no reason to continue sampling this seemingly uniform pixel.

Wed, Apr 17, 9:57 PM
Stefan Werner (swerner) updated the diff for D4686: Adaptive Sampling for Cycles..
  • Cycles: Fixed a typo in sample_is_even().
Wed, Apr 17, 9:14 AM
For (Forshu) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Wed, Apr 17, 8:09 AM

Tue, Apr 16

Daniel Salazar (zanqdo) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Tue, Apr 16, 10:51 PM
Jonathan Lampel (jonathanl) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Tue, Apr 16, 5:27 PM
Marcin Twarowski (Tvaroog) awarded D4686: Adaptive Sampling for Cycles. a Hungry Hippo token.
Tue, Apr 16, 9:01 AM
Alex (Alex108) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Tue, Apr 16, 8:54 AM
Duarte Farrajota Ramos (duarteframos) awarded D4686: Adaptive Sampling for Cycles. a Yellow Medal token.
Tue, Apr 16, 12:48 AM

Mon, Apr 15

Stefan Werner (swerner) added a comment to D4686: Adaptive Sampling for Cycles..

Pretty pictures for a more complex scene:

Mon, Apr 15, 10:40 PM
Stefan Werner (swerner) updated the diff for D4686: Adaptive Sampling for Cycles..

Cycles: Moved "Adaptive Sampilng" option out of the advanced section in the UI.

Mon, Apr 15, 9:08 PM
Luca Rood (LucaRood) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 9:07 PM
Lucas Boutrot (thornydre) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 8:50 PM
Stefan Werner (swerner) added a comment to D4686: Adaptive Sampling for Cycles..

I noticed I hadn't added documentation of the user facing parameters:

Mon, Apr 15, 8:46 PM
Benjamin Sauder (kioku) awarded D4686: Adaptive Sampling for Cycles. a Burninate token.
Mon, Apr 15, 8:09 PM
Marco G (marcog) awarded D4686: Adaptive Sampling for Cycles. a Mountain of Wealth token.
Mon, Apr 15, 7:36 PM
ogierm (ogierm) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 7:29 PM
Mandeep (mandeep) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 7:27 PM
Adam Friesen (ace_dragon) awarded D4686: Adaptive Sampling for Cycles. a Mountain of Wealth token.
Mon, Apr 15, 6:56 PM
Christian Friedrich (rbx775) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 6:51 PM
dorian (helloidonthaveanyideaformyusername) awarded D4686: Adaptive Sampling for Cycles. a Like token.
Mon, Apr 15, 5:14 PM
Emir Sinan Gürlek (filibis) awarded D4686: Adaptive Sampling for Cycles. a The World Burns token.
Mon, Apr 15, 4:44 PM
Jason Clarke (jtheninja) awarded D4686: Adaptive Sampling for Cycles. a Like token.
Mon, Apr 15, 4:44 PM
Julian Perez (julperado) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 4:07 PM
Steffen Dünner (SteffenD) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 3:52 PM
Irfan Celik (irfan) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 3:24 PM
Stefan Werner (swerner) added a comment to D4686: Adaptive Sampling for Cycles..

There isn't much to see, but we all enjoy pretty pictures:

Mon, Apr 15, 3:22 PM
Characterhero (TheCharacterhero) awarded D4686: Adaptive Sampling for Cycles. a Like token.
Mon, Apr 15, 3:11 PM
YAFU (YAFU) awarded D4686: Adaptive Sampling for Cycles. a Like token.
Mon, Apr 15, 2:47 PM
Matej Junk (MJunk) awarded D4686: Adaptive Sampling for Cycles. a Like token.
Mon, Apr 15, 2:33 PM
Wo!262 (wo262) awarded D4686: Adaptive Sampling for Cycles. a Love token.
Mon, Apr 15, 2:28 PM
Brecht Van Lommel (brecht) awarded D4686: Adaptive Sampling for Cycles. a Party Time token.
Mon, Apr 15, 2:11 PM
Stefan Werner (swerner) added a comment to D4686: Adaptive Sampling for Cycles..

This is substantial patch and obviously not intended for 2.80. There is still room for improvement, I hope to add more comments/documentation, deduplicate some code and take a closer look at the overall code style.

Mon, Apr 15, 2:08 PM
Stefan Werner (swerner) added reviewers for D4686: Adaptive Sampling for Cycles.: Brecht Van Lommel (brecht), Sergey Sharybin (sergey), Cycles.
Mon, Apr 15, 1:50 PM
Stefan Werner (swerner) created D4686: Adaptive Sampling for Cycles..
Mon, Apr 15, 1:49 PM
Stefan Werner (swerner) updated the diff for D4676: Cycles: Improved sampling for sphere lights..
  • Cycles: Added const to some variables.
Mon, Apr 15, 11:27 AM · Cycles
Stefan Werner (swerner) added a comment to D4676: Cycles: Improved sampling for sphere lights..

Both RenderMan and Arnold have sphere lights that emit to the outside only.
RenderMan render:

Mon, Apr 15, 10:48 AM · Cycles

Fri, Apr 12

Stefan Werner (swerner) added a comment to D4676: Cycles: Improved sampling for sphere lights..
Fri, Apr 12, 8:00 PM · Cycles
Stefan Werner (swerner) added a comment to D4676: Cycles: Improved sampling for sphere lights..

If desired, I can also change it to make the sphere a double-sided emitter by switching to uniform sampling when the shading point is inside the sphere (this is what PBRT does).

Fri, Apr 12, 4:15 PM · Cycles
Stefan Werner (swerner) added a comment to D4676: Cycles: Improved sampling for sphere lights..

There is a slight performance hit from the more complex sampling.
Haven't done extensive benchmarking, but a test scene I measured went from 58s -> 59s CPU render time.

Fri, Apr 12, 4:13 PM · Cycles
Stefan Werner (swerner) added a project to D4676: Cycles: Improved sampling for sphere lights.: Cycles.
Fri, Apr 12, 4:10 PM · Cycles
Stefan Werner (swerner) added a comment to D4676: Cycles: Improved sampling for sphere lights..

Before:

Fri, Apr 12, 4:09 PM · Cycles
Stefan Werner (swerner) created D4676: Cycles: Improved sampling for sphere lights..
Fri, Apr 12, 4:08 PM · Cycles

Fri, Mar 29

Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Added support for debug versions of OpenImageDenoise Windows DLLs.
Fri, Mar 29, 2:37 PM · Compositing
Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Compositor: More fixes for OIDN build on Windows.
Fri, Mar 29, 12:29 PM · Compositing
YAFU (YAFU) awarded D4304: Compositor: Added denoising node a Like token.
Fri, Mar 29, 2:53 AM · Compositing

Thu, Mar 28

Adam Friesen (ace_dragon) awarded D4304: Compositor: Added denoising node a Love token.
Thu, Mar 28, 8:57 PM · Compositing
Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Merge remote-tracking branch 'origin' into openimagedenoise
  • Merge branch 'master' of git.blender.org:blender into openimagedenoise
  • Fixed padding for OIDN node.
  • build_environemnt: Updated OpenImageDenoise to static 0.8.2
  • build_environment: OpenImageDenoise fixes for Linux and Windows.
  • build_environment: Fixed FindOpenImageDenoise.cmake.
  • build_environment: Fixed Windows build with static OpenImageDenoise.
Thu, Mar 28, 8:32 PM · Compositing

Fri, Mar 22

Viktor Mukayev (vitos1k) awarded D4304: Compositor: Added denoising node a Love token.
Fri, Mar 22, 1:18 PM · Compositing

Wed, Mar 20

Stefan Werner (swerner) added a comment to T62771: Cycles motion vector pass not synced correctly.

Nevermind, I wrote this up prematurely. Need to double-check things first.

Wed, Mar 20, 1:43 PM · Cycles, BF Blender
Stefan Werner (swerner) closed T62771: Cycles motion vector pass not synced correctly as Invalid.
Wed, Mar 20, 1:42 PM · Cycles, BF Blender
Stefan Werner (swerner) updated the task description for T62771: Cycles motion vector pass not synced correctly.
Wed, Mar 20, 1:42 PM · Cycles, BF Blender
Stefan Werner (swerner) added inline comments to rB01df4818a6e1: Fix Cycles curve UVs wrong after recent changes..
Wed, Mar 20, 1:34 PM
Stefan Werner (swerner) added a project to T62771: Cycles motion vector pass not synced correctly: Cycles.
Wed, Mar 20, 1:17 PM · Cycles, BF Blender
Stefan Werner (swerner) assigned T62771: Cycles motion vector pass not synced correctly to Brecht Van Lommel (brecht).
Wed, Mar 20, 1:17 PM · Cycles, BF Blender
Stefan Werner (swerner) created T62771: Cycles motion vector pass not synced correctly.
Wed, Mar 20, 1:17 PM · Cycles, BF Blender
Stefan Werner (swerner) committed rB69fb859909c8: Merge branch 'blender2.7' of git.blender.org:blender (authored by Stefan Werner (swerner)).
Merge branch 'blender2.7' of git.blender.org:blender
Wed, Mar 20, 12:52 PM
Stefan Werner (swerner) committed rB63cb78955153: Cycles: Made Embree ignore curve intersections with SSS. (authored by Stefan Werner (swerner)).
Cycles: Made Embree ignore curve intersections with SSS.
Wed, Mar 20, 12:49 PM
Stefan Werner (swerner) committed rB5eb38df4afac: Cycles: Performance optimization for Embree, resizing arrays once instead of… (authored by Stefan Werner (swerner)).
Cycles: Performance optimization for Embree, resizing arrays once instead of…
Wed, Mar 20, 12:49 PM

Mar 18 2019

Stefan Werner (swerner) raised a concern with rB9873005ecd7c: Cleanup: simplify kernel features definition..
Mar 18 2019, 3:16 PM
Stefan Werner (swerner) added a comment to rB9873005ecd7c: Cleanup: simplify kernel features definition..

This broke OpenCL/AMD on Windows. See inline comment.

Mar 18 2019, 2:40 PM

Mar 17 2019

arindam (Arindam) awarded rB47da8dcbcad4: Cycles: Improved thread order for better CUDA performance. a Like token.
Mar 17 2019, 1:40 PM

Mar 15 2019

Stefan Werner (swerner) added a comment to rB47da8dcbcad4: Cycles: Improved thread order for better CUDA performance..

For those who are using the scrambling distance patch, this change is trivial to remove. I haven't tested it myself yet, but I too would expect this to negate some of the performance benefits from the scramble distance patch.

Mar 15 2019, 1:54 PM

Mar 14 2019

Bohdan Lvov (ostapblender) awarded rB47da8dcbcad4: Cycles: Improved thread order for better CUDA performance. a Burninate token.
Mar 14 2019, 2:17 PM
Marco G (marcog) awarded rB47da8dcbcad4: Cycles: Improved thread order for better CUDA performance. a Love token.
Mar 14 2019, 1:38 PM
Stefan Werner (swerner) committed rBd8f1b18d9b74: Merge branch 'blender2.7' of git.blender.org:blender (authored by Stefan Werner (swerner)).
Merge branch 'blender2.7' of git.blender.org:blender
Mar 14 2019, 11:47 AM
Stefan Werner (swerner) committed rB47da8dcbcad4: Cycles: Improved thread order for better CUDA performance. (authored by Stefan Werner (swerner)).
Cycles: Improved thread order for better CUDA performance.
Mar 14 2019, 11:46 AM

Mar 13 2019

Stefan Werner (swerner) committed rB7be7f1a884cd: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Mar 13 2019, 2:09 PM

Mar 7 2019

Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

FYI, I'm waiting for Intel to release the next version of OIDN that can build as a static library.

Mar 7 2019, 4:08 PM · Compositing
Juan Gea (juang3d) awarded D4459: Cycles: Added fix for bump terminator problem. a Yellow Medal token.
Mar 7 2019, 9:26 AM · Cycles

Mar 6 2019

Stefan Werner (swerner) added a comment to D4459: Cycles: Added fix for bump terminator problem..

I'm not expecting this patch to land right away, this should probably undergo some wider testing before we can declare it safe.

Mar 6 2019, 11:48 AM · Cycles
Duarte Farrajota Ramos (duarteframos) awarded D4459: Cycles: Added fix for bump terminator problem. a Yellow Medal token.
Mar 6 2019, 11:39 AM · Cycles
Stefan Werner (swerner) added a comment to D4459: Cycles: Added fix for bump terminator problem..

Applying this to specular shaders introduces new artifacts, so it's only applied to diffuse BSDFs for now.

Mar 6 2019, 11:36 AM · Cycles
Stefan Werner (swerner) added a comment to D4459: Cycles: Added fix for bump terminator problem..

Mar 6 2019, 11:34 AM · Cycles
Stefan Werner (swerner) added a project to D4459: Cycles: Added fix for bump terminator problem.: Cycles.
Mar 6 2019, 11:33 AM · Cycles
Stefan Werner (swerner) added a comment to D4459: Cycles: Added fix for bump terminator problem..

This patch does not fix T37814.

Mar 6 2019, 11:32 AM · Cycles
Stefan Werner (swerner) created D4459: Cycles: Added fix for bump terminator problem..
Mar 6 2019, 11:31 AM · Cycles
Stefan Werner (swerner) added a comment to T37814: Artifacts in Cycles render for lowpoly models..

The fix in "Ray Tracing Gems" applies to a slightly different problem.

Mar 6 2019, 11:24 AM · BF Blender

Mar 5 2019

Stefan Werner (swerner) committed rB304a89eccfff: Cycles: Changed standalone XML parser to read UV as float2 (authored by Stefan Werner (swerner)).
Cycles: Changed standalone XML parser to read UV as float2
Mar 5 2019, 3:32 PM
Stefan Werner (swerner) committed rBc891fb2fbe99: Merge branch 'blender2.7' (authored by Stefan Werner (swerner)).
Merge branch 'blender2.7'
Mar 5 2019, 3:08 PM
Stefan Werner (swerner) committed rBdb7f9a70b0ad: Cycles: Added Float2 attribute type. (authored by Brecht Van Lommel (brecht)).
Cycles: Added Float2 attribute type.
Mar 5 2019, 2:55 PM
Stefan Werner (swerner) closed D4409: Cycles: Added Float2 attribute type..
Mar 5 2019, 2:55 PM · Cycles
Stefan Werner (swerner) added a comment to D4409: Cycles: Added Float2 attribute type..

Updated tangent space calculation and OSL attributes to use new float2 attributes.

Mar 5 2019, 11:53 AM · Cycles
Stefan Werner (swerner) updated the diff for D4409: Cycles: Added Float2 attribute type..
  • Cycles: Added Float2 attribute type.
  • Cycles: Fixed OSL support of float2 attributes.
  • Cycles: Fixed Tangents with float2 attributes.
Mar 5 2019, 11:47 AM · Cycles

Mar 2 2019

Stefan Werner (swerner) awarded D4393: Use static libstdc++ when making a static build a Love token.
Mar 2 2019, 12:52 PM

Mar 1 2019

Stefan Werner (swerner) committed rB1915b5338b4d: build_environment: Fixed `make deps` on macOS (authored by Stefan Werner (swerner)).
build_environment: Fixed `make deps` on macOS
Mar 1 2019, 10:02 AM

Feb 26 2019

cgslav (LukeD) awarded D4304: Compositor: Added denoising node a Love token.
Feb 26 2019, 10:35 AM · Compositing
Stefan Werner (swerner) added a comment to D4409: Cycles: Added Float2 attribute type..

This can save quite some memory. For example, the Agent 327 03_01_B shrinks its peak Mem from 10931MB to 10226MB, that is without this patch, Cycles is allocating >700MB of zeroes.

Feb 26 2019, 9:17 AM · Cycles
Stefan Werner (swerner) added a project to D4409: Cycles: Added Float2 attribute type.: Cycles.
Feb 26 2019, 9:15 AM · Cycles
Stefan Werner (swerner) created D4409: Cycles: Added Float2 attribute type..
Feb 26 2019, 8:52 AM · Cycles

Feb 20 2019

Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

What are you doing to get Albedo > 1? I didn't see that happen in my test scenes. Adding clamping to the albedo input will be easy though.

Feb 20 2019, 3:51 PM · Compositing

Feb 19 2019

Stefan Werner (swerner) added a comment to rB64671e53d20c: Build script: Don't use external Pugi for OSL.

Yes, reverting it allowed make deps to succeed.

Feb 19 2019, 10:06 AM
Stefan Werner (swerner) raised a concern with rB64671e53d20c: Build script: Don't use external Pugi for OSL.

This boke make depsfor me. When I test this on a brand new Ubuntu 16.04, OSL fails to find pugixml.

Feb 19 2019, 9:04 AM

Feb 9 2019

Juan Gea (juang3d) awarded D4304: Compositor: Added denoising node a Love token.
Feb 9 2019, 9:10 PM · Compositing

Feb 8 2019

Stefan Werner (swerner) added a comment to D4257: OpenMP support for macOS.

Yes, projects created with cmake -G Xcode create the datatoc and other binaries in a subdirectory named after the current inside bin.

Feb 8 2019, 9:06 AM