Stefan Werner (swerner)
User

Projects

User Details

User Since
Mar 31 2015, 9:29 AM (181 w, 4 d)

Recent Activity

Yesterday

Stefan Werner (swerner) committed rBb56be6e73cad: Cycles: Fixed swapped parameters in fresnel_dielectric(). (authored by Stefan Werner (swerner)).
Cycles: Fixed swapped parameters in fresnel_dielectric().
Fri, Sep 21, 4:24 PM
Stefan Werner (swerner) committed rBc174ad09f9b9: Cycles: Moved Texture caching options to their own subsection in the UI. (authored by Stefan Werner (swerner)).
Cycles: Moved Texture caching options to their own subsection in the UI.
Fri, Sep 21, 4:24 PM

Tue, Sep 18

Stefan Werner (swerner) raised a concern with rBd6e769d32e79: Cycles: Add reflection fix to Bump and Normal Map nodes.

The normals produced by this code don't always have unit length.

Tue, Sep 18, 10:34 AM

Mon, Sep 17

Stefan Werner (swerner) committed rB60da3f4ca61b: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Mon, Sep 17, 4:36 PM
Stefan Werner (swerner) added a comment to D2574: Cycles: Implement optional normal adjustment that ensures valid reflections for normal maps and bump maps.

Is it possible that this is missing a normalize() at the end? I'm seeng non-unit length normals being passed into the BSDFs now.
For example the classroom benchmark scene asserts with NaN pixels now.

Mon, Sep 17, 4:24 PM · Cycles

Sat, Sep 15

Stefan Werner (swerner) added a project to D3695: Cycles: Improved robustness of hair motion blur.: Cycles.
Sat, Sep 15, 12:22 AM · Cycles

Fri, Sep 14

Wo!262 (wo262) awarded D3695: Cycles: Improved robustness of hair motion blur. a Love token.
Fri, Sep 14, 9:34 PM · Cycles
Stefan Werner (swerner) added a reviewer for D3695: Cycles: Improved robustness of hair motion blur.: Cycles.
Fri, Sep 14, 7:04 PM · Cycles
Stefan Werner (swerner) updated the diff for D3695: Cycles: Improved robustness of hair motion blur..
  • Fixed whitespace.
Fri, Sep 14, 4:28 PM · Cycles
Stefan Werner (swerner) added a comment to D3695: Cycles: Improved robustness of hair motion blur..

Unfortunately, I have no .blend file to demonstrate this bug, at least not one that I could legally share.

Fri, Sep 14, 4:27 PM · Cycles
Stefan Werner (swerner) created D3695: Cycles: Improved robustness of hair motion blur..
Fri, Sep 14, 4:20 PM · Cycles
Stefan Werner (swerner) committed rB0a2b2d59a589: Cycles: Improved robustness of hair motion blur. (authored by Stefan Werner (swerner)).
Cycles: Improved robustness of hair motion blur.
Fri, Sep 14, 4:20 PM
Stefan Werner (swerner) added a comment to D3693: Blender 2.8: New Blender Cycles Client for dividing the workflow of rendering to three parts: Preprocessing (Blender), Rendering (Blender Client), Postprocessing (Blender).

Just skimming the code, I can't claim I fully comprehend it yet. A few thoughts:

Fri, Sep 14, 3:56 PM · BF Blender: 2.8

Mon, Sep 10

Stefan Werner (swerner) added a comment to D3682: Cycles: Embree integration.

All BVHs are going to give identical results, unless they're broken. Likewise, the differences between separate implementations of a given ray/triangle intersector (Möller–Trumbore, Woop, ...) will also only differ in floating point rounding. As long as we're compiling with fast-math turned on, our results will not be bit-perfect across compilers anyway. Hair curves have small differences (caps, self-intersection epsilon), if we need perfection we could just implement the same intersection everywhere (Embree and DXR/OptiX allow for user defined geometry).

Mon, Sep 10, 11:01 PM · Cycles
Stefan Werner (swerner) committed rB7a89fa4a8550: Cycles: Fixed some warnings. (authored by Stefan Werner (swerner)).
Cycles: Fixed some warnings.
Mon, Sep 10, 3:27 PM
Stefan Werner (swerner) updated the summary of D3682: Cycles: Embree integration.
Mon, Sep 10, 2:41 PM · Cycles
Stefan Werner (swerner) updated the summary of D3682: Cycles: Embree integration.
Mon, Sep 10, 2:40 PM · Cycles
Stefan Werner (swerner) retitled D3682: Cycles: Embree integration from Cycles: Laid some foundation for embree ray accelerator: flags, UI and CMake to Cycles: Embree integration.
Mon, Sep 10, 2:37 PM · Cycles
Stefan Werner (swerner) added a comment to D3682: Cycles: Embree integration.

Please disregard the excessive changes in platform_win32.cmake - that must have been a merge gone wrong.

Mon, Sep 10, 2:33 PM · Cycles
Stefan Werner (swerner) committed rB71f0f05cd52e: Merge branch 'cycles_embree' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'cycles_embree' of git.blender.org:blender into cycles_embree
Mon, Sep 10, 2:23 PM
Stefan Werner (swerner) committed rBd8da415d63b0: Cycles: Laid some foundation for embree ray accelerator: flags, UI and CMake (authored by Stefan Werner (swerner)).
Cycles: Laid some foundation for embree ray accelerator: flags, UI and CMake
Mon, Sep 10, 2:23 PM
Stefan Werner (swerner) added a reverting commit for rB3194e05d3f27: Cycles: Removed scaling from Embree's object motion blur.: rBd8da415d63b0: Cycles: Laid some foundation for embree ray accelerator: flags, UI and CMake.
Mon, Sep 10, 2:23 PM
Stefan Werner (swerner) added a reverting commit for rB151b5a9a1e56: Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows.: rBd8da415d63b0: Cycles: Laid some foundation for embree ray accelerator: flags, UI and CMake.
Mon, Sep 10, 2:23 PM
Stefan Werner (swerner) added a comment to D3682: Cycles: Embree integration.
Mon, Sep 10, 2:19 PM · Cycles
Stefan Werner (swerner) added reviewers for D3682: Cycles: Embree integration: Brecht Van Lommel (brecht), Sergey Sharybin (sergey), Lukas Stockner (lukasstockner97).
Mon, Sep 10, 2:04 PM · Cycles
Stefan Werner (swerner) added a reviewer for D3682: Cycles: Embree integration: Cycles.
Mon, Sep 10, 2:02 PM · Cycles
Stefan Werner (swerner) created D3682: Cycles: Embree integration.
Mon, Sep 10, 1:59 PM · Cycles
Stefan Werner (swerner) committed rB3c5d1076f4f6: Cycles: Some more cleanup/commenting for Embree integration. (authored by Stefan Werner (swerner)).
Cycles: Some more cleanup/commenting for Embree integration.
Mon, Sep 10, 1:52 PM

Tue, Sep 4

Stefan Werner (swerner) committed rB7099931eb5d6: Cycles: Some style fixes for Embree integration. (authored by Stefan Werner (swerner)).
Cycles: Some style fixes for Embree integration.
Tue, Sep 4, 9:14 PM

Mon, Sep 3

Stefan Werner (swerner) committed rB30d4bbcab3b0: Cycles: Some cleanup of Embree integration. (authored by Stefan Werner (swerner)).
Cycles: Some cleanup of Embree integration.
Mon, Sep 3, 2:18 PM

Fri, Aug 31

Stefan Werner (swerner) committed rB09d8466a3852: Cycles: Embree now traverses only the object subtree for local intersection… (authored by Stefan Werner (swerner)).
Cycles: Embree now traverses only the object subtree for local intersection…
Fri, Aug 31, 3:09 PM

Thu, Aug 30

Stefan Werner (swerner) committed rBf01ff46828cb: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Thu, Aug 30, 9:12 AM
Stefan Werner (swerner) committed rB2c4be65c0965: Cycles: Some more cleanup in Embree integration, added intersection filter to… (authored by Stefan Werner (swerner)).
Cycles: Some more cleanup in Embree integration, added intersection filter to…
Thu, Aug 30, 9:12 AM

Wed, Aug 29

Stefan Werner (swerner) committed rB5c91a90a7975: Cycles: Code style fixes for Embree, removing some unused data. (authored by Stefan Werner (swerner)).
Cycles: Code style fixes for Embree, removing some unused data.
Wed, Aug 29, 7:21 PM
Stefan Werner (swerner) committed rB889ce96b2eca: Cycles: Improved stability with Embree memory callback (authored by Stefan Werner (swerner)).
Cycles: Improved stability with Embree memory callback
Wed, Aug 29, 1:43 PM

Mon, Aug 27

Stefan Werner (swerner) committed rB07760d2cd442: Cycles: Switched Embree curves to Hermite basis. Unforunately, Embree 3.2.0 has… (authored by Stefan Werner (swerner)).
Cycles: Switched Embree curves to Hermite basis. Unforunately, Embree 3.2.0 has…
Mon, Aug 27, 10:56 PM
Stefan Werner (swerner) committed rB35e8d1e9f50f: Cycles: Code formatting in Embree integration. (authored by Stefan Werner (swerner)).
Cycles: Code formatting in Embree integration.
Mon, Aug 27, 10:56 PM

Fri, Aug 24

Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Some more updates, addressing Sergey's comments.

Fri, Aug 24, 12:00 AM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Code styling
  • Merge branch 'cycles_cryptomatte' of github.com:skwerner/blender into cycles_cryptomatte
Fri, Aug 24, 12:00 AM · Cycles

Thu, Aug 23

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Code styling
Thu, Aug 23, 10:51 PM · Cycles

Aug 23 2018

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Addressed Sergey's cryptomatte omments.
  • Cycles: Fixed OpenCL build
Aug 23 2018, 3:50 PM · Cycles

Aug 21 2018

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Fixed indentation.
Aug 21 2018, 2:17 PM · Cycles
Stefan Werner (swerner) committed rBd849092e1366: Cycles: Small fixes for Embree. (authored by Stefan Werner (swerner)).
Cycles: Small fixes for Embree.
Aug 21 2018, 2:13 PM

Aug 20 2018

Bartosz Moniewski (monio) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 20 2018, 10:54 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Fixed typos in Crytpomatte code.
Aug 20 2018, 2:18 PM · Cycles

Aug 17 2018

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: More Cryptomatte code review changes.
  • Cycles: Skip calls to CPU kernel coverage buffer when accurate cryptomatte layers are turned off.
Aug 17 2018, 8:51 PM · Cycles
Stefan Werner (swerner) added a comment to D2326: Disable compilation of sse2 and ssse3 kernels on MacOS.

I support this.

Aug 17 2018, 8:40 PM · Cycles

Aug 14 2018

Stefan Werner (swerner) committed rBa9700e7ad276: Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes. (authored by Stefan Werner (swerner)).
Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes.
Aug 14 2018, 10:52 PM
Stefan Werner (swerner) closed T56359: Blender 2.8 Alpha 2 - GPU Rendering in Cycles Crashes with dual AMD WX 7100 card setup... as Resolved by committing rBa9700e7ad276: Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes..
Aug 14 2018, 10:52 PM · BF Blender: 2.8, Cycles, Rendering
Stefan Werner (swerner) claimed T56359: Blender 2.8 Alpha 2 - GPU Rendering in Cycles Crashes with dual AMD WX 7100 card setup....
Aug 14 2018, 10:47 PM · BF Blender: 2.8, Cycles, Rendering
Manu Järvinen (maxon) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 14 2018, 9:08 PM · Cycles
Stefan Werner (swerner) committed rB94b7f17180c9: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Aug 14 2018, 2:51 PM
Stefan Werner (swerner) committed rB97d4e3f0e739: Cycles: Fixes for transparent shadows and SSS when using Embree. (authored by Stefan Werner (swerner)).
Cycles: Fixes for transparent shadows and SSS when using Embree.
Aug 14 2018, 2:51 PM

Aug 13 2018

Stefan Werner (swerner) added a comment to T56234: Artifacts when render in Hybrid mode in version 2.8.

I'm seeing CUDA renders on macOS giving wrong results starting with rBd611cf923358 (determined via git bisect, MBP Retina, 15-inch, Late 2013, GeForce GT 750M, Xcode 9.2, CUDA 9.2). The code in rBd611cf923358 looks innocent to me, may be that commit just exposed a compiler bug on macOS?

Aug 13 2018, 12:11 PM · Cycles, BF Blender

Aug 9 2018

Andrew Charlton (Scaredyfish) awarded D3538: Cycles: Added Cryptomatte passes. a 100 token.
Aug 9 2018, 7:02 AM · Cycles

Aug 5 2018

Tanguy Weyland (Tanguy) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 5 2018, 4:18 PM · Cycles

Aug 4 2018

Vitor Balbio (vitorbalbio) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 4 2018, 12:11 AM · Cycles

Aug 3 2018

Steffen Dünner (SteffenD) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 3 2018, 10:08 PM · Cycles
Bruno Ortolland (Noss) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Aug 3 2018, 9:37 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: A little refactor of the cryptomatte ID pass writting to reduce #ifdef clutter
  • Cycles: Removed PathState::matte_weight, using throughput instead for Cryptomatte
Aug 3 2018, 9:28 PM · Cycles
Stefan Werner (swerner) committed rB295944b49e45: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Aug 3 2018, 6:03 AM

Aug 2 2018

Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Addressed some of Sergey's comment.s

Aug 2 2018, 4:19 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
  • Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
  • Cycles: Implemented full sorting for Cryptomatte layers for all possible renderign devices.
  • Cycles: Refactoring to remove duplicate Cyryptomatte id pass code.
  • Cycles: Addressed some of Sergey's comments on D3538
  • Cycles: Stochastic cryptomatte writing now adds coverage to last ID when it runs out of slots.
Aug 2 2018, 4:07 PM · Cycles
Stefan Werner (swerner) committed rB7e25ad60517b: Set thread stack size on macOS to 1MB for Embree builds. (authored by Stefan Werner (swerner)).
Set thread stack size on macOS to 1MB for Embree builds.
Aug 2 2018, 4:04 PM
Stefan Werner (swerner) committed rB9ca5945934a9: Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with… (authored by Stefan Werner (swerner)).
Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with…
Aug 2 2018, 4:04 PM
Stefan Werner (swerner) added a reverting commit for rB151b5a9a1e56: Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows.: rB9ca5945934a9: Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with….
Aug 2 2018, 4:04 PM

Aug 1 2018

Stefan Werner (swerner) committed rB151b5a9a1e56: Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows. (authored by Stefan Werner (swerner)).
Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows.
Aug 1 2018, 11:02 PM
Stefan Werner (swerner) committed rB04ffa455a164: Cycles: Updated Embree integration to version 3.2 (authored by Stefan Werner (swerner)).
Cycles: Updated Embree integration to version 3.2
Aug 1 2018, 11:00 PM

Jul 30 2018

Stefan Werner (swerner) committed rBb59d85b5a56c: Cycles: Fixed OpenCL build. sqr(float4) is available on CUDA and CPU, but not… (authored by Stefan Werner (swerner)).
Cycles: Fixed OpenCL build. sqr(float4) is available on CUDA and CPU, but not…
Jul 30 2018, 3:42 PM

Jul 24 2018

Stefan Werner (swerner) created P756 Faster volume mesh generation.
Jul 24 2018, 11:06 AM · Cycles

Jul 23 2018

Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Without resorting to dynamic memory allocations inside the kernel or grossly over allocating memory, there will always be a chance of randomly skipped data.

Jul 23 2018, 12:19 PM · Cycles

Jul 20 2018

Rainer Trummer (aliasguru) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Jul 20 2018, 6:43 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 20 2018, 5:04 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Compile fixes for OpenCL kernel.
Jul 20 2018, 3:28 PM · Cycles
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

I think I found a way to write id passes using atomics.

Jul 20 2018, 12:32 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Cryptomatte writing now uses atomics on GPUs to avoid race conditions.
  • Cycles: Code style, fixed typos moving murmurhash to its own cpp file.
Jul 20 2018, 12:31 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 20 2018, 12:02 PM · Cycles

Jul 18 2018

Stefan Werner (swerner) committed rBbdda0964e0a5: Compositor: Cryptomatte compositing node. (authored by Stefan Werner (swerner)).
Compositor: Cryptomatte compositing node.
Jul 18 2018, 1:04 PM
Stefan Werner (swerner) closed D3531: Compositor: Cryptomatte compositing node..
Jul 18 2018, 1:03 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Reverted an accidental change.
Jul 18 2018, 1:02 PM · Compositing

Jul 16 2018

Stefan Werner (swerner) committed rBc29429bded85: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Jul 16 2018, 4:08 PM
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Fixed Cryptomatte string handling.
  • Compositor: Applied Brecht's UI improvements to Cryptomatte node
  • Compositor: Fixed broken add/remove in Cryptomatte node.
  • Compositor: Raised default number of Crypto inputs to three, as recommended by the Cryptomatte specification.
Jul 16 2018, 3:47 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Cryptomatte node now uses a dynamic string for matte ids, no more 1024 character limit.
Jul 16 2018, 1:00 PM · Compositing
Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

Cryptomatte output for Cycles is now in D3538

Jul 16 2018, 12:58 PM
Stefan Werner (swerner) added a project to D3538: Cycles: Added Cryptomatte passes.: Cycles.
Jul 16 2018, 12:56 PM · Cycles

Jul 13 2018

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Addressed Lukas' comments for Cryptomatte output.
Jul 13 2018, 2:51 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 13 2018, 2:38 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 13 2018, 2:16 PM · Cycles
Stefan Werner (swerner) added a comment to D3540: Cycles: Save a few instructions in area light sampling.

Looks good to me. The test renders I did didn't show any differences.

Jul 13 2018, 10:24 AM
Stefan Werner (swerner) added inline comments to D3540: Cycles: Save a few instructions in area light sampling.
Jul 13 2018, 9:01 AM

Jul 12 2018

Stefan Werner (swerner) added a comment to D3531: Compositor: Cryptomatte compositing node..

Cryptomatte support for Cycles is in D3538.

Jul 12 2018, 11:14 PM · Compositing
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Still to do:

Jul 12 2018, 11:13 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 12 2018, 11:12 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Fixed indentation.
Jul 12 2018, 11:08 PM · Cycles
Stefan Werner (swerner) updated subscribers of D3538: Cycles: Added Cryptomatte passes..

@Brecht Van Lommel (brecht) This patch changes array<Pass> back to vector<Pass>, as it was before you did some refactoring. Is that safe to do or are there dangers that I'm overlooking? Since I'd like Pass to contain a name string, it would be important that its destructor gets called.

Jul 12 2018, 11:05 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Fixed Cryptomatte pass names to match between Python and C++ code.
Jul 12 2018, 11:03 PM · Cycles
Stefan Werner (swerner) added a reviewer for D3538: Cycles: Added Cryptomatte passes.: Cycles.
Jul 12 2018, 11:00 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Code styling fixes for murmurhash.
Jul 12 2018, 10:58 PM · Cycles
Stefan Werner (swerner) created D3538: Cycles: Added Cryptomatte passes..
Jul 12 2018, 10:37 PM · Cycles

Jul 11 2018

Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

A Cryptomatte compositing node is in this patch: D3531

Jul 11 2018, 1:14 PM