- User Since
- Sep 12 2004, 3:45 PM (691 w, 4 d)
According to 533544117bf3 searching on user ID should work, but it doesn't in /u/ (even after reindexing users).
An IMO important thing to improve is to reduce the usage of dictionaries. In certain places, for example in the prepare_user_data() function, a dict is used where a class would be more suitable. This will immediately resolve many ambiguities; there are too many things that are now called "user":
For some reason a previous commit overwrote this patch and closed it, finally managed to force the diff back into Phabricator using arc diff --browse --update D2950.
Tue, Dec 12
@Nick Fox-Gieg (n1ckfg) this isn't related, please write a new bug report for this.
Mon, Dec 11
Sat, Dec 9
I agree with @LazyDodo (LazyDodo) on using BLI_strdup. The rest of the patch looks good, but I'd have to actually try it out with ASAN enabled to check it properly.
Fri, Dec 8
Updated on the Cloud too, all is now in production.
Thu, Dec 7
implemented in 017bbe32286c0bbfcadd862c31953d2ff081cd42, now needs this info on the Cloud too
and merged to master in dfc224d8a9fbc3466bafe58d55940093b40c6eed
Implemented in dfc224d8a9fbc3
This is no longer an issue, and when logged in shows the difference between "should renew" and "should buy new"