Page MenuHome

Grease PencilProject
ActivePublic

Details

Description

This project includes grease pencil drawing, editing, sculpting and all related to 2D animation module in Blender. Also contains the submodule Line Art related to generate grease pencil stroke drawing over 3D geometry (similar to FreeStyle).

Bug reports and patches are to be tagged with Grease Pencil

Status
The module is active. If you want to get involved, contact us (info below).

Members

Module owners: @Antonio Vazquez (antoniov) @Daniel Martinez Lara (pepeland)
Developers: @Antonio Vazquez (antoniov) @YimingWu (NicksBest) @Falk David (filedescriptor)
Artists: @Matias Mendiola (mendio) @Daniel Martinez Lara (pepeland) @Aleš Jelovčan (frogstomp)

SubprojectDevelopers
Line Art@YimingWu (NicksBest)

Important links

Contacts

Recent Activity

Today

Philipp Oeser (lichtwerk) closed T98226: Can't convert grease pencil to a path as Archived.

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed.

Fri, May 27, 11:13 AM · Grease Pencil, BF Blender
Omar Emara (OmarSquircleArt) removed projects from T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances.: Nodes & Physics, Geometry Nodes.
Fri, May 27, 9:51 AM · Line Art, Grease Pencil, BF Blender
YimingWu (NicksBest) claimed T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..

Hi! This is due to a recent change in how line art loads objects (which is still wrong but we don't have a viable way in terms of depsgraph usage, basically we can't actually iterate objects and instance during line art evaluation). I'm not that familiar with depsgraph to present a very solid solution for it, but there will be a solution to come.

Fri, May 27, 9:43 AM · Line Art, Grease Pencil, BF Blender
Omar Emara (OmarSquircleArt) added a comment to T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..

@Aleš Jelovčan (frogstomp) I think the point is that it used to work up until recently, so it is not an instinct limitation.

Fri, May 27, 9:29 AM · Line Art, Grease Pencil, BF Blender
Omar Emara (OmarSquircleArt) changed the status of T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances. from Needs Triage to Confirmed.

@YimingWu (NicksBest) Not sure if this is due to a change in LineArt or GN? Let me know if you want me to bisect.

Fri, May 27, 9:27 AM · Line Art, Grease Pencil, BF Blender
Aleš Jelovčan (frogstomp) added a comment to T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..

@Luciano Muñoz Sessarego (looch) this is expected behaviour. You need to use realize instances also if you want to use modifiers on geometry nodes outputs.

Fri, May 27, 9:26 AM · Line Art, Grease Pencil, BF Blender
Luciano Muñoz Sessarego (looch) added a comment to T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..

Yes that works, thanks !
but that's not the point tho. :)

Fri, May 27, 8:54 AM · Line Art, Grease Pencil, BF Blender
Aleš Jelovčan (frogstomp) added a comment to T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..

@Luciano Muñoz Sessarego (looch) try adding "realize instances" node before output

Fri, May 27, 8:34 AM · Line Art, Grease Pencil, BF Blender
Luciano Muñoz Sessarego (looch) updated the task description for T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..
Fri, May 27, 8:32 AM · Line Art, Grease Pencil, BF Blender
Luciano Muñoz Sessarego (looch) updated the task description for T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..
Fri, May 27, 8:32 AM · Line Art, Grease Pencil, BF Blender
Luciano Muñoz Sessarego (looch) updated the task description for T98424: Grease Pencil modifier "line art" won't draw objects with Geometry Nodes Instances..
Fri, May 27, 8:31 AM · Line Art, Grease Pencil, BF Blender

Yesterday

Antonio Vazquez (antoniov) closed T98236: Grease Pencil "Sample Simplify" not fully resampling closed strokes as Resolved.
Thu, May 26, 9:03 AM · Grease Pencil, BF Blender
Matthew Gafford (AFoxInSpace) added a comment to T98236: Grease Pencil "Sample Simplify" not fully resampling closed strokes.

@Aleš Jelovčan (frogstomp) Cancel that; my mistake. The problem is fixed in 3.3.0 .

Thu, May 26, 12:43 AM · Grease Pencil, BF Blender

Wed, May 25

Amélie Fondevilla (afonde) added a comment to T97477: Dope Sheet standard mode does not show Grease Pencil keyframes.

Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the animation-module channel on blender.chat. (I see that you asked that question there as well).

Wed, May 25, 3:54 PM · Grease Pencil, Animation & Rigging, BF Blender
Falk David (filedescriptor) added a comment to T97477: Dope Sheet standard mode does not show Grease Pencil keyframes.

Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the animation-module channel on blender.chat. (I see that you asked that question there as well).

Wed, May 25, 3:43 PM · Grease Pencil, Animation & Rigging, BF Blender
Amélie Fondevilla (afonde) added a comment to T97477: Dope Sheet standard mode does not show Grease Pencil keyframes.

I worked on the selection in dopesheet issue, and it seems to imply some changes in the current code, I kind of need advice and/or approval from both grease pencil and animation team on this.

Wed, May 25, 3:26 PM · Grease Pencil, Animation & Rigging, BF Blender
YimingWu (NicksBest) closed T98359: Regression: Crash switching to scene with LineArt as Resolved by committing rB53f7c220227a: Fix T98359: Handle object that has no feature lines..
Wed, May 25, 1:37 PM · Line Art, Grease Pencil, BF Blender
YimingWu (NicksBest) claimed T98359: Regression: Crash switching to scene with LineArt.

Missed a non-NULL check somewhere. I think I could just commit the fix.

Wed, May 25, 1:07 PM · Line Art, Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T98359: Regression: Crash switching to scene with LineArt.

This looks different. I'll check.

Wed, May 25, 12:56 PM · Line Art, Grease Pencil, BF Blender
Bastien Montagne (mont29) changed the subtype of T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy from "Report" to "Bug".
Wed, May 25, 11:25 AM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Bastien Montagne (mont29) moved T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy from Backlog to Other Modules Responsibility on the Core board.
Wed, May 25, 11:25 AM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Philipp Oeser (lichtwerk) renamed T98359: Regression: Crash switching to scene with LineArt from Crash switching to scene to Regression: Crash switching to scene with LineArt.
Wed, May 25, 10:18 AM · Line Art, Grease Pencil, BF Blender
Philipp Oeser (lichtwerk) triaged T98359: Regression: Crash switching to scene with LineArt as High priority.

Bisecting points to rB04ed96136bb2: Merge branch 'blender-v3.2-release' (which I doubt is really accurate/useful -- will double-check)

Wed, May 25, 10:18 AM · Line Art, Grease Pencil, BF Blender

Tue, May 24

Matthew Gafford (AFoxInSpace) added a comment to T98236: Grease Pencil "Sample Simplify" not fully resampling closed strokes.

@Aleš Jelovčan (frogstomp) Tested on both 3.2b and 3.3a with my Xp-Pen Deco03 tablet, and the bug is still there on both versions.

Tue, May 24, 8:05 PM · Grease Pencil, BF Blender
Falk David (filedescriptor) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

Ok yes this should no longer be necessary. If the transform updates are working, then we should remove this.

Tue, May 24, 2:20 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Antonio Vazquez (antoniov) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

I have tested and don't see any problem removing these lines.

Tue, May 24, 1:39 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Antonio Vazquez (antoniov) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

NO idea now....maybe it was something old that it was in the code by error. If you can do transformations and modifiers are working without these lines, I guess must be safe to remove it.

Tue, May 24, 1:32 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Falk David (filedescriptor) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

Ok so we now believe that the issue is here in /source/blender/blenkernel/intern/object_update.c:135:

/* Assign evaluated version. */
if ((ob->type == OB_GPENCIL) && (ob->runtime.gpd_eval != NULL)) {
  ob->data = ob->runtime.gpd_eval;
}

When commenting out these lines, that fixes the crash. We don't really understand these lines and why it just overwrites the ob->data pointer. @Antonio Vazquez (antoniov) Do you have any ideas?

Tue, May 24, 1:24 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Falk David (filedescriptor) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

@Antonio Vazquez (antoniov) I don't think this is related to the undo system. Right now it looks like for some reason ob->runtime.gpd_eval and ob->data point to the same thing after a copy-on-write. That's weird and shouldn't happen. We're trying to figure it out.

Tue, May 24, 11:36 AM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Philipp Oeser (lichtwerk) added projects to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy : Core, Restricted Project, Dependency Graph.
Tue, May 24, 11:09 AM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Antonio Vazquez (antoniov) updated subscribers of T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

Then maybe @Bastien Montagne (mont29) can help here with the Undo system.

Tue, May 24, 11:03 AM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Antonio Vazquez (antoniov) updated the diff for D14987: VSE: New Set Scene length base on Strip length.
  • Update after first review
Tue, May 24, 10:03 AM · Video Sequencer, Grease Pencil
Richard Antalik (ISS) added a comment to D14987: VSE: New Set Scene length base on Strip length.

@Peter Fog (tintwotin) is correct that if you change scene frame range, this is not reflected in scene strip(reverse of what is done in this patch) I have found D2322 that tried to fix this. In different patch I remember concern, that if sequencer using particular scene is in different .blend file, such automatic update would not work.

Tue, May 24, 2:06 AM · Video Sequencer, Grease Pencil

Mon, May 23

Falk David (filedescriptor) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

We couldn't identify anything that would point to the issue being in that part of the code. The data pointer of the object is NULL so it crashes there. It feels like our changes just revealed a previously hidden bug. We'll have to look more closely.

Mon, May 23, 10:59 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Bastien Montagne (mont29) closed T96878: When interface translation is enabled, grease pencil layer name is translated in menu as Resolved by committing rBec95f4a5dff9: Fix T96878: When interface translation is enabled, grease pencil layer name is….
Mon, May 23, 6:16 PM · Grease Pencil, Translations, BF Blender
Antonio Vazquez (antoniov) added a comment to T98253: Regression: Gpencil Lineart crashes Blender when undoing creation of linked copy .

@Falk David (filedescriptor) any update with this High priority bug?

Mon, May 23, 4:37 PM · Dependency Graph, Restricted Project, Core, Grease Pencil, Line Art, BF Blender
Antonio Vazquez (antoniov) closed D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 4:03 PM · Modifiers, Grease Pencil
Antonio Vazquez (antoniov) accepted D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 3:54 PM · Modifiers, Grease Pencil
Aleš Jelovčan (frogstomp) updated the diff for D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 3:50 PM · Modifiers, Grease Pencil
Aleš Jelovčan (frogstomp) updated the diff for D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 3:48 PM · Modifiers, Grease Pencil
Matias Mendiola (mendio) added a comment to D14965: Feature: GPencil - add Bounce option to Time offset modifier.

Nice feature! The term for this behavior is usually called Ping Pong.
Blender already uses that term for the animplayer feature (P key), but it's also a common term in other software.

Mon, May 23, 3:26 PM · Modifiers, Grease Pencil
Aleš Jelovčan (frogstomp) added a comment to D14965: Feature: GPencil - add Bounce option to Time offset modifier.

@Pablo Vazquez (pablovazquez) thanks for your comment. I'll prepare the patch. Do you have any other comments on the info text "Loop back and forth"?

Mon, May 23, 3:23 PM · Modifiers, Grease Pencil
Pablo Vazquez (pablovazquez) added a comment to D14965: Feature: GPencil - add Bounce option to Time offset modifier.

Nice feature! The term for this behavior is usually called Ping Pong.
Blender already uses that term for the animplayer feature (P key), but it's also a common term in other software.

Mon, May 23, 3:16 PM · Modifiers, Grease Pencil
Matias Mendiola (mendio) accepted D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 2:56 PM · Modifiers, Grease Pencil
Antonio Vazquez (antoniov) added a comment to D14965: Feature: GPencil - add Bounce option to Time offset modifier.

@Matias Mendiola (mendio) If you agree with the UI, we can approve the patch.

Mon, May 23, 2:13 PM · Modifiers, Grease Pencil
Daniel Martinez Lara (pepeland) accepted D14965: Feature: GPencil - add Bounce option to Time offset modifier.
Mon, May 23, 12:51 PM · Modifiers, Grease Pencil
Amélie Fondevilla (afonde) added a comment to T97477: Dope Sheet standard mode does not show Grease Pencil keyframes.

@Amélie Fondevilla (afonde) IIRC all icons definitions are done in anim_channels_defines.c

Mon, May 23, 11:27 AM · Grease Pencil, Animation & Rigging, BF Blender
Antonio Vazquez (antoniov) added a comment to T97477: Dope Sheet standard mode does not show Grease Pencil keyframes.

@Amélie Fondevilla (afonde) IIRC all icons definitions are done in anim_channels_defines.c

Mon, May 23, 10:28 AM · Grease Pencil, Animation & Rigging, BF Blender
YimingWu (NicksBest) closed T98258: GPencil: Double vertices after simplify with short sample length as Resolved by committing rBc4e5a7d59a06: Fix T98258: Duplicated last vertex after GPencil sample..
Mon, May 23, 10:19 AM · Grease Pencil, BF Blender
YimingWu (NicksBest) closed D15005: GPencil: Fix simplify->sample behavior.
Mon, May 23, 10:19 AM · Grease Pencil