I'm must confess that I'm not ready to give up on this yet... I've updated the space_sequencer.py according to the renaming in your version of the operator file:
If you want to edit the space_sequencer.py file from the Blender text-editor, several additional files needs to be loaded into the text editor to avoid errors. They are opened in this .blend:
Added tag for easier tracking
I could not resist to do a little experiment of jumpy panel: https://photos.app.goo.gl/dXQyg23Z5sTzJUVH6
To reproduce please follow T54117
Not sure how exactly reproduce the error, but from code it feels like you need to pass clip->flag instead of 0 to BKE_movieclip_get_ibuf_flag.
@Sergey Sharybin (sergey), can you review this?
I was looking at menu items,
Biggest problem are operators - many of them can be run with properties, that would contradict their description, or depends on selected sequences, etc...
Regarding the C core and Py shell idea: if we can contribute operators in Python, we'd work directly on Blender instead of our add-on Power Sequencer with my teammate Razvan. I'm in the middle of a Kickstarter campaign now so too busy to help, unfortunately, but we do all of our work with the VSE so we'd gladly contribute directly to Blender itself. 🙂
Thanks a lot for your work everyone!
Sun, Jan 20
Ctrl+drag playhead/strip will snap to next cut, so snapping with Ctrl pressed would be in consistency, but the default move should be without snapping.
- How to handle collisions? What should happen when you do ripple delete and attached effect in upper channel would collide into some strip?
- prevent execution and throw error?
- move as far as possible?
- configurable behavior?
When pasting, stips will be inserted into the first free channels, so maybe when strips are colliding they should be moved upwards into the first free channel(but only if it is effect-strips).
- What should be behavior of strip lock?
- prevent any modification other then changing lock state?
Yes, I think so too.
Another thing, that I wanted to tackle was displaying and modifying properties of selection.
- I was thinking about concept of active strip - my brain refuses to accept it's usefulness. Maybe because active strip is completely independent of selection.
Maybe all select-operators should ensure that the active strip is always the last selected strip, which it is when you select manually. The question is if you deselect all also should deselect the active strip(and close the strip properties panel?). That would be an understandable behavior, but I don't know if it will be annoying to have the panel open and close all the time?
- Alt + tweak value and alt + enter seems to work pretty well so nothing to do here I guess
I feel that info about the shift/ctrl/alt functions should be in the status bar and context-sensitive, so ex. when hovering over a checkbox is should say +alt will add values to entire selection(if that is not the default behavior).
Displaying properties of selection could be done better IMO.
- Ideally you want to display all properties of all types. Logical step would be group properties based on strip type
- use tab per type, so you can immediately see what types are selected and switch between them?
- Not sure, if we can show only values of fields that would be same for all selected strips of the same type, otherwise they could be blank or display some label like "varies".
I don't know if this is too much trouble for now? How does the 3D View deal with selections containing different types?
- when I change active strip to strip of different type(from movie to sound), panel organization is quite inconsistent.
- Don't know what we can do about this...
Yeah, the strips have quite individual settings, which makes it hard to avoid panels jumping around when changing type.
Poll should never be accessing collections/selection, it's called on drawing and will slowdown playback if it needs to build a list of many items only to check if a button should be greyed out.
This patch is getting to big to be able to review usefully.
@Richard Antalik (ISS) Thank you for investing so much time in this. The "space_sequencer.py" doesn't seem to be updated to reflect the changes in "sequencer.py"? When I replace these two files in a fresh build of Blender the entire UI is broken. So I can't test your changes.
@Richard Antalik (ISS), could you identify any of the changes here that'd be better done in C? (as TODO's in comments for eg).
Sat, Jan 19
Sorry, I didn't know that. My son was jumping around me when I updated the file, so I feel that there might be things unfinished. the main changes are the split-extract/lift/remove,operator, navigation - range-start/end menu. Will not do more for now.
@Peter Fog (tintwotin) I should say, that I am modifying these scripts, so please don't make very big changes.
Fri, Jan 18
Thu, Jan 17
Should be fixed in d3e856cd but I can't really test it. Please give it a try with a build bot build newer than this comment and check if it works there. If not, feel free to reopen this bug report!
Looking further into split operators SEQUENCER_OT_SplitExtract and SEQUENCER_OT_SplitLift duplicates functionality, with only one line difference: sequencer.ripple_delete / sequencer.delete_lift. This could be made into a single operator.
Thank you for updating the files. I can see the try/except wasn't removed in my Github, but they are removed now.
Can not reproduce even in 2.79
Maybe can you save blend file, with which This can be reproduced?
Tried to reproduce, however in output settings value of Video Codec item is empty.
What codec do you have set?
Updated patch based on latest version
Wed, Jan 16
Hello, sorry for lack of communication.
Re-assigning, as @Richard Antalik (ISS) is working on this.
I can still reproduce this in 2.80 bata -84c06e996a7a-
Tue, Jan 15
Mon, Jan 14
Fixed by 3610f1fc43d0
This seems to be a short-term, and patchy fix to Blender not being able to handle an ideal workflow. I really hope the idea of a "global" sequencer is being looked at by the Blender Foundation.
@Brecht Van Lommel (brecht) @Richard Antalik (ISS)
More fixes and comments here: https://github.com/tin2tin/blender_vse_reworked
Ex. View Channel Solo/All & Toggle All Modifiers have now been removed.
A lot has been fixed/addressed, but not yet everything.