Please always attach files which demonstrates the issue.
Wed, Dec 6
Note, a similar bug remains with the start of the strip - T53478
Tue, Dec 5
Mon, Dec 4
Thanks for the report, but this is a known limitation, see https://wiki.blender.org/index.php/Dev:Source/Development/Todo/Editors#Video_Sequencer
Thu, Nov 30
Wed, Nov 29
Thank you so much for this work! I love the concept of a unified and optimized image processing library used wherever needed in Blender.
Committed now, with some minor tweaks to the enum identifiers.
Sun, Nov 26
OCIO version 2.0 will have CL support.
Sat, Nov 25
@Peter Fog (tintwotin) Looks interesting, although it's using OpenGL instead of OpenCL. Fortunately many algorithms are (often) easy to port between the two in case someone wants to.
Updated Diff with the changes requested by @Sybren A. Stüvel (sybren) .
Fri, Nov 24
Great project! Are you aware of the Movit-lib which generates video effects on the GPU? https://git.sesse.net/?p=movit;a=summary
Thu, Nov 23
Anything that can increase VSE performance is a huge blessing. Thank you!
Wed, Nov 22
@Germano Cavalcante (mano-wii) Thanks. Blur is probably the best case scenario for OpenCL, many other effects probably wont gain so much speedup. Maybe glow would be another one to benefit a lot. In the wiki sequencer doesn't seem to have a module owner at all, but Sergey did already notice this.
Nice to see activity in this field! Would be nice to have some common fundametals used by both compositor and sequencer.
Woow, 19 times faster!! That deserves attention
Tue, Nov 21
Can we move forward with the review now? Also this might be beyond this patch but the old blend strips should be removed and versioning code to replace the strip with this new one with the correct mode.
Mon, Nov 20
@Dalai Felinto (dfelinto) to add to my (updated) comment above about adding docs to revision summaries instead of google doc - I just realized I can edit the phab task summaries directly (learning new things everyday lol), so if that's OK with you guys - maybe I can just add details / pics to the actual task summaries instead moving forward?
Hi @Dalai Felinto (dfelinto) - I dropped patches for this and T52586. Let me know if you see anything I need to change! I'll gonna throw together a small google doc capturing the usage / high-level feature reqs and drop a link later this week.
Wed, Nov 15
Not a bug.
Changed to BLI_INLINE.
Tue, Nov 14
Use BLI_INLINE, it seems more commonly used for this type of thing.
Mon, Nov 13
Is anybody still watching this? Did you try downloading the torrent?
Sun, Nov 12
Nov 9 2017
Did you try BLI_INLINE specifically, which expands to static inline __attribute__((always_inline)) __attribute__((__unused__))?
@Brecht Van Lommel (brecht) : thanks for validating the compiler version, maybe someone should update the blender wiki then!
If you define the function receiving the function pointer with BLI_INLINE , older compiler versions will likely work fine as well.
IMHO It seems to me that building in a higher gcc version would be a feasible solution addressing the code readability problem and performance at same time. If its not the case, maybe opening an exception to use macros here would be the less of two evils.
Nov 5 2017
- Does this jive with what you were thinking?
Nov 3 2017
Hey guys - ok, so it looks like right now the only engine it uses is Eevee and the settings are all out of wack atm in 2.8 (which seems like what you were saying here)... want to confirm a couple things with you in terms of requirements:
Nov 2 2017
@Sergey Sharybin (sergey): the only two clean solutions would be:
I do not see how code-generate rather a huge function using a macro considered a good solution. This is most horrible solution from maintainability point of view. Just pass color function as a functor.
@Sybren A. Stüvel (sybren): because that doesn't work.
I don't like the code generation with macro's. Why not use higher-order functions and pass function pointers instead?
Nov 1 2017
I'm happy with the macro solution.
Hi guys, just assigning this to me so other ppl know and we don't duplicate effort :)
Just updated the code to also add the last two effects from BLI_math_color_blend.h (difference and exclusion), also fixed a bug: the ColorMix effect wasn't being serialized on saving.
Oct 31 2017
Oct 30 2017
@ideasman42 I like this, and this should probably be the default (imagine 20 strips and trying to tweak the volumetric sample of all of them and keep them in sync).