hi guys, i know this thread is old and a 'known issue' but i've got something even worse to add on to this. i've attached a blend file where freestyle is generating lines, where there is NO LINE to be drawn. Not hidden/occluded edges, not boolean based edges, but lines where there is no boundary, edge, contour, or crease at all. these lines are just popping up out of no-where at all. i'm really confused.

the problem is still present in version 3.1.2. Any news on the horizon?
thank you

In D14434#386649, @Brecht Van Lommel (brecht) wrote:

@Yuki Hashimoto (hzuika), what's the reason behind these Freestyle cleanups?

This code is mostly unmaintained without any active development. Cleanups can help with development, but if that's not happening it mainly risks breaking things, so it's not obvious why this is worth spending time on.

@Yuki Hashimoto (hzuika), what's the reason behind these Freestyle cleanups?

Then it's probably good to remove... These should be available on freestyle's website anyway if we need to use them for some purposes.

In D14434#386336, @YimingWu (NicksBest) wrote:

Will those scripts be usable if it's included? like brush/patterns presets and stuff? I think it might just be the installation didn't include them?

Will those scripts be usable if it's included? like brush/patterns presets and stuff? I think it might just be the installation didn't include them?

I have a small update:
when svg-export is enabled there are all expected lines in the svg-output. in the png-version the lines are still missing.

There are some News. I tested the same szene in 2.93 -> not working
in 2.83 -> works fine

Gotta say, I do fine myself wanting to have a WITH_PRECOMPILED_HEADERS option now. I can see that I can disable them differently if I want to, but it's less straight forward. Main reasons why I'd like to have it are:

• Makes it easier to turn them on and off to measure the compile time impact.
• Makes it easier to find the places where we use precompiled headers already. To be fair, that might be because I didn't remember target_precompile_headers yet, which I can search for to find the places. Usually when I try to find my way around in cmake I follow the usage of flags like WITH_UNITY_BUILD.

Agree we can turn this on by default.

• Cleanup: remove custom cmake option, simplify check

After some further studying of the docs. You can disable the precompiled headers with CMAKE_DISABLE_PRECOMPILE_HEADERS already, so there's no need to have our own option, so the Option can go, However i do like having a single variable one can check if cmake supports it and i do not like sprinkling if (cmake version atleast yaydyayada) everywhere.

MSVC added PCH support in 6.0 (1998), GCC in 3.4 (2004), clang in 2.5 (2009) now if PCH's were a brand new experimental feature i could see us being conservative and turning the option off by default, but lets be honest, 13-24 years should be enough to work out any issues for compiler builders. We're not the first project to use them, nor the biggest (both UE4/5 and QT use them) we had them on for windows (with no option) since early 2019, it's not some cutting edge new technology.

@Brecht Van Lommel (brecht), if I understand you correctly you are saying that if it builds and runs with and without precompiled headers on Windows, macOS and Linux it will build on every OS/distro.
I am saying that that there will be OS/distro releases where the build with precompiled headers will not work but the build without precompiled headers will work.

In D13797#365577, @Michael (michael64) wrote:

This feature is great but there will be build failures on some systems because of it.
Therefore I'd like to support this diff to be included as soon as possible but with a default value of OFF.

Thank you @Aaron Carlisle (Blendify), this is very useful, I could use compilation speedup badly
and if nobody else volunteers I'd might try adding some target_precompile_headers directives
to various parts of Blender myself.
But just I have no problem with adding -DWITH_COMPILER_CCACHE:BOOL=ON
to my builds I won't mind adding -DWITH_PRECOMPILE_HEADERS:BOOL=ON
as well.

That's nice to have precompiled support on all platforms.
Not sure why it needs to be option though. If anything, detect old CMake and automatically not use it there.

Revert Compositor PCH

• Cleanup: Compositor: Use precompiled headers

Buildbot: https://builder.blender.org/admin/#/builders/18/builds/262