Changes requsted except subpanel as subpanel depth is a problem, also they can't be reordered if they become subpanels.
Was there a reason you moved the draw_modifier functions to there own function?
This is getting a lot closer from my POV.
Sat, Apr 3
Apologies for delay, I updated the patch @Aaron Carlisle (Blendify)
Requested change done, except 2 for reasons.
Apologies for delay, here's the new diff with required changes, except the two mentioned for reasons
Mon, Mar 29
@YimingWu (NicksBest) Congrats on patch landing ! (pun intended :)
Sun, Mar 28
Wed, Mar 24
Fri, Mar 19
I can also confirm that the same is true when excluding collections (as opposed to including them). Only the objects at the top level in the excluded collection are excluded from freestyle stroke rendering, any objects in any collections within the excluded collection are included in the render.
Wed, Mar 17
Updated to include the manual page created for line art.
Tue, Mar 16
The grease pencil area LGTM
Mon, Mar 15
Cleaned up the comments and clarified code path.
Mar 12 2021
Updated for minor fixes, including function naming, baking UI and more efficient code path.
Minor fix to the description string in one of the operators.
Updated for latest code. This version is supposed to be stable in operations
Mar 11 2021
If you want to look at the modifiers now, a lot of them need updates to add layout.use_property_split and decorators
Mar 10 2021
I made suggestions for some overall changes, next we can have a look at modifiers.
Mar 6 2021
@Aaron Carlisle (Blendify) what changes should be made next?
Mar 2 2021
Mar 1 2021
Feb 28 2021
Feb 12 2021
Cleaned up the code further.
I'll update the code to the latest version.
Feb 8 2021
I can confirm this issue on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-08 10:36, hash: rBecfd5360a187. The console shows an error:
Feb 2 2021
For everyone's info:
I just want to say that I don't agree with the tone used by @WK Bong (lightbwk).
Although, at the same time, has proven to be effective. 😕
Feb 1 2021
If you want to have a discussion about the development process, developer.blender.org code reviews are not the place, we stay strictly on topic here.
This fell through the cracks after the initial update, after the latest update from @Miguel Pozo (pragma37) I put it on my todo list to review and commit.
There are hundreds of patches open for review. It usually helps reaching out in person to active developers and see if they can help.
I did that for you now btw.
I and a few hundreds other paid for this development and we demand this patch to get accepted.
Plus I have to be frank, artists are puzzled with the lack of enthusiast from the core devs when it comes to NPR features.
This is not a lot of code. The sooner this get accepted, the less people like me will complain about this inaction.
Jan 26 2021
@Brecht Van Lommel (brecht) Could we get this into master?
I've updated the patch with the changes needed.
Jan 22 2021
Linked Copy and Fully Copy do copy the view layers and associated lineset for me.
That makes sense but should not full scene copy also copy those settings to the new scene? That seems to be the main confusion I personally had.
Jan 21 2021
Jan 20 2021
The default scene comes with a freestyle lineset, but a new empty scene or new empty view does not have one.
Jan 12 2021
Did this ever make it into Master. Can Freestyle use Eevee? Is it any faster? Can it be made 'multi-threaded' or reserve the Cache to allow Edits to Styles and Re-Render?? Blender needs a more robust Line Rendering solution!!