blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 745 Projects 19 Wiki Activity

New depsgraph: Optimize updates flush 

Previously it was possible that same component will be tagged for update
again and again, making update flushing really slow. Now we'll store flag
whether component was fully tagged.

This is still temporary solution because ideally we should just support
partial updates, but that's for the future.

Gives around 10% speedup on file from jpbouza.
This commit is contained in:
Sergey Sharybin 2015-10-29 14:14:09 +05:00
parent a15a3952f4
commit 0e80d0893f
3 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/depsgraph/intern/depsgraph_tag.cc
View File

@ -284,6 +284,7 @@ void DEG_graph_flush_updates(Main *bmain, Depsgraph *graph)
{
OperationDepsNode *node = *it;
node->scheduled = false;
node->owner->flags &= ~DEPSCOMP_FULLY_SCHEDULED;
}
FlushQueue queue;
@ -353,12 +354,16 @@ void DEG_graph_flush_updates(Main *bmain, Depsgraph *graph)
* witin a component at least we tag the whole component
* for update.
*/
for (ComponentDepsNode::OperationMap::iterator it = node->owner->operations.begin();
it != node->owner->operations.end();
++it)
{
OperationDepsNode *op = it->second;
op->flag |= DEPSOP_FLAG_NEEDS_UPDATE;
ComponentDepsNode *component = node->owner;
if ((component->flags & DEPSCOMP_FULLY_SCHEDULED) == 0) {
for (ComponentDepsNode::OperationMap::iterator it = component->operations.begin();
it != node->owner->operations.end();
++it)
{
OperationDepsNode *op = it->second;
op->flag |= DEPSOP_FLAG_NEEDS_UPDATE;
}
component->flags |= DEPSCOMP_FULLY_SCHEDULED;
}
}
}

3
source/blender/depsgraph/intern/depsnode_component.cc
View File

@ -50,7 +50,8 @@ extern "C" {
ComponentDepsNode::ComponentDepsNode() :
entry_operation(NULL),
exit_operation(NULL)
exit_operation(NULL),
flags(0)
{
}

8
source/blender/depsgraph/intern/depsnode_component.h
View File

@ -46,6 +46,12 @@ struct EvaluationContext;
struct OperationDepsNode;
struct BoneComponentDepsNode;
typedef enum eDepsComponent_Flag {
/* Temporary flags, meaning all the component's operations has been
* scheduled for update.
*/
DEPSCOMP_FULLY_SCHEDULED = 1,
} eDepsComponent_Flag;
/* ID Component - Base type for all components */
struct ComponentDepsNode : public DepsNode {
@ -146,6 +152,8 @@ struct ComponentDepsNode : public DepsNode {
OperationDepsNode *exit_operation;
// XXX: a poll() callback to check if component's first node can be started?
int flags;
};
/* ---------------------------------------- */