OpenSubdiv: Add TODO avoid checking face-varying topology for equality

This commit is contained in:
Sergey Sharybin 2020-05-19 16:38:31 +02:00
parent 8e9fdd2f31
commit 12c42738f3
1 changed files with 6 additions and 0 deletions

View File

@ -76,6 +76,10 @@ bool checkPreliminaryMatches(const TopologyRefinerImpl *topology_refiner_impl,
////////////////////////////////////////////////////////////////////////////////
// Compare attributes which affects on topology.
//
// TODO(sergey): Need to look into how auto-winding affects on face-varying
// indexing and, possibly, move to mesh topology as well if winding affects
// face-varyign as well.
bool checkSingleUVLayerMatch(const OpenSubdiv::Far::TopologyLevel &base_level,
const OpenSubdiv_Converter *converter,
@ -136,6 +140,8 @@ bool TopologyRefinerImpl::isEqualToConverter(const OpenSubdiv_Converter *convert
return false;
}
// NOTE: Do after geometry check, to be sure topology does match and all
// indexing will go fine.
if (!blender::opensubdiv::checkTopologyAttributesMatch(this, converter)) {
return false;
}