blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix New Boolean bug that left some stray vertices. 

The routine to find dissolvable vertices had a check to ensure
that the vertex was exactly in line with the two neighbors.
I have convinced myself that this check is unneccesary (it was
failing with only a 1e-9 difference from 0 on a cross check),
so have removed it.
This commit is contained in:
Howard Trickey 2020-10-09 10:30:26 -04:00
parent 14c53c5018
commit 16ca295278
Notes: blender-bot 2023-09-13 08:48:34 +02:00 
Referenced by issue #80310, Exact boolean leaves behind odd vertices once Applied
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/blenlib/intern/mesh_boolean.cc
View File

@ -3113,16 +3113,8 @@ static Array<bool> find_dissolve_verts(IMesh &imesh_out, int *r_count_dissolve)
const std::pair<const Vert *, const Vert *> &nbrs = neighbors[v_out];
if (nbrs.first != nullptr) {
BLI_assert(nbrs.second != nullptr);
const mpq3 &co1 = nbrs.first->co_exact;
const mpq3 &co2 = nbrs.second->co_exact;
const mpq3 &co = imesh_out.vert(v_out)->co_exact;
mpq3 dir1 = co - co1;
mpq3 dir2 = co2 - co;
mpq3 cross = mpq3::cross(dir1, dir2);
if (cross[0] == 0 && cross[1] == 0 && cross[2] == 0) {
dissolve[v_out] = true;
++count;
}
dissolve[v_out] = true;
++count;
}
}
}