blender
/
blender
136
406
Fork 587
Code Issues 6.2k Pull Requests 755 Projects 19 Wiki Activity

Cleanup: Compilation warning about virtual functions 

Method which overrides a base class's virtual methods are expetced to
be marked with `override`. This also gives better idea to the developers
about what is going on.
This commit is contained in:
Sergey Sharybin 2022-04-07 17:14:47 +02:00
parent 9db15f502c
commit 1a09024eac
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/blenlib/BLI_virtual_array.hh
View File

@ -295,7 +295,7 @@ template<typename T> class VArrayImpl_For_Span : public VMutableArrayImpl<T> {
return data_ == other_span.data();
}
void materialize_compressed(IndexMask mask, MutableSpan<T> r_span) const
void materialize_compressed(IndexMask mask, MutableSpan<T> r_span) const override
{
mask.to_best_mask_type([&](auto best_mask) {
for (const int64_t i : IndexRange(best_mask.size())) {
@ -304,7 +304,8 @@ template<typename T> class VArrayImpl_For_Span : public VMutableArrayImpl<T> {
});
}
void materialize_compressed_to_uninitialized(IndexMask mask, MutableSpan<T> r_span) const
void materialize_compressed_to_uninitialized(IndexMask mask,
MutableSpan<T> r_span) const override
{
T *dst = r_span.data();
mask.to_best_mask_type([&](auto best_mask) {

4
source/blender/blenlib/intern/generic_virtual_array.cc
View File

@ -279,12 +279,12 @@ class GVArrayImpl_For_SingleValueRef : public GVArrayImpl {
type_->fill_construct_indices(value_, dst, mask);
}
void materialize_compressed(const IndexMask mask, void *dst) const
void materialize_compressed(const IndexMask mask, void *dst) const override
{
type_->fill_assign_n(value_, dst, mask.size());
}
void materialize_compressed_to_uninitialized(const IndexMask mask, void *dst) const
void materialize_compressed_to_uninitialized(const IndexMask mask, void *dst) const override
{
type_->fill_construct_n(value_, dst, mask.size());
}