blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 761 Projects 19 Wiki Activity

Fix T65660 Mirror modifier didn't work with custom normals.

This commit is contained in:
Howard Trickey 2019-06-18 10:07:53 -04:00
parent c8e3fe608e
commit 1a9e698099
Notes: blender-bot 2023-02-14 10:11:54 +01:00 
Referenced by commit 47b95a2957, Fix T70561: bad custom normals in mirrored geometry.
Referenced by issue #66862, Mirror Modifiers + Curve crash
Referenced by issue #65660, Bevel modifier  harden normals Weird when add mirror modifier
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
source/blender/modifiers/intern/MOD_mirror.c
View File

@ -334,6 +334,67 @@ static Mesh *doMirrorOnAxis(MirrorModifierData *mmd,
}
}
/* handle custom split normals */
if ((((Mesh *)ob->data)->flag & ME_AUTOSMOOTH) &&
CustomData_has_layer(&result->ldata, CD_CUSTOMLOOPNORMAL)) {
const int totloop = result->totloop;
const int totpoly = result->totpoly;
float(*loop_normals)[3] = MEM_calloc_arrayN((size_t)totloop, sizeof(*loop_normals), __func__);
CustomData *ldata = &result->ldata;
short(*clnors)[2] = CustomData_get_layer(ldata, CD_CUSTOMLOOPNORMAL);
MLoopNorSpaceArray lnors_spacearr = {NULL};
float(*poly_normals)[3] = MEM_mallocN(sizeof(*poly_normals) * totpoly, __func__);
/* calculate custom normals into loop_normals, then mirror first half into second half */
BKE_mesh_calc_normals_poly(result->mvert,
NULL,
result->totvert,
result->mloop,
result->mpoly,
totloop,
totpoly,
poly_normals,
false);
BKE_mesh_normals_loop_split(result->mvert,
result->totvert,
result->medge,
result->totedge,
result->mloop,
loop_normals,
totloop,
result->mpoly,
poly_normals,
totpoly,
true,
mesh->smoothresh,
&lnors_spacearr,
clnors,
NULL);
/* mirroring has to account for loops being reversed in polys in second half */
mp = result->mpoly;
for (i = 0; i < maxPolys; i++, mp++) {
MPoly *mpmirror = result->mpoly + maxPolys + i;
int j;
for (j = mp->loopstart; j < mp->loopstart + mp->totloop; j++) {
int mirrorj = mpmirror->loopstart;
if (j > mp->loopstart)
mirrorj += mpmirror->totloop - (j - mp->loopstart);
copy_v3_v3(loop_normals[mirrorj], loop_normals[j]);
loop_normals[mirrorj][axis] = -loop_normals[j][axis];
BKE_lnor_space_custom_normal_to_data(
lnors_spacearr.lspacearr[mirrorj], loop_normals[mirrorj], clnors[mirrorj]);
}
}
MEM_freeN(poly_normals);
MEM_freeN(loop_normals);
BKE_lnor_spacearr_free(&lnors_spacearr);
}
/* handle vgroup stuff */
if ((mmd->flag & MOD_MIR_VGROUP) && CustomData_has_layer(&result->vdata, CD_MDEFORMVERT)) {
MDeformVert *dvert = (MDeformVert *)CustomData_get_layer(&result->vdata, CD_MDEFORMVERT) +