blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 747 Projects 19 Wiki Activity

Geometry Nodes: skip attribute conversion if src and dst are the same

This commit is contained in:
Jacques Lucke 2021-04-20 11:17:27 +02:00
parent 27cfc1ea11
commit 2125ee4305
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
source/blender/nodes/geometry/nodes/node_geo_attribute_convert.cc
View File

@ -66,6 +66,28 @@ static AttributeDomain get_result_domain(const GeometryComponent &component,
return ATTR_DOMAIN_POINT;
}
static bool conversion_can_be_skipped(const GeometryComponent &component,
const StringRef source_name,
const StringRef result_name,
const AttributeDomain result_domain,
const CustomDataType result_type)
{
if (source_name != result_name) {
return false;
}
ReadAttributePtr read_attribute = component.attribute_try_get_for_read(source_name);
if (!read_attribute) {
return false;
}
if (read_attribute->domain() != result_domain) {
return false;
}
if (read_attribute->cpp_type() != *bke::custom_data_type_to_cpp_type(result_type)) {
return false;
}
return true;
}
static void attribute_convert_calc(GeometryComponent &component,
const GeoNodeExecParams &params,
const StringRef source_name,
@ -78,6 +100,10 @@ static void attribute_convert_calc(GeometryComponent &component,
component, source_name, result_name) :
domain;
if (conversion_can_be_skipped(component, source_name, result_name, result_domain, result_type)) {
return;
}
ReadAttributePtr source_attribute = component.attribute_try_get_for_read(
source_name, result_domain, result_type);
if (!source_attribute) {