blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 764 Projects 19 Wiki Activity

Cleanup: Replace Methode Overloading With Default Value.

This commit is contained in:
Jeroen Bakker 2021-03-26 15:56:27 +01:00
parent 6524ceb8cf
commit 2371454b2d
2 changed files with 8 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
source/blender/compositor/intern/COM_NodeOperation.cc
View File

@ -62,27 +62,18 @@ void NodeOperation::addOutputSocket(DataType datatype)
void NodeOperation::determineResolution(unsigned int resolution[2],
unsigned int preferredResolution[2])
{
unsigned int temp[2];
unsigned int temp2[2];
NodeOperationInput &input = m_inputs[m_resolutionInputSocketIndex];
input.determineResolution(resolution, preferredResolution);
unsigned int temp2[2] = {resolution[0], resolution[1]};
// TODO(jbakker): Replace for loops with direct array access.
unsigned int temp[2];
for (unsigned int index = 0; index < m_inputs.size(); index++) {
NodeOperationInput &input = m_inputs[index];
if (input.isConnected()) {
if (index == this->m_resolutionInputSocketIndex) {
input.determineResolution(resolution, preferredResolution);
temp2[0] = resolution[0];
temp2[1] = resolution[1];
break;
}
if (index == this->m_resolutionInputSocketIndex) {
continue;
}
}
for (unsigned int index = 0; index < m_inputs.size(); index++) {
NodeOperationInput &input = m_inputs[index];
if (input.isConnected()) {
if (index != this->m_resolutionInputSocketIndex) {
input.determineResolution(temp, temp2);
}
input.determineResolution(temp, temp2);
}
}
}

6
source/blender/compositor/intern/COM_NodeOperation.h
View File

@ -238,11 +238,7 @@ class NodeOperation {
{
return m_outputs.size();
}
NodeOperationOutput *getOutputSocket(unsigned int index);
NodeOperationOutput *getOutputSocket()
{
return getOutputSocket(0);
}
NodeOperationOutput *getOutputSocket(unsigned int index = 0);
NodeOperationInput *getInputSocket(unsigned int index);
/** Check if this is an input operation