Cleanup: clang-tidy

* `readability-redundant-member-init`
* `readability-inconsistent-declaration-parameter-name`
* Remove constructor that can be defaulted.
This commit is contained in:
Jacques Lucke 2021-06-01 12:00:16 +02:00
parent 9adfd278f7
commit 27910ccce6
5 changed files with 3 additions and 8 deletions

View File

@ -20,7 +20,7 @@
namespace blender::compositor {
BufferOperation::BufferOperation(MemoryBuffer *buffer, DataType data_type) : NodeOperation()
BufferOperation::BufferOperation(MemoryBuffer *buffer, DataType data_type)
{
buffer_ = buffer;
/* TODO: Implement a MemoryBuffer get_size() method returning a Size2d type. Shorten following

View File

@ -36,7 +36,6 @@ FullFrameExecutionModel::FullFrameExecutionModel(CompositorContext &context,
: ExecutionModel(context, operations),
active_buffers_(shared_buffers),
num_operations_finished_(0),
priorities_(),
work_mutex_(),
work_finished_cond_()
{

View File

@ -65,7 +65,7 @@ class MultiThreadedOperation : public NodeOperation {
private:
void update_memory_buffer(MemoryBuffer *output,
const rcti &output_rect,
const rcti &output_area,
blender::Span<MemoryBuffer *> inputs,
ExecutionSystem &exec_system) override;
};

View File

@ -22,11 +22,8 @@
namespace blender::compositor {
SharedOperationBuffers::SharedOperationBuffers() : buffers_()
{
}
SharedOperationBuffers::BufferData::BufferData()
: buffer(nullptr), render_areas(), registered_reads(0), received_reads(0)
: buffer(nullptr), registered_reads(0), received_reads(0)
{
}

View File

@ -46,7 +46,6 @@ class SharedOperationBuffers {
blender::Map<NodeOperation *, BufferData> buffers_;
public:
SharedOperationBuffers();
bool is_area_registered(NodeOperation *op, const rcti &area_to_render);
void register_area(NodeOperation *op, const rcti &area_to_render);