blender
/
blender
136
406
Fork 588
Code Issues 6.2k Pull Requests 755 Projects 19 Wiki Activity

Fix T83638: mirror modifier with mirror object renders wrong motion blur 

In this case both the mirror object and object itself moving in time may
change the geometry and must be checked.

Differential Revision: https://developer.blender.org/D10757
This commit is contained in:
Jishan Singh 2021-03-22 16:55:37 +01:00 committed by Brecht Van Lommel
parent 21268ad20a
commit 2c427d594f
Notes: blender-bot 2023-02-14 07:47:59 +01:00 
Referenced by issue #83638, Wrong motion blur with mirror modifier
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/blenkernel/intern/object.c
View File

@ -4885,7 +4885,7 @@ static bool object_deforms_in_time(Object *object)
return object_moves_in_time(object);
}
static bool constructive_modifier_is_deform_modified(ModifierData *md)
static bool constructive_modifier_is_deform_modified(Object *ob, ModifierData *md)
{
/* TODO(sergey): Consider generalizing this a bit so all modifier logic
* is concentrated in MOD_{modifier}.c file,
@ -4900,7 +4900,8 @@ static bool constructive_modifier_is_deform_modified(ModifierData *md)
}
if (md->type == eModifierType_Mirror) {
MirrorModifierData *mmd = (MirrorModifierData *)md;
return mmd->mirror_ob != NULL && object_moves_in_time(mmd->mirror_ob);
return mmd->mirror_ob != NULL &&
(object_moves_in_time(mmd->mirror_ob) || object_moves_in_time(ob));
}
if (md->type == eModifierType_Screw) {
ScrewModifierData *smd = (ScrewModifierData *)md;
@ -4984,7 +4985,7 @@ int BKE_object_is_deform_modified(Scene *scene, Object *ob)
bool can_deform = mti->type == eModifierTypeType_OnlyDeform || is_modifier_animated;
if (!can_deform) {
can_deform = constructive_modifier_is_deform_modified(md);
can_deform = constructive_modifier_is_deform_modified(ob, md);
}
if (can_deform) {