Fix T71137: curve minimum twist producing wrong geometry

Only one point should be used to create a reference rotation for other
points to follow. Using two caused the resulting twist to be
asymmetric, especially noticeable on symmetrical, cyclic curves.

Alternate fix to D11886 which caused T101843.
This commit is contained in:
Campbell Barton 2023-01-24 16:28:22 +11:00
parent 67c48314ba
commit 36a82314a0
Notes: blender-bot 2023-02-14 08:47:25 +01:00
Referenced by commit 564673b8ea, Fix T71137: curve minimum twist producing wrong geometry
Referenced by commit 9ad051140c, Revert "Fix T71137: curve minimum twist producing wrong geometry"
Referenced by issue #71137, off-by-one bug in spline interpolation produces wrong geometry
1 changed files with 1 additions and 1 deletions

View File

@ -2260,7 +2260,7 @@ static void make_bevel_list_3D_minimum_twist(BevList *bl)
nr = bl->nr;
while (nr--) {
if (nr + 3 > bl->nr) { /* first time and second time, otherwise first point adjusts last */
if (nr + 1 >= bl->nr) { /* First time, otherwise first point adjusts last. */
vec_to_quat(bevp1->quat, bevp1->dir, 5, 1);
}
else {