blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Fix T88313: GPencil reproject operator projecting on the wrong surface 

`ray_start` must start at the position of the gpencil point.
This commit is contained in:
Germano Cavalcante 2021-05-18 17:31:10 -03:00
parent f9567f6c63
commit 5400be9ffe
Notes: blender-bot 2023-02-13 22:20:49 +01:00 
Referenced by commit ea3895558d, Fix T88998: GPencil not projecting to the most front surface
Referenced by issue #88313, Grease pencil: Reproject strokes bad behavior when used in orthographic free navigation.
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/editors/gpencil/gpencil_utils.c
View File

@ -1276,7 +1276,6 @@ void ED_gpencil_stroke_reproject(Depsgraph *depsgraph,
}
else {
/* Geometry - Snap to surfaces of visible geometry */
float ray_start[3];
float ray_normal[3];
/* magic value for initial depth copied from the default
* value of Python's Scene.ray_cast function
@ -1285,13 +1284,14 @@ void ED_gpencil_stroke_reproject(Depsgraph *depsgraph,
float location[3] = {0.0f, 0.0f, 0.0f};
float normal[3] = {0.0f, 0.0f, 0.0f};
ED_view3d_win_to_ray(region, xy, &ray_start[0], &ray_normal[0]);
ED_view3d_win_to_vector(region, xy, &ray_normal[0]);
BLI_assert(gps->flag & GP_STROKE_3DSPACE);
if (ED_transform_snap_object_project_ray(sctx,
depsgraph,
&(const struct SnapObjectParams){
.snap_select = SNAP_ALL,
},
&ray_start[0],
&pt2.x,
&ray_normal[0],
&depth,
&location[0],