blender
/
blender
137
404
Fork 586
Code Issues 6.2k Pull Requests 756 Projects 19 Wiki Activity

Fix T98788: bad first curve tangent when first points have same position

This commit is contained in:
Jacques Lucke 2022-07-26 15:25:59 +02:00
parent 72f77598a2
commit 5945a90df9
Notes: blender-bot 2023-02-14 06:42:54 +01:00 
Referenced by issue #98788, Geometry Nodes: Curve to Mesh produces a strange mesh when trimmed at the exact same position as the Control Point
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/blenkernel/intern/curve_poly.cc
View File

@ -65,8 +65,21 @@ void calculate_tangents(const Span<float3> positions,
tangents.last() = direction_bisect(second_to_last, last, first, used_fallback);
}
else {
tangents.first() = math::normalize(positions[1] - positions.first());
tangents.last() = math::normalize(positions.last() - positions[positions.size() - 2]);
const float epsilon = 1e-6f;
if (math::almost_equal_relative(positions[0], positions[1], epsilon)) {
tangents.first() = {0.0f, 0.0f, 0.0f};
used_fallback = true;
}
else {
tangents.first() = math::normalize(positions[1] - positions[0]);
}
if (math::almost_equal_relative(positions.last(0), positions.last(1), epsilon)) {
tangents.last() = {0.0f, 0.0f, 0.0f};
used_fallback = true;
}
else {
tangents.last() = math::normalize(positions.last(0) - positions.last(1));
}
}
if (!used_fallback) {