GNUmakefile: rename test_depracted to check_deprecated

Also move this utility into the source/tools repo.
This commit is contained in:
Campbell Barton 2022-02-22 23:59:02 +11:00
parent 4a7559bbcb
commit 6bb4c0e498
2 changed files with 6 additions and 135 deletions

View File

@ -65,6 +65,7 @@ Static Source Code Checking
* check_cppcheck: Run blender source through cppcheck (C & C++).
* check_clang_array: Run blender source through clang array checking script (C & C++).
* check_deprecated: Check if there is any deprecated code to remove.
* check_splint: Run blenders source through splint (C only).
* check_sparse: Run blenders source through sparse (C only).
* check_smatch: Run blenders source through smatch (C only).
@ -410,10 +411,6 @@ test_cmake: .FORCE
@$(PYTHON) build_files/cmake/cmake_consistency_check.py > test_cmake_consistency.log 2>&1
@echo "written: test_cmake_consistency.log"
# run deprecation tests, see if we have anything to remove.
test_deprecated: .FORCE
@$(PYTHON) tests/check_deprecated.py
# -----------------------------------------------------------------------------
# Project Files
@ -491,6 +488,11 @@ check_descriptions: .FORCE
@$(BLENDER_BIN) --background -noaudio --factory-startup --python \
"$(BLENDER_DIR)/source/tools/check_source/check_descriptions.py"
# run deprecation tests, see if we have anything to remove.
check_deprecated: .FORCE
@PYTHONIOENCODING=utf_8 $(PYTHON) \
source/tools/check_source/check_deprecated.py
check_licenses: .FORCE
@PYTHONIOENCODING=utf_8 $(PYTHON) \
"$(BLENDER_DIR)/source/tools/check_source/check_licenses.py" \

View File

@ -1,131 +0,0 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# <pep8 compliant>
import os
from os.path import splitext
DEPRECATE_DAYS = 120
SKIP_DIRS = ("extern",
"tests", # not this dir
)
def is_c_header(filename):
ext = splitext(filename)[1]
return (ext in {".h", ".hpp", ".hxx", ".hh"})
def is_c(filename):
ext = splitext(filename)[1]
return (ext in {".c", ".cpp", ".cxx", ".m", ".mm", ".rc", ".cc", ".inl"})
def is_c_any(filename):
return is_c(filename) or is_c_header(filename)
def is_py(filename):
ext = splitext(filename)[1]
return (ext == ".py")
def is_source_any(filename):
return is_c_any(filename) or is_py(filename)
def source_list(path, filename_check=None):
for dirpath, dirnames, filenames in os.walk(path):
# skip '.git'
dirnames[:] = [d for d in dirnames if not d.startswith(".")]
for filename in filenames:
if filename_check is None or filename_check(filename):
yield os.path.join(dirpath, filename)
def deprecations():
"""
Searches out source code for lines like
/* *DEPRECATED* 2011/7/17 bgl.Buffer.list info text */
Or...
# *DEPRECATED* 2010/12/22 some.py.func more info */
"""
import datetime
SOURCE_DIR = os.path.normpath(os.path.abspath(os.path.normpath(os.path.join(os.path.dirname(__file__), ".."))))
SKIP_DIRS_ABS = [os.path.join(SOURCE_DIR, p) for p in SKIP_DIRS]
deprecations_ls = []
scan_tot = 0
print("scanning in %r for '*DEPRECATED* YYYY/MM/DD info'" % SOURCE_DIR)
for fn in source_list(SOURCE_DIR, is_source_any):
# print(fn)
skip = False
for p in SKIP_DIRS_ABS:
if fn.startswith(p):
skip = True
break
if skip:
continue
file = open(fn, 'r', encoding="utf8")
for i, l in enumerate(file):
# logic for deprecation warnings
if '*DEPRECATED*' in l:
try:
l = l.strip()
data = l.split('*DEPRECATED*', 1)[-1].strip().strip()
data = [w.strip() for w in data.split('/', 2)]
data[-1], info = data[-1].split(' ', 1)
info = info.split("*/", 1)[0]
if len(data) != 3:
print(" poorly formatting line:\n"
" %r:%d\n"
" %s" %
(fn, i + 1, l)
)
else:
data = datetime.datetime(*tuple([int(w) for w in data]))
deprecations_ls.append((data, (fn, i + 1), info))
except:
print("Error file - %r:%d" % (fn, i + 1))
import traceback
traceback.print_exc()
scan_tot += 1
print(" scanned %d files" % scan_tot)
return deprecations_ls
def main():
import datetime
now = datetime.datetime.now()
deps = deprecations()
print("\nAll deprecations...")
for data, fileinfo, info in deps:
days_old = (now - data).days
if days_old > DEPRECATE_DAYS:
info = "*** REMOVE! *** " + info
print(" %r, days-old(%.2d), %s:%d - %s" % (data, days_old, fileinfo[0], fileinfo[1], info))
if deps:
print("\ndone!")
else:
print("\nnone found!")
if __name__ == '__main__':
main()