blender
/
blender
136
406
Fork 589
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix T75472 Crash on "Remove Empty Animation Data" in NLA editor 

The `ANIMFILTER_NODUPLIS` option, to prevent duplicates in the list of
animation data to be freed, was missing. This caused a use-after-free.
This commit is contained in:
Sybren A. Stüvel 2020-04-21 13:23:51 +02:00
parent 5fed9ac9b5
commit 6f598ecc1a
Notes: blender-bot 2023-02-14 04:39:18 +01:00 
Referenced by issue #75472, Crash on "Remove Empty Animation Data" in NLA editor because of some materials
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/animation/anim_channels_edit.c
View File

@ -2268,7 +2268,8 @@ static int animchannels_clean_empty_exec(bContext *C, wmOperator *UNUSED(op))
}
/* get animdata blocks */
filter = (ANIMFILTER_DATA_VISIBLE | ANIMFILTER_LIST_VISIBLE | ANIMFILTER_ANIMDATA);
filter = (ANIMFILTER_DATA_VISIBLE | ANIMFILTER_LIST_VISIBLE | ANIMFILTER_ANIMDATA |
ANIMFILTER_NODUPLIS);
ANIM_animdata_filter(&ac, &anim_data, filter, ac.data, ac.datatype);
for (ale = anim_data.first; ale; ale = ale->next) {