blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Finish use-after-free in workbench code. 

GHash should probably not own the data itself, but that's other question
to be fixed later, at least this fixes the crash.

Solution by @fclem, thanks!
This commit is contained in:
Bastien Montagne 2018-04-19 10:25:52 +02:00
parent 8a923e5295
commit 79899373eb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/draw/engines/workbench/solid_studio_mode.c
View File

@ -71,9 +71,8 @@ static void workbench_solid_studio_cache_populate(void *vedata, Object *ob)
workbench_materials_solid_cache_populate(data, ob, V3D_LIGHTING_STUDIO);
}
static void workbench_solid_studio_cache_finish(void *vedata)
static void workbench_solid_studio_cache_finish(void *UNUSED(vedata))
{
workbench_materials_cache_finish((WORKBENCH_Data *)vedata);
}
static void workbench_solid_studio_draw_scene(void *vedata)
@ -83,6 +82,8 @@ static void workbench_solid_studio_draw_scene(void *vedata)
DRW_draw_pass(psl->depth_pass);
DRW_draw_pass(psl->solid_pass);
workbench_materials_cache_finish((WORKBENCH_Data *)vedata);
}
static void workbench_solid_studio_engine_free(void)