blender
/
blender
136
411
Fork 595
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

Fix T70484: GPencil particles crash when original stroke is hidden 

Due the internal design of the drawing engine and the special requirements for 2D inside 3D, it's required to keep the original stroke visible in order to display the particles. If the original stroke is hidden, the particles are hidden too.

This commit only fix the segmentation fault. Make visible the particles when the original is hidden would require a complete redesign and maybe would break some 2D features.
This commit is contained in:
Antonio Vazquez 2019-10-03 19:03:27 +02:00
parent edffb0e9b1
commit 79ca5ad368
Notes: blender-bot 2023-02-14 00:36:05 +01:00 
Referenced by issue #70484, Blender glitches, then crashes with GP object as particle instance
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/draw/engines/gpencil/gpencil_cache_utils.c
View File

@ -50,10 +50,6 @@ static bool gpencil_has_noninstanced_object(Object *ob_instance)
if (ob->type != OB_GPENCIL) {
continue;
}
/* object must be visible (invisible objects don't create VBO data) */
if (!(DRW_object_visibility_in_active_context(ob) & OB_VISIBLE_SELF)) {
continue;
}
/* is not duplicated and the name is equals */
if ((ob->base_flag & BASE_FROM_DUPLI) == 0) {
if (STREQ(ob->id.name, ob_instance->id.name)) {