blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 748 Projects 19 Wiki Activity

ED View3d: Fix possible bug when subtracting unsigned ints. 

Related to rB681661dbed12.
This commit is contained in:
Germano Cavalcante 2019-03-16 18:10:15 -03:00
parent 9e152f919f
commit 8b62f203d9
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/editors/space_view3d/view3d_draw_legacy.c
View File

@ -384,12 +384,19 @@ uint ED_view3d_select_id_read_nearest(
for (int b = 0; b < nr; b++) {
if (*tbuf && *tbuf >= min && *tbuf < max) {
/* we got a hit */
int hit_co[2], center_co[2];
/* get x,y pixel coords from the offset
* (manhatten distance in keeping with other screen-based selection) */
*r_dist = (float)(
abs(((int)(tbuf - buf) % height) - (height / 2)) +
abs(((int)(tbuf - buf) / height) - (height / 2)));
hit_co[0] = (int)(tbuf - buf) % (int)height;
hit_co[1] = (int)(tbuf - buf) / (int)height;
center_co[0] = (int)(height / 2);
center_co[1] = (int)(width / 2);
/* for more efficiency, just sum the x, y pixel dist coords */
*r_dist = (float)(abs(hit_co[0] - center_co[0]) +
abs(hit_co[1] - center_co[1]));
/* indices start at 1 here */
index = (*tbuf - min) + 1;