CMake: use BULLET_LIBRARIES for both extern_bullet and system libraries

There was no need to differentiate between these and it made
the CMake files more verbose.

CMakeLists.txt

@@ -1262,12 +1262,14 @@ endif()
 # -----------------------------------------------------------------------------
 # Configure Bullet
 
-if(WITH_BULLET AND WITH_SYSTEM_BULLET)
-  find_package(Bullet)
-  set_and_warn_library_found("Bullet" BULLET_FOUND WITH_BULLET)
-else()
-  set(BULLET_INCLUDE_DIRS "${CMAKE_SOURCE_DIR}/extern/bullet2/src")
-  # set(BULLET_LIBRARIES "")
+if(WITH_BULLET)
+  if(WITH_SYSTEM_BULLET)
+    find_package(Bullet)
+    set_and_warn_library_found("Bullet" BULLET_FOUND WITH_BULLET)
+  else()
+    set(BULLET_INCLUDE_DIRS "${CMAKE_SOURCE_DIR}/extern/bullet2/src")
+    set(BULLET_LIBRARIES "extern_bullet")
+  endif()
 endif()
 
 

intern/rigidbody/CMakeLists.txt

@@ -20,7 +20,6 @@ set(SRC
 )
 
 set(LIB
-  extern_bullet
   ${BULLET_LIBRARIES}
 )
 

source/blender/blenkernel/CMakeLists.txt

@@ -577,13 +577,6 @@ if(WITH_BULLET)
   list(APPEND INC
     ../../../intern/rigidbody
   )
-
-  if(NOT WITH_SYSTEM_BULLET)
-    list(APPEND LIB
-      extern_bullet
-    )
-  endif()
-
   list(APPEND LIB
     bf_intern_rigidbody
 

source/blender/bmesh/CMakeLists.txt

@@ -179,12 +179,6 @@ if(WITH_BULLET)
     ${BULLET_INCLUDE_DIRS}
     ../../../intern/rigidbody
   )
-  if(NOT WITH_SYSTEM_BULLET)
-  list(APPEND LIB
-    extern_bullet
-    )
-  endif()
-
   list(APPEND LIB
     ${BULLET_LIBRARIES}
   )

source/blender/modifiers/CMakeLists.txt

@@ -158,11 +158,9 @@ if(WITH_OPENSUBDIV)
 endif()
 
 if(WITH_BULLET)
-  if(NOT WITH_SYSTEM_BULLET)
-    list(APPEND LIB
-      extern_bullet
-    )
-  endif()
+  list(APPEND LIB
+    ${BULLET_LIBRARIES}
+  )
   add_definitions(-DWITH_BULLET)
 endif()
 

source/blender/nodes/CMakeLists.txt

@@ -92,12 +92,6 @@ if(WITH_BULLET)
     ${BULLET_INCLUDE_DIRS}
     ../../../intern/rigidbody
   )
-  if(NOT WITH_SYSTEM_BULLET)
-  list(APPEND LIB
-    extern_bullet
-  )
-  endif()
-
   list(APPEND LIB
     ${BULLET_LIBRARIES}
   )

source/blender/nodes/geometry/CMakeLists.txt

@@ -196,12 +196,6 @@ if(WITH_BULLET)
     ${BULLET_INCLUDE_DIRS}
     ../../../../intern/rigidbody
   )
-  if(NOT WITH_SYSTEM_BULLET)
-  list(APPEND LIB
-    extern_bullet
-    )
-  endif()
-
   list(APPEND LIB
     ${BULLET_LIBRARIES}
   )