blender
/
blender
136
405
Fork 587
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

Cleanup: Correct comment 

Normals aren't stored in custom data anymore, nor are they stored in
MVert for comparisons.
This commit is contained in:
Hans Goudey 2022-03-08 12:31:21 -06:00
parent c7ff99b100
commit 90c3147e05
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/blenkernel/intern/mesh.cc
View File

@ -142,11 +142,11 @@ static void mesh_copy_data(Main *bmain, ID *id_dst, const ID *id_src, const int
mesh_dst->mselect = (MSelect *)MEM_dupallocN(mesh_dst->mselect);
/* Set normal layers dirty, since they aren't included in CD_MASK_MESH and are therefore not
* copied to the destination mesh. Alternatively normal layers could be copied if they aren't
* dirty, avoiding recomputation in some cases. However, a copied mesh is often changed anyway,
* so that idea is not clearly better. With proper reference counting, all custom data layers
* could be copied as the cost would be much lower. */
/* Set normal layers dirty. They should be dirty by default on new meshes anyway, but being
* explicit about it is safer. Alternatively normal layers could be copied if they aren't dirty,
* avoiding recomputation in some cases. However, a copied mesh is often changed anyway, so that
* idea is not clearly better. With proper reference counting, all custom data layers could be
* copied as the cost would be much lower. */
BKE_mesh_normals_tag_dirty(mesh_dst);
/* TODO: Do we want to add flag to prevent this? */
@ -510,7 +510,6 @@ static int customdata_compare(
return MESHCMP_VERTCOMISMATCH;
}
}
/* I don't care about normals, let's just do coordinates. */
}
break;
}