Cleanup: remove some incorrectly placed consts

Clang-tidy reported that those parameters could be const,
but that is not true on windows.
This commit is contained in:
Jacques Lucke 2020-07-13 16:55:39 +02:00
parent 3d587efef2
commit 91e67c7bda
4 changed files with 12 additions and 4 deletions

View File

@ -51,7 +51,7 @@ const char *BKE_appdir_program_path(void);
const char *BKE_appdir_program_dir(void);
/* Return OS fonts directory. */
bool BKE_appdir_font_folder_default(const char *dir);
bool BKE_appdir_font_folder_default(char *dir);
/* find python executable */
bool BKE_appdir_program_python_search(char *fullpath,

View File

@ -1019,7 +1019,11 @@ void BKE_tempdir_session_purge(void)
}
/* Gets a good default directory for fonts */
bool BKE_appdir_font_folder_default(const char *dir)
bool BKE_appdir_font_folder_default(
/* This parameter can only be const on non-windows plaforms.
* NOLINTNEXTLINE: readability-non-const-parameter. */
char *dir)
{
bool success = false;
#ifdef WIN32

View File

@ -147,7 +147,7 @@ int BLI_access(const char *filename, int mode) ATTR_WARN_UNUSED_RESULT ATTR_NONN
bool BLI_file_is_writable(const char *file) ATTR_WARN_UNUSED_RESULT ATTR_NONNULL();
bool BLI_file_touch(const char *file) ATTR_NONNULL();
bool BLI_file_alias_target(const char *target, const char *filepath);
bool BLI_file_alias_target(char *target, const char *filepath);
#if 0 /* UNUSED */
int BLI_file_gzip(const char *from, const char *to) ATTR_WARN_UNUSED_RESULT ATTR_NONNULL();

View File

@ -290,7 +290,11 @@ eFileAttributes BLI_file_attributes(const char *path)
/* Return alias/shortcut file target. Apple version is defined in storage_apple.mm */
#ifndef __APPLE__
bool BLI_file_alias_target(const char target[FILE_MAXDIR], const char *filepath)
bool BLI_file_alias_target(
/* This parameter can only be const on non-windows plaforms.
* NOLINTNEXTLINE: readability-non-const-parameter. */
char target[FILE_MAXDIR],
const char *filepath)
{
# ifdef WIN32
if (!BLI_path_extension_check(filepath, ".lnk")) {