blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 760 Projects 19 Wiki Activity

Workbench: Fix unreported bug: garbage viewport when changing AA settings 

Was caused by uninitialized buffer.
This commit is contained in:
Clément Foucault 2020-04-16 18:12:48 +02:00
parent adc6659de5
commit 95a018aa32
Notes: blender-bot 2023-02-14 01:21:16 +01:00 
Referenced by issue #75815, Viewport Glitches while changing viewport anti-aliasing settings
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/draw/engines/workbench/workbench_effect_antialiasing.c
View File

@ -187,6 +187,10 @@ void workbench_antialiasing_engine_init(WORKBENCH_Data *vedata)
wpd->view_updated = false;
}
if (wpd->taa_sample_len > 0 && wpd->valid_history == false) {
wpd->taa_sample = 0;
}
{
float persmat[4][4];
DRW_view_persmat_get(NULL, persmat, false);
@ -420,6 +424,7 @@ void workbench_antialiasing_draw_pass(WORKBENCH_Data *vedata)
/* AA disabled. */
/* Just set sample to 1 to avoid rendering indefinitely. */
wpd->taa_sample = 1;
wpd->valid_history = false;
return;
}
@ -432,6 +437,7 @@ void workbench_antialiasing_draw_pass(WORKBENCH_Data *vedata)
const bool last_sample = wpd->taa_sample + 1 == wpd->taa_sample_len;
const bool taa_finished = wpd->taa_sample >= wpd->taa_sample_len;
if (wpd->taa_sample == 0) {
wpd->valid_history = true;
/* In playback mode, we are sure the next redraw will not use the same viewmatrix.
* In this case no need to save the depth buffer. */
eGPUFrameBufferBits bits = GPU_COLOR_BIT | (!wpd->is_playback ? GPU_DEPTH_BIT : 0);

2
source/blender/draw/engines/workbench/workbench_private.h
View File

@ -267,6 +267,8 @@ typedef struct WORKBENCH_PrivateData {
float taa_sample_inv;
/** If the view has been updated and TAA needs to be reset. */
bool view_updated;
/** True if the history buffer contains relevant data and false if it could contain garbage. */
bool valid_history;
/** View */
struct DRWView *view;
/** Last projection matrix to see if view is still valid. */