Fix T63635: Node Wrangler does not set relative paths for images using Add Texture Setup (Ctrl+Shift+T)

Using absolute paths for texture images break materials if the project is moved to another location or computer. Relative paths are also the default option in Image Texture Node's file view.

This adds a toggle to use relative paths when adding a texture setup for Principled BSDF. The option is selected by default to match Image Texture Node's behavior.

Tested on Blender v2.81.16 (Windows)

Reviewed By: lichtwerk, mont29

Maniphest Tasks: T63635

Differential Revision: https://developer.blender.org/D6756
This commit is contained in:
Santeri Salmijärvi 2020-02-12 10:29:17 +01:00 committed by Philipp Oeser
parent 0eb6dea518
commit 79f241abe0
Notes: blender-bot 2023-02-14 19:16:38 +01:00
Referenced by issue #63635, Node Wrangler does not set relative paths for images using Add Texture Setup (Ctrl+Shift+T)
1 changed files with 23 additions and 2 deletions

View File

@ -2661,11 +2661,23 @@ class NWAddPrincipledSetup(Operator, NWBase, ImportHelper):
options={'HIDDEN', 'SKIP_SAVE'}
)
relative_path: BoolProperty(
name='Relative Path',
description='Select the file relative to the blend file',
default=True
)
order = [
"filepath",
"files",
]
def draw(self, context):
layout = self.layout
layout.alignment = 'LEFT'
layout.prop(self, 'relative_path')
@classmethod
def poll(cls, context):
valid = False
@ -2747,6 +2759,15 @@ class NWAddPrincipledSetup(Operator, NWBase, ImportHelper):
print('No matching images found')
return {'CANCELLED'}
# Don't override path earlier as os.path is used to check the absolute path
import_path = self.directory
if self.relative_path:
if bpy.data.filepath:
import_path = bpy.path.relpath(self.directory)
else:
self.report({'WARNING'}, 'Relative paths cannot be used with unsaved scenes!')
print('Relative paths cannot be used with unsaved scenes!')
# Add found images
print('\nMatched Textures:')
texture_nodes = []
@ -2759,7 +2780,7 @@ class NWAddPrincipledSetup(Operator, NWBase, ImportHelper):
# DISPLACEMENT NODES
if sname[0] == 'Displacement':
disp_texture = nodes.new(type='ShaderNodeTexImage')
img = bpy.data.images.load(self.directory+sname[2])
img = bpy.data.images.load(path.join(import_path, sname[2]))
disp_texture.image = img
disp_texture.label = 'Displacement'
if disp_texture.image:
@ -2784,7 +2805,7 @@ class NWAddPrincipledSetup(Operator, NWBase, ImportHelper):
if not active_node.inputs[sname[0]].is_linked:
# No texture node connected -> add texture node with new image
texture_node = nodes.new(type='ShaderNodeTexImage')
img = bpy.data.images.load(self.directory+sname[2])
img = bpy.data.images.load(path.join(import_path, sname[2]))
texture_node.image = img
# NORMAL NODES