blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 760 Projects 19 Wiki Activity

Fix segfault when trying to free uninitialized loop normals 

Forgot this corner case when I created the new normal flip code.
This commit is contained in:
Sebastian Parborg 2020-05-15 13:37:04 +02:00
parent 3a14c011f9
commit a5d394fad2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/editors/mesh/editmesh_tools.c
View File

@ -2104,7 +2104,10 @@ static int edbm_flip_normals_exec(bContext *C, wmOperator *op)
if (flip_custom_normals(em->bm, lnors_ed_arr) || has_flipped_faces) {
EDBM_update_generic(obedit->data, true, false);
}
BM_loop_normal_editdata_array_free(lnors_ed_arr);
if (lnors_ed_arr != NULL) {
BM_loop_normal_editdata_array_free(lnors_ed_arr);
}
}
MEM_freeN(objects);
@ -2419,7 +2422,9 @@ static int edbm_normals_make_consistent_exec(bContext *C, wmOperator *op)
if (inside) {
EDBM_op_callf(em, op, "reverse_faces faces=%hf flip_multires=%b", BM_ELEM_SELECT, true);
flip_custom_normals(em->bm, lnors_ed_arr);
BM_loop_normal_editdata_array_free(lnors_ed_arr);
if (lnors_ed_arr != NULL) {
BM_loop_normal_editdata_array_free(lnors_ed_arr);
}
}
EDBM_update_generic(obedit->data, true, false);