blender
/
blender
136
406
Fork 587
Code Issues 6.2k Pull Requests 755 Projects 19 Wiki Activity

Cleanup: Avoid double negative in face corner normal calculation

This commit is contained in:
Hans Goudey 2022-12-08 14:45:48 -06:00
parent ce4c16b7e2
commit a92f2931ce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/blenkernel/intern/mesh_normals.cc
View File

@ -1784,7 +1784,10 @@ static void mesh_normals_loop_custom_set(const MVert *mverts,
* matching given custom lnors.
* Note this code *will never* unsharp edges! And quite obviously,
* when we set custom normals per vertices, running this is absolutely useless. */
if (!use_vertices) {
if (use_vertices) {
done_loops.fill(true);
}
else {
for (int i = 0; i < numLoops; i++) {
if (!lnors_spacearr.lspacearr[i]) {
/* This should not happen in theory, but in some rare case (probably ugly geometry)
@ -1883,9 +1886,6 @@ static void mesh_normals_loop_custom_set(const MVert *mverts,
&lnors_spacearr,
nullptr);
}
else {
done_loops.fill(true);
}
/* And we just have to convert plain object-space custom normals to our
* lnor space-encoded ones. */