blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 760 Projects 19 Wiki Activity

Set sharp flag in many places to keep default behavior unchanged

This commit is contained in:
Hans Goudey 2023-01-05 14:47:17 -05:00
parent 6a596e03fa
commit ad44bfbb6d
12 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/blenkernel/intern/volume_to_mesh.cc
View File

@ -183,6 +183,7 @@ Mesh *volume_to_mesh(const openvdb::GridBase &grid,
mesh->loops_for_write());
BKE_mesh_calc_edges(mesh, false, false);
BKE_mesh_smooth_flag_set(mesh, false);
return mesh;
}

8
source/blender/editors/object/object_remesh.cc
View File

@ -179,9 +179,7 @@ static int voxel_remesh_exec(bContext *C, wmOperator *op)
BKE_mesh_nomain_to_mesh(new_mesh, mesh, ob);
if (smooth_normals) {
BKE_mesh_smooth_flag_set(static_cast<Mesh *>(ob->data), true);
}
BKE_mesh_smooth_flag_set(static_cast<Mesh *>(ob->data), smooth_normals);
if (ob->mode == OB_MODE_SCULPT) {
ED_sculpt_undo_geometry_end(ob);
@ -903,9 +901,7 @@ static void quadriflow_start_job(void *customdata, bool *stop, bool *do_update,
BKE_mesh_nomain_to_mesh(new_mesh, mesh, ob);
if (qj->smooth_normals) {
BKE_mesh_smooth_flag_set(static_cast<Mesh *>(ob->data), true);
}
BKE_mesh_smooth_flag_set(static_cast<Mesh *>(ob->data), qj->smooth_normals);
if (ob->mode == OB_MODE_SCULPT) {
ED_sculpt_undo_geometry_end(ob);

1
source/blender/geometry/intern/mesh_primitive_cuboid.cc
View File

@ -408,6 +408,7 @@ Mesh *create_cuboid_mesh(const float3 &size,
MutableSpan<MVert> verts = mesh->verts_for_write();
MutableSpan<MPoly> polys = mesh->polys_for_write();
MutableSpan<MLoop> loops = mesh->loops_for_write();
BKE_mesh_smooth_flag_set(mesh, false);
calculate_verts(config, verts);

4
source/blender/modifiers/intern/MOD_volume_to_mesh.cc
View File

@ -183,9 +183,7 @@ static Mesh *modifyMesh(ModifierData *md, const ModifierEvalContext *ctx, Mesh *
}
BKE_mesh_copy_parameters_for_eval(mesh, input_mesh);
if (vmmd->flag & VOLUME_TO_MESH_USE_SMOOTH_SHADE) {
BKE_mesh_smooth_flag_set(mesh, true);
}
BKE_mesh_smooth_flag_set(mesh, vmmd->flag & VOLUME_TO_MESH_USE_SMOOTH_SHADE);
return mesh;
#else
UNUSED_VARS(md);

2
source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc
View File

@ -45,6 +45,8 @@ static Mesh *hull_from_bullet(const Mesh *mesh, Span<float3> coords)
BKE_id_material_eval_ensure_default_slot(&result->id);
}
BKE_mesh_smooth_flag_set(result, false);
/* Copy vertices. */
MutableSpan<MVert> dst_verts = result->verts_for_write();
for (const int i : IndexRange(verts_num)) {

1
source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc
View File

@ -105,6 +105,7 @@ static Mesh *cdt_to_mesh(const meshintersect::CDT_result<double> &result)
/* The delaunay triangulation doesn't seem to return all of the necessary edges, even in
* triangulation mode. */
BKE_mesh_calc_edges(mesh, true, false);
BKE_mesh_smooth_flag_set(mesh, false);
return mesh;
}

1
source/blender/nodes/geometry/nodes/node_geo_dual_mesh.cc
View File

@ -886,6 +886,7 @@ static Mesh *calc_dual_mesh(const Mesh &src_mesh,
}
Mesh *mesh_out = BKE_mesh_new_nomain(
vertex_positions.size(), new_edges.size(), 0, loops.size(), loop_lengths.size());
BKE_mesh_smooth_flag_set(mesh_out, false);
transfer_attributes(vertex_types,
keep_boundaries,

1
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc
View File

@ -109,6 +109,7 @@ static Mesh *create_circle_mesh(const float radius,
circle_corner_total(fill_type, verts_num),
circle_face_total(fill_type, verts_num));
BKE_id_material_eval_ensure_default_slot(&mesh->id);
BKE_mesh_smooth_flag_set(mesh, false);
MutableSpan<MVert> verts = mesh->verts_for_write();
MutableSpan<MEdge> edges = mesh->edges_for_write();
MutableSpan<MPoly> polys = mesh->polys_for_write();

1
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc
View File

@ -690,6 +690,7 @@ Mesh *create_cylinder_or_cone_mesh(const float radius_top,
Mesh *mesh = BKE_mesh_new_nomain(
config.tot_verts, config.tot_edges, 0, config.tot_corners, config.tot_faces);
BKE_mesh_smooth_flag_set(mesh, false);
BKE_id_material_eval_ensure_default_slot(&mesh->id);
MutableSpan<MVert> verts = mesh->verts_for_write();

1
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc
View File

@ -54,6 +54,7 @@ Mesh *create_grid_mesh(const int verts_x,
0,
edges_x * edges_y * 4,
edges_x * edges_y);
BKE_mesh_smooth_flag_set(mesh, false);
MutableSpan<MVert> verts = mesh->verts_for_write();
MutableSpan<MEdge> edges = mesh->edges_for_write();
MutableSpan<MPoly> polys = mesh->polys_for_write();

1
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc
View File

@ -315,6 +315,7 @@ static Mesh *create_uv_sphere_mesh(const float radius,
0,
sphere_corner_total(segments, rings),
sphere_face_total(segments, rings));
BKE_mesh_smooth_flag_set(mesh, false);
BKE_id_material_eval_ensure_default_slot(&mesh->id);
MutableSpan<MVert> verts = mesh->verts_for_write();
MutableSpan<MEdge> edges = mesh->edges_for_write();

1
source/blender/nodes/geometry/nodes/node_geo_volume_to_mesh.cc
View File

@ -141,6 +141,7 @@ static Mesh *create_mesh_from_volume_grids(Span<openvdb::GridBase::ConstPtr> gri
}
BKE_mesh_calc_edges(mesh, false, false);
BKE_mesh_smooth_flag_set(mesh, false);
return mesh;
}