blender
/
blender
136
406
Fork 589
Code Issues 6.2k Pull Requests 758 Projects 19 Wiki Activity

Fix T102532: bevel spikes with loop slide. 

There's a compromise of a code parameter called BEVEL_GOOD_ANGLE,
and bugs T44961, T86768, T95335, and this one, are all about problems
with various values of that parameter. If an angle of an adjacent
non-beveled edge is too close to that of the beveled edge, then you
get spikes. The BEVEL_GOOD_ANGLE says that if you are within that
angle difference, then no bevel happens. If the value is too small
then one gets spikes for certain models people build; if the value
is too large, then other people are annoyed that no bevel happens.
Hopefully this compromise in this commit is the final one I will do
before switching to Bevel v2, where none of this should be an issue.
This commit is contained in:
Howard Trickey 2023-01-22 10:28:12 -05:00
parent 537db96fb7
commit b544199c56
Notes: blender-bot 2023-05-26 07:58:06 +02:00 
Referenced by issue #102532, Regression: Bevel modifier spikes with the Loop Slide option
Referenced by issue #107910, Bevel Modifier pulling vertex
Referenced by issue #100749, Blender LTS: Maintenance Task 3.3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/bmesh/tools/bmesh_bevel.c
View File

@ -1506,7 +1506,7 @@ static void offset_meet(BevelParams *bp,
* Update: changed again from 0.0001f to fix bug T95335.
* Original two bugs remained fixed.
*/
#define BEVEL_GOOD_ANGLE 0.001f
#define BEVEL_GOOD_ANGLE 0.1f
/**
* Calculate the meeting point between e1 and e2 (one of which should have zero offsets),