Workaround for Access Violation startup crash on deprecated Radeon GPUs on Windows

This is a workaround for T80804.

There's a startup crash that happens on 2.91.0 on Windows, an `EXCEPTION_ACCESS_VIOLATION`
on `atio6axx.dll`. It is triggered by `glClear` on the `detect_mip_render_workaround`
function. The workaround moves the function after the device/driver workaround section and
sets the flag to the affected one to avoid running the check.

It is deprecated hardware that has not meet the minimum requirements since 2.79, but is
still usable and this extends its usability a bit before the cards are finally blacklisted.

Reviewed By: Jeroen Bakker

Differential Revision: https://developer.blender.org/D9667
This commit is contained in:
Jeroen Bakker 2020-12-09 12:14:44 +01:00
parent 1a959e9fa8
commit baf84ecbe4
Notes: blender-bot 2023-02-14 05:44:22 +01:00
Referenced by issue #102069, Crash When Trying To Use Shader Tab, Material Preview Mode and Eevee Engine.
Referenced by issue #83854, Blender 2.91 won't open
Referenced by issue #83760, Crash on Startup
3 changed files with 10 additions and 6 deletions

@ -1 +1 @@
Subproject commit 1c0e9c29fd33963ff42ff9252a64016abda8d2a7
Subproject commit 9e40c01dffd3f720b23b906d20df8e999d34a4af

@ -1 +1 @@
Subproject commit 7faa6b379fd818b8af8cf8279ff9f43cbdbb169e
Subproject commit 1191a172ac389e3d068a8ef7d16f36457e67e3bc

View File

@ -247,10 +247,6 @@ static void detect_workarounds()
return;
}
/* Some Intel drivers have issues with using mips as framebuffer targets if
* GL_TEXTURE_MAX_LEVEL is higher than the target mip.
* Only check at the end after all other workarounds because this uses the drawing code. */
GCaps.mip_render_workaround = detect_mip_render_workaround();
/* Limit support for GLEW_ARB_base_instance to OpenGL 4.0 and higher. NVIDIA Quadro FX 4800
* (TeraScale) report that they support GLEW_ARB_base_instance, but the driver does not support
* GLEW_ARB_draw_indirect as it has an OpenGL3 context what also matches the minimum needed
@ -271,6 +267,7 @@ static void detect_workarounds()
(strstr(version, "4.5.13399") || strstr(version, "4.5.13417") ||
strstr(version, "4.5.13422"))) {
GLContext::unused_fb_slot_workaround = true;
GCaps.mip_render_workaround = true;
GCaps.shader_image_load_store_support = false;
GCaps.broken_amd_driver = true;
}
@ -362,6 +359,13 @@ static void detect_workarounds()
}
}
/* Some Intel drivers have issues with using mips as framebuffer targets if
* GL_TEXTURE_MAX_LEVEL is higher than the target mip.
* Only check at the end after all other workarounds because this uses the drawing code.
* Also after device/driver flags to avoid the check that causes pre GCN Radeon to crash. */
if (GCaps.mip_render_workaround == false) {
GCaps.mip_render_workaround = detect_mip_render_workaround();
}
/* Disable multidraw if the base instance cannot be read. */
if (GLContext::shader_draw_parameters_support == false) {
GLContext::multi_draw_indirect_support = false;