blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 764 Projects 19 Wiki Activity

Fix T95335 Bevel operator Loop Slide overshoot. 

If the edge you are going to slide along is very close to in line
with the adjacent beveled edge, then there will be sharp overshoots.
There is an epsilon comparison to just abandon loop slide if this
situation is happening. That epsilon used to be 0.25 radians, but
bug T86768 complained that that value was too high, so it was changed
to .0001 radians (5 millidegrees). Now this current bug shows that
that was too aggressively small, so this change ups it by a factor
of 10, to .001 radians (5 centidegrees). All previous bug reports
remained fixed.
This commit is contained in:
Howard Trickey 2022-11-16 08:23:29 -05:00
parent 51914d4a4a
commit c2a68c066b
Notes: blender-bot 2023-02-14 10:37:50 +01:00 
Referenced by issue #95335, Regression: Bevel operator Loop Slide overshoot
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/bmesh/tools/bmesh_bevel.c
View File

@ -1502,8 +1502,10 @@ static void offset_meet(BevelParams *bp,
}
/* This was changed from 0.25f to fix bug T86768.
* Original bug T44961 remains fixed with this value. */
#define BEVEL_GOOD_ANGLE 0.0001f
* Original bug T44961 remains fixed with this value.
* Update : changed again from 0.0001f to fix bug T95335.*Original two bugs remained fixed.
*/
#define BEVEL_GOOD_ANGLE 0.001f
/**
* Calculate the meeting point between e1 and e2 (one of which should have zero offsets),