blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 765 Projects 19 Wiki Activity

Cleanup: rename 'count' to 'len' 

Reserve the term count for values that require calculation
(typically linked lists).

Without this convention it's difficult to know if using a length
accessor function in a loop will be O(N^2) without inspecting the
underlying implementation.
This commit is contained in:
Campbell Barton 2021-06-30 14:35:01 +10:00
parent 77ac1f39c4
commit c36d2a9a7a
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/editors/transform/transform_snap_sequencer.c
View File

@ -52,14 +52,14 @@ typedef struct TransSeqSnapData {
/** \name Snap sources
* \{ */
static int seq_get_snap_source_points_count(SeqCollection *snap_sources)
static int seq_get_snap_source_points_len(SeqCollection *snap_sources)
{
return SEQ_collection_count(snap_sources) * 2;
return SEQ_collection_len(snap_sources) * 2;
}
static void seq_snap_source_points_alloc(TransSeqSnapData *snap_data, SeqCollection *snap_sources)
{
const size_t point_count = seq_get_snap_source_points_count(snap_sources);
const size_t point_count = seq_get_snap_source_points_len(snap_sources);
snap_data->source_snap_points = MEM_callocN(sizeof(int) * point_count, __func__);
memset(snap_data->source_snap_points, 0, sizeof(int));
snap_data->source_snap_point_count = point_count;
@ -136,7 +136,7 @@ static int seq_get_snap_target_points_count(const TransInfo *t,
count += 2;
}
count *= SEQ_collection_count(snap_targets);
count *= SEQ_collection_len(snap_targets);
if (snap_mode & SEQ_SNAP_TO_PLAYHEAD) {
count++;

2
source/blender/sequencer/SEQ_iterator.h
View File

@ -71,7 +71,7 @@ bool SEQ_iterator_ensure(SeqCollection *collection,
struct Sequence *SEQ_iterator_yield(SeqIterator *iterator);
SeqCollection *SEQ_collection_create(void);
uint SEQ_collection_count(SeqCollection *collection);
uint SEQ_collection_len(SeqCollection *collection);
bool SEQ_collection_append_strip(struct Sequence *seq, SeqCollection *data);
bool SEQ_collection_remove_strip(struct Sequence *seq, SeqCollection *data);
void SEQ_collection_free(SeqCollection *collection);

2
source/blender/sequencer/intern/iterator.c
View File

@ -117,7 +117,7 @@ SeqCollection *SEQ_collection_create(void)
/**
* Return number of items in collection.
*/
uint SEQ_collection_count(SeqCollection *collection)
uint SEQ_collection_len(SeqCollection *collection)
{
return BLI_gset_len(collection->set);
}