Cleanup: improve comment about shape keys, correct spelling

This commit is contained in:
Campbell Barton 2020-10-27 13:49:45 +11:00
parent 6133159311
commit c686951233
2 changed files with 13 additions and 14 deletions

View File

@ -1427,9 +1427,9 @@ void BKE_lib_override_library_main_operations_create(Main *bmain, const bool for
}
/* Usual pose bones issue, need to be done outside of the threaded process or we may run into
* concurency issues here.
* concurrency issues here.
* Note that calling #BKE_pose_ensure again in thread in
* #BKE_lib_override_library_operations_create is not a problem then.. */
* #BKE_lib_override_library_operations_create is not a problem then. */
LISTBASE_FOREACH (Object *, ob, &bmain->objects) {
if (ob->type == OB_ARMATURE) {
BLI_assert(ob->data != NULL);

View File

@ -680,16 +680,15 @@ static int modifier_apply_shape(Main *bmain,
return 0;
}
/*
* It should be ridiculously easy to extract the original verts that we want
* and form the shape data. We can probably use the CD KEYINDEX layer (or
* whatever I ended up calling it, too tired to check now), though this would
* by necessity have to make some potentially ugly assumptions about the order
* of the mesh data :-/ you can probably assume in 99% of cases that the first
* element of a given index is the original, and any subsequent duplicates are
* copies/interpolates, but that's an assumption that would need to be tested
* and then predominantly stated in comments in a half dozen headers.
*/
/* We could investigate using the #CD_ORIGINDEX layer
* to support other kinds of modifiers besides deforming modifiers.
* as this is done in many other places, see: #BKE_mesh_foreach_mapped_vert_coords_get.
*
* This isn't high priority in practice since most modifiers users
* want to apply as a shape are deforming modifiers.
*
* If a compelling use-case comes up where we want to support other kinds of modifiers
* we can look into supporting them. */
if (ob->type == OB_MESH) {
Mesh *mesh_applied;
@ -722,7 +721,7 @@ static int modifier_apply_shape(Main *bmain,
BKE_id_free(NULL, mesh_applied);
}
else {
/* TODO: implement for hair, pointclouds and volumes. */
/* TODO: implement for hair, point-clouds and volumes. */
BKE_report(reports, RPT_ERROR, "Cannot apply modifier for this object type");
return 0;
}
@ -819,7 +818,7 @@ static int modifier_apply_obdata(
DEG_id_tag_update(&ob->id, ID_RECALC_GEOMETRY);
}
else {
/* TODO: implement for hair, pointclouds and volumes. */
/* TODO: implement for hair, point-clouds and volumes. */
BKE_report(reports, RPT_ERROR, "Cannot apply modifier for this object type");
return 0;
}