blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

Fix T92102: Issues with align euler to vector node 

For fixed pivots, make sure the correct pivot axis is being used.
Also add continues or invalid rotations.

Differential Revision: https://developer.blender.org/D12824
This commit is contained in:
Jarrett Johnson 2021-10-11 13:26:31 -05:00 committed by Hans Goudey
parent d993c7b503
commit ca8e8fd8d4
Notes: blender-bot 2023-02-13 23:17:13 +01:00 
Referenced by issue #92102, Align Eular to Vector Node bug
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/nodes/function/nodes/node_fn_align_euler_to_vector.cc
View File

@ -57,6 +57,7 @@ static void align_rotations_auto_pivot(IndexMask mask,
const float3 vector = vectors[i];
if (is_zero_v3(vector)) {
output_rotations[i] = input_rotations[i];
continue;
}
float old_rotation[3][3];
@ -106,10 +107,12 @@ static void align_rotations_fixed_pivot(IndexMask mask,
if (local_main_axis == local_pivot_axis) {
/* Can't compute any meaningful rotation angle in this case. */
output_rotations[i] = input_rotations[i];
continue;
}
const float3 vector = vectors[i];
if (is_zero_v3(vector)) {
output_rotations[i] = input_rotations[i];
continue;
}
@ -182,7 +185,7 @@ class MF_AlignEulerToVector : public fn::MultiFunction {
}
else {
float3 local_pivot_axis = {0.0f, 0.0f, 0.0f};
local_pivot_axis[main_axis_mode_] = 1;
local_pivot_axis[pivot_axis_mode_ - 1] = 1;
align_rotations_fixed_pivot(mask,
input_rotations,
vectors,