blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix: memory leak in curve circle primitive node

This commit is contained in:
Jacques Lucke 2022-12-05 15:34:54 +01:00
parent 83077d3683
commit ccae00c9e2
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc
View File

@ -109,12 +109,6 @@ static Curves *create_point_circle_curve(
return nullptr;
}
Curves *curves_id = bke::curves_new_nomain_single(resolution, CURVE_TYPE_POLY);
bke::CurvesGeometry &curves = bke::CurvesGeometry::wrap(curves_id->geometry);
curves.cyclic_for_write().first() = true;
MutableSpan<float3> positions = curves.positions_for_write();
float3 center;
/* Midpoints of `P1->P2` and `P2->P3`. */
const float3 q1 = math::interpolate(p1, p2, 0.5f);
@ -142,6 +136,12 @@ static Curves *create_point_circle_curve(
return nullptr;
}
Curves *curves_id = bke::curves_new_nomain_single(resolution, CURVE_TYPE_POLY);
bke::CurvesGeometry &curves = bke::CurvesGeometry::wrap(curves_id->geometry);
curves.cyclic_for_write().first() = true;
MutableSpan<float3> positions = curves.positions_for_write();
/* Get the radius from the center-point to p1. */
const float r = math::distance(p1, center);
const float theta_step = ((2 * M_PI) / float(resolution));