blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 762 Projects 19 Wiki Activity

Fix T71137: curve minimum twist producing wrong geometry 

Originally D11886 by @ghaspias with minor edits applied.
This commit is contained in:
Campbell Barton 2021-08-19 16:57:05 +10:00
parent 22ab0159a9
commit cf72194214
Notes: blender-bot 2023-02-14 04:10:15 +01:00 
Referenced by commit 67c48314ba, Revert "Fix T71137: curve minimum twist producing wrong geometry"
Referenced by issue #101843, Regression: cyclic curve twist behavior changed/broken
Referenced by issue #71137, off-by-one bug in spline interpolation produces wrong geometry
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source/blender/blenkernel/intern/curve.c
View File

@ -2331,17 +2331,21 @@ static void make_bevel_list_3D_minimum_twist(BevList *bl)
bevp1 = bevp2 + (bl->nr - 1);
bevp0 = bevp1 - 1;
nr = bl->nr;
while (nr--) {
/* The ordinal of the point being adjusted (bevp2). First point is 1. */
if (nr + 3 > bl->nr) { /* first time and second time, otherwise first point adjusts last */
vec_to_quat(bevp1->quat, bevp1->dir, 5, 1);
}
else {
minimum_twist_between_two_points(bevp1, bevp0);
}
/* First point is the reference, don't adjust.
* Skip this point in the following loop. */
if (bl->nr > 0) {
vec_to_quat(bevp2->quat, bevp2->dir, 5, 1);
bevp0 = bevp1;
bevp0 = bevp1; /* bevp0 is unused */
bevp1 = bevp2;
bevp2++;
}
for (nr = 1; nr < bl->nr; nr++) {
minimum_twist_between_two_points(bevp2, bevp1);
bevp0 = bevp1; /* bevp0 is unused */
bevp1 = bevp2;
bevp2++;
}