blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

Fix T81929: Sculpt: Mask operators missing drawing update on meshes with 

shapekeys/modifiers

This was failing for all mask filters (sharpen, grow, invert, clear,
shrink, contrast, smooth) and mask gestures (box, lasso).
Also have to recalc shading, use SCULPT_tag_update_overlays for this.

ref D8956

Maniphest Tasks: T81929

Differential Revision: https://developer.blender.org/D9302
This commit is contained in:
Philipp Oeser 2020-10-21 18:49:21 +02:00
parent 7ff6bfd1e0
commit d2f52dccd3
Notes: blender-bot 2023-02-14 03:03:03 +01:00 
Referenced by issue #81929, Sculpt: Mask operators missing drawing update on meshes with shapekeys/modifiers
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/sculpt_paint/paint_mask.c
View File

@ -657,8 +657,7 @@ static void sculpt_gesture_apply(bContext *C, SculptGestureContext *sgcontext)
SCULPT_undo_push_end();
ED_region_tag_redraw(sgcontext->vc.region);
WM_event_add_notifier(C, NC_OBJECT | ND_DRAW, sgcontext->vc.obact);
SCULPT_tag_update_overlays(C);
}
/* Face Set Gesture Operation. */

5
source/blender/editors/sculpt_paint/sculpt_filter_mask.c
View File

@ -192,7 +192,6 @@ static void mask_filter_task_cb(void *__restrict userdata,
static int sculpt_mask_filter_exec(bContext *C, wmOperator *op)
{
ARegion *region = CTX_wm_region(C);
Object *ob = CTX_data_active_object(C);
SculptSession *ss = ob->sculpt;
Depsgraph *depsgraph = CTX_data_depsgraph_pointer(C);
@ -259,8 +258,8 @@ static int sculpt_mask_filter_exec(bContext *C, wmOperator *op)
SCULPT_undo_push_end();
ED_region_tag_redraw(region);
WM_event_add_notifier(C, NC_OBJECT | ND_DRAW, ob);
SCULPT_tag_update_overlays(C);
return OPERATOR_FINISHED;
}