blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T98727: Dynamic Paint does not update normals 

Caused by {rB6a3c3c77b3eb}.

Displacement and wave were tagging the original mesh normals dirty,
instead the result's normals need tagging. Seems like a typo in above
commit (similar to rBfe43c170831f).

Maniphest Tasks: T98727

Differential Revision: https://developer.blender.org/D15165
This commit is contained in:
Philipp Oeser 2022-06-10 10:31:44 +02:00
parent 28f852ccc3
commit d83a418c45
Notes: blender-bot 2023-02-14 09:09:43 +01:00 
Referenced by issue #98727, Regression: Dynamic Paint displacement do not update normals in 3.2
Referenced by issue #98661, 3.2: Potential candidates for corrective releases
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/blenkernel/intern/dynamicpaint.c
View File

@ -2024,13 +2024,13 @@ static Mesh *dynamicPaint_Modifier_apply(DynamicPaintModifierData *pmd, Object *
settings.use_threading = (sData->total_points > 1000);
BLI_task_parallel_range(
0, sData->total_points, &data, dynamic_paint_apply_surface_wave_cb, &settings);
BKE_mesh_normals_tag_dirty(mesh);
BKE_mesh_normals_tag_dirty(result);
}
/* displace */
if (surface->type == MOD_DPAINT_SURFACE_T_DISPLACE) {
dynamicPaint_applySurfaceDisplace(surface, result);
BKE_mesh_normals_tag_dirty(mesh);
BKE_mesh_normals_tag_dirty(result);
}
}
}