blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix crash activating a fullscreened screen 

Steps to reproduce were:
* Duplicate some area into new window (shift-click corner triangle)
* Make it fullscreen
* Close the window again
* Activate the added screen from the menu (the one without the
  -nonnormal prefix)
-> Crash (you may have to press "Back to Previous" first though)

When activating a screen, code should check if there's a fullscreen
variant of it and activate that instead. From what I can tell that's
what the code tried to do, but incorrectly.

Same issue as T64045, but things are a bit different for 2.7.
This commit is contained in:
Julian Eisel 2019-05-04 15:12:55 +02:00
parent 2adf4b401e
commit d83a72ec10
Notes: blender-bot 2023-02-14 09:09:43 +01:00 
Referenced by commit 94a064c0e9, Fix T64045: Crash activating fullscreen workspace
Referenced by issue #64908, In Pose Mode, clearing a bones Scale Transform also clears that bone's Bendy Bone Ease in/out values and also Scale in/out values
Referenced by issue #64548, Color Wheels not working correctly using using Troy Sobotka version of the OCIO configuration
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/editors/screen/screen_edit.c
View File

@ -1195,10 +1195,9 @@ bool ED_screen_set(bContext *C, bScreen *sc)
return true;
}
if (ELEM(sc->state, SCREENMAXIMIZED, SCREENFULL)) {
/* find associated full */
bScreen *sc1;
for (sc1 = bmain->screen.first; sc1; sc1 = sc1->id.next) {
/* find associated full */
for (bScreen *sc1 = bmain->screen.first; sc1; sc1 = sc1->id.next) {
if ((sc1 != sc) && ELEM(sc1->state, SCREENMAXIMIZED, SCREENFULL)) {
ScrArea *sa = sc1->areabase.first;
if (sa->full == sc) {
sc = sc1;